db7d04db79
Remove obsolete flag `--json` (that was marked hidden), kept for VSCode extension but is not used, `docker context ls --format “{{ json . }}”` is used.
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-11-04 14:54:01 +01:00
aeab918688
tests: Replace Python test image with Go binary
...
Signed-off-by: Chris Crone <christopher.crone@docker.com>
2020-11-03 18:50:44 +01:00
1a5ce029b4
Changed test img to `dockerinternal` org, removed the need of 2 images, added ECS E2E secret validation
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-11-03 18:04:45 +01:00
dd5f66ff09
Merge pull request #868 from docker/aci_e2e_regroup
...
Regroup secret and resource ACI E2E test, and deploy a single compose file, to gain ~1 min test exec time
2020-11-03 15:21:37 +01:00
ba0d2907ed
Also validate we can share some secrets between services but not all secrets, without leaking secrets.
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-11-03 15:05:57 +01:00
a26e1bd1a5
Regroup secret and resource ACI E2E test, and deploy a single compose file, to gain ~1 min test exec time
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-11-03 13:39:49 +01:00
f66123b34a
Merge pull request #846 from docker/ecs_context
2020-11-03 11:38:06 +01:00
3b6bfdd5b1
Display ecs status in CamelCase in order to have homogeneous output between backends.
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-11-02 13:08:54 +01:00
0670df442c
Merge pull request #855 from docker/local-rm
...
Add --rm support to run with the local backend
2020-11-02 09:49:26 +01:00
25e6a18fef
backend: Add --rm support to local backend
...
Signed-off-by: Chris Crone <christopher.crone@docker.com>
2020-10-30 18:19:02 +01:00
7ef99e163a
ECS E2E test using multi-container , multi-port publish app and validating cross-container communication
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-30 17:41:39 +01:00
c3cc54316b
This new field Named “Type” breaks VSCode extension for some strange reason, lets rename it ContextType
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-30 13:32:13 +01:00
7cc3bc3870
No breaking change on `docker context ls —format “{{ json . }}` , this is used by VSCode extension
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-30 10:37:36 +01:00
a78cc47b1c
Use HttpgetWithRetry() that’ll set timeout for each retry and not freeze on he first call
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-29 17:25:40 +01:00
53efa312c8
Refactor context create options
...
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-10-29 10:25:23 +01:00
02501407de
Add update command for backward compatibility
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-28 14:26:32 +01:00
7490584a41
Fix e2e GET timeout, was *1000 twice :facepalm
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-27 11:33:44 +01:00
83716a5eb2
Return json array for `ps/ls --format json` commands
...
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-10-23 14:07:03 +02:00
8f31ad59be
Refactor secrets
...
- create secrets from files
- update Secret structure
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-10-19 11:33:55 +02:00
333e4e5675
Merge pull request #787 from docker/add-abs-path-secret-target
...
Support absolute paths for secrets
2020-10-16 11:59:27 +02:00
05295b5e8a
Merge pull request #765 from docker/ecs_default_profile
...
Populate ~/.aws/config(credentials) on ecs context create
2020-10-16 11:33:03 +02:00
c2af0a136a
Populate ~/.aws/config(credentials) on ecs context create
...
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-10-15 20:26:38 +02:00
06e44a813c
Support absolute paths for secrets
...
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-10-15 15:46:07 +02:00
50a2ae1100
Display summary of reclaimed ACI resources (CPU/mem) in `docker prune`
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-15 15:45:48 +02:00
bb9b059288
Merge pull request #785 from docker/disable_more_aci_tests
...
Make ACI exec test less strict to handle differing outputs
2020-10-15 09:45:57 +02:00
a5e34323e2
Add `docker prune` command and ACI implementation
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-14 17:48:11 +02:00
1bd5ed56bc
Make one ACI test less strict, we still encounter issues related to deployments on Atlas platform (errors on `docker exec`: failed to read input from container: ws closed: 1000, cf https://github.com/docker/compose-cli/runs/1247798295 )
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-14 14:35:00 +02:00
660c7bbdcf
Add command "volume inspect"
...
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-10-14 11:11:55 +02:00
1a4d45dd06
Too flaky, see https://github.com/docker/compose-cli/runs/1246970427
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-13 12:28:22 +02:00
9f5f1cc4c3
Add debug information when mysql cannot start on ACI E2E test
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-13 09:37:12 +02:00
be4b9a6812
Merge pull request #760 from docker/add-quiet-flags
...
Add --quiet for some commands
2020-10-13 09:00:58 +02:00
7b8255c953
Replaces windows carriage return for windows tests
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-12 17:23:47 +02:00
a4f10c171e
Test DB Startup timeout 60s => 90s
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-12 16:48:18 +02:00
5b54816a1a
Merge pull request #757 from docker/secrets-refactor
...
Squash all secrets in a single one
2020-10-12 14:40:59 +02:00
45212c6e21
Squash all secrets in a single one
...
Also adds an e2e test
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-10-12 14:17:37 +02:00
0dfea32250
Revert "Temporarily disable some red ACI tests, to be put reverted once the platform is back to green (hopefully in a day or 2)"
...
This reverts commit b10acc1a60
2020-10-12 14:08:22 +02:00
6c1ea32dae
Add --quiet for some commands
...
- compose ls
- compose ps
- secret ls // Not implemented on ACI so no e2e-aci tests
- volume ls
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-10-12 11:34:27 +02:00
99186b1d04
Look for all mounts before removing a volume
...
This checks the volume mounts of all container groups from all
resource groups before removing a volume/fileshare
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-10-09 14:39:21 +02:00
289c83efe2
HttpRetry : do not get stuck on first call, timeout http requests and retry in case of failures
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-09 14:27:24 +02:00
4f87422a79
more debug info when ports available but hostIP is empty ; Seems to be a race where container has status running but not yet an IP allocated
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-09 14:09:09 +02:00
019268dded
Fix e2e tests on comparing with empty string
...
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-10-09 13:21:17 +02:00
68d0413e36
Minor cleanup
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-09 11:53:53 +02:00
6516632ecf
Add resource reservations to container inspect
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-08 17:47:16 +02:00
b1edfb6507
Change inspect json output to group things a bit more nicely, and more like Moby json output
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-08 17:03:30 +02:00
a09983b474
Do not send metrics for help commands
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-08 14:47:31 +02:00
0d3f7186c5
Hardcoded list of commands and simplified metrics gathering.
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-08 11:59:12 +02:00
cd09351b0a
Fix ACI E2E test on windows (file path)
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-07 10:38:33 +02:00
9ad06e55b5
E2e test on metrics
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-07 10:11:46 +02:00
6fa93db021
Merge pull request #724 from gtardif/json_context_format
...
Allow `docker context ls —formatter {{json.}}` to not delegate to Moby and include context type in the json
2020-10-06 18:12:54 +02:00
a1bb2d5abe
Allow `docker context ls —formatter {{json.}}` to not delegate to Moby and include context type in the json
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-06 18:00:35 +02:00
9cc914ef07
No need for docker dependency for CopyDir, and yaml parser.
...
No need for multiport compose file with volumes
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-06 17:54:26 +02:00
f8a3aec64d
Add aci volumes e2e test
...
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-10-06 17:22:57 +02:00
5c0a953f7e
Merge pull request #731 from docker/atlas_test_disable
...
Temporarily disable some red ACI tests
2020-10-06 13:51:32 +02:00
b10acc1a60
Temporarily disable some red ACI tests, to be put reverted once the platform is back to green (hopefully in a day or 2)
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-06 13:29:27 +02:00
d9115d4089
Add windows golden file for `context ls`
...
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-10-06 11:50:27 +02:00
97576db803
Merge pull request #689 from ulyssessouza/json-out
...
Add json output format to several commands
2020-10-05 10:30:30 +02:00
71238b261d
Running tests in many regions to avoid per region limit when we run too many // things in the CI
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-05 09:36:43 +02:00
e4fff081db
Merge pull request #711 from docker/fix_aci_500
...
ACI tests : Wait for http status and retry if necessary.
2020-10-02 17:30:23 +02:00
6d0f7f399f
Fix regression: let users login to local registry (no '.' In registry name)
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-02 13:54:59 +02:00
a07b1db9f1
Wait for http status and retry if necessary. We were getting 500 errors because database is not ready initially
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-01 18:09:34 +02:00
b8a1e6c888
Change JSON output to individual lines
...
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-10-01 15:41:18 +02:00
3e9095a873
Fix docker context ls for retrocompatibility
...
It writes each context as an independent object line
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-10-01 15:41:18 +02:00
0f6f547214
Refactor Print method for lists
...
This also fixes in the case of nil list
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-10-01 15:41:18 +02:00
8961805412
Add json output format to several commands
...
- docker context ls
- docker ps
- docker compose ls
- docker compose ps
- docker secret ls
- docker volume ls
- docker version
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-10-01 15:41:18 +02:00
7941e048a1
Fix ACI e2e : now we support passing commands, set `--domainname` before the image in the cmd
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-01 12:56:47 +02:00
b8968e83cd
Do not fail when constructing error message for commands not implemented. Use metrics GetCommand() the is already used 3 lines above for metrics tracking.
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-30 10:49:14 +02:00
ca35ccfb0e
ACI Volumes : create takes one required arg, instead of required flag `--fileshare` (we still have required flag `--storage-account` specifically for ACI)
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-24 17:10:32 +02:00
7eda96bea4
Fix nil pointer when creating volume with “” storage account
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-24 12:59:29 +02:00
334ebf5f75
Implement --domainname flag on compose up, also defining compose extension "x-aci-domain-name" to store ACI DNSLabelName.
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-22 14:41:31 +02:00
701d1b834e
ACI: allow users to set DNSLabelName and deploy containers with fqdn like `myapp.eastus.azurecontainers.io`
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-22 14:41:31 +02:00
7abdb085c0
Merge pull request #637 from docker/volume_tests
...
Added tests on ACI volume conversion, mock storageLogin required to get storage account keys
2020-09-22 14:40:46 +02:00
0092de6df1
Added tests on ACI volume conversion, mock storageLogin required to get storage account keys
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-22 14:24:12 +02:00
d154c41586
Update copyright
...
Signed-off-by: Chris Crone <christopher.crone@docker.com>
2020-09-22 12:13:00 +02:00
17bda79ca1
Changing e2e test PATH to make windows tests pass
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-17 17:13:05 +02:00
9c6aead797
Allow running commands with HOME=“”.
...
Do not try to create ~/.docker before using CONFIG_DIR. HOME=“” will result in trying to use a relative .docker folder as default config folder, and if we cannot create the context store for any reason, try delegate to Moby CLI.
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-17 09:08:17 +02:00
2ce4e98d88
In version, replace “Azure integration” version info by “Cloud integration”
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-11 17:29:40 +02:00
57ded74aee
Merge pull request #598 from docker/encode_env_values
...
Properly send env variables containing “=“ in their value in ACI payload. Also properly send quoted values
2020-09-10 17:17:02 +02:00
98f0064fe9
Properly send env variables containing “=“ in their value in ACI payload. Also properly send quoted values
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-10 17:03:34 +02:00
0b3fdb637d
Change volume IDs from “storageaccount@fileshare“ to “storageaccount/fileshare”
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-10 16:07:22 +02:00
c7a456ab83
Merge pull request #593 from docker/volume_create
...
ACI Volume create
2020-09-10 15:32:12 +02:00
80d23a6097
Removed NAME from `volume ls` output, allow `volume delete <ID>` using IDs from `volume ls`.
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-10 09:14:39 +02:00
96d785a5bd
Added volume delete, can delete juste a file share or the storage account if confirmed
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-08 16:32:16 +02:00
d4c745a7a8
AWS CI environment is not dedicated to tests
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-09-08 15:47:24 +02:00
2f672f6c4c
Volume e2e test
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-08 15:30:50 +02:00
08562b403e
Connecting it all
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-08 15:30:50 +02:00
171ab1bd0c
Most common scenario is to use `compose ls` without name option, and list all stacks
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-08 10:11:51 +02:00
a2e0f16f07
Merge pull request #592 from docker/fix_compose_ls_tests
...
Fix `compose ls` tests
2020-09-08 09:06:39 +02:00
9098405313
Fix `compose ls` tests
...
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-09-07 17:06:35 +02:00
7545485f78
Merge pull request #591 from docker/flaky-aci
...
Attempt to fix flaky ACI tests
2020-09-07 17:05:58 +02:00
3ed90ea467
replace check with Equal in e2e test
...
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-09-07 14:49:15 +02:00
19a707495f
add test for compose ls
...
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-09-07 14:39:49 +02:00
e4e77bd198
e2e.aci: Retry flaky HTTP GET requests
...
Signed-off-by: Chris Crone <christopher.crone@docker.com>
2020-09-07 13:43:49 +02:00
6f0f9e5600
e2e.framework: Add helper to retry HTTP requests
...
Signed-off-by: Chris Crone <christopher.crone@docker.com>
2020-09-07 13:43:48 +02:00
d06aa2827f
Move containers, compose, secrets to /api
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-07 13:22:08 +02:00
7138ecc899
ACI : when following logs (actually polling logs), stop polling when the container is not running anymore.
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-04 15:46:35 +02:00
c7e2db077e
Merge pull request #544 from docker/simulation
...
Introduce ECS emulation mode
2020-09-01 15:18:32 +02:00
58cb3491ae
Wait only for the first “DELETE_COMPLETE” line when running `docker compose down` (~4 secs, instead of waiting 8-9 mins for the entire aws stack to be deleted), and let aws fully delete stack async.
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-01 09:33:13 +02:00
4d11594df0
default description if none set by user
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-08-31 17:10:59 +02:00
4693ce91f6
e2e test to check ecs-local context creation
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-08-31 16:54:02 +02:00
b0c50ed6dd
Implement compose ps on ACI
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-08-28 17:43:18 +02:00
Guillaume Tardif
Chris Crone
Nicolas De loof
aiordache
Anca Iordache
Ulysses Souza
guillaume.tardif
Ulysses Souza