25c5a8cd72
fixing empty vpcId
...
Signed-off-by: flaviostutz <flaviostutz@gmail.com>
2020-10-30 10:49:04 -03:00
24b40e1a8d
Merge pull request #854 from gtardif/retro-compat-context-json-list
...
Revert breaking change on `docker context ls —format “{{ json . }}`
2020-10-30 13:43:46 +01:00
c3cc54316b
This new field Named “Type” breaks VSCode extension for some strange reason, lets rename it ContextType
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-30 13:32:13 +01:00
7cc3bc3870
No breaking change on `docker context ls —format “{{ json . }}` , this is used by VSCode extension
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-30 10:37:36 +01:00
810461179b
Merge pull request #850 from docker/fix_path_appending
...
Fix path appending
2020-10-29 17:47:13 +01:00
a78cc47b1c
Use HttpgetWithRetry() that’ll set timeout for each retry and not freeze on he first call
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-29 17:25:40 +01:00
b604ba6246
Fix 2 corner cases with PATH settings
...
* windows PATH should use windows separator (;)
* do not add separator if initial PATH is empty (was creating PATH=:/path)
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-29 15:35:22 +01:00
5e809acd87
Use OS-dependant pathListSeparator, when appending to PATH
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-29 15:09:38 +01:00
2ff803bf44
Merge pull request #842 from gtardif/remove_aci_integration_docs
...
Remove aci-integration.md, all info moved to docs.docker.com
2020-10-29 14:04:00 +01:00
879afa85c0
fix lint issues
...
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-10-29 11:33:56 +01:00
2fdc93786e
Fix region from environment
...
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-10-29 10:51:57 +01:00
53efa312c8
Refactor context create options
...
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-10-29 10:25:23 +01:00
e44d0b922a
cleanup
...
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-10-29 10:10:00 +01:00
902b660de1
revisit context creation
...
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-10-29 10:10:00 +01:00
2dcd1a5826
refactor ecs context creation
...
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-10-29 10:10:00 +01:00
5450791ba7
Merge pull request #843 from docker/pin_image_version
...
Pin version of ACI sidecar image, so that we don’t affect prod users when re-publishing :latest.
2020-10-29 09:37:07 +01:00
699e7c5074
Merge pull request #844 from imrehg/network-typo
...
cloudformation: fix typo in generated ingress description
2020-10-29 09:35:41 +01:00
d6461df474
cloudformation: fix typo in generated ingress description
...
Signed-off-by: Gergely Imreh <imrehg@gmail.com>
2020-10-28 22:44:20 +00:00
5bdcfe2e4a
Pin version of ACI sidecar image, so that we don’t affect prod users when re-publishing :latest.
...
Makefile includes a target to publish new versions, ensuring we don’t override an existing image tag
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-28 17:19:12 +01:00
498072452f
Remove sci-integration.md, all info moved to docs.docker.com
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-28 16:07:30 +01:00
bfd9f5b431
Merge pull request #838 from gtardif/docs_rearrange
...
Docs: adding docs README, moving ecs docs in docs folder, removing ob…
2020-10-28 14:47:18 +01:00
e881c8c7c4
Apply suggestions from code review
...
Co-authored-by: Chris Crone <christopher.crone@docker.com>
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-28 14:35:40 +01:00
a6af33a418
Merge pull request #840 from gtardif/fix_context_update
...
Add update command for backward compatibility
2020-10-28 14:32:29 +01:00
02501407de
Add update command for backward compatibility
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-28 14:26:32 +01:00
e143ce15aa
Merge pull request #837 from gtardif/clean_empty_file
...
Remove empty file added by error
2020-10-28 14:10:08 +01:00
c1504d484f
Docs: adding docs README, moving ecs docs in docs folder, removing obsolete cli docs
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-28 10:44:42 +01:00
39558c76f0
Merge pull request #836 from docker/bump-deps
...
Bump dependencies
2020-10-27 16:25:27 +01:00
10d1f9847f
Remove empty file added by error
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-27 15:05:27 +01:00
c8b8a9f767
deps: Bump
...
Build:
* Golang 1.15.2 to 1.15.3
* golangci-lint 1.31.0 to 1.32.0
* protoc-gen-go 1.4.1 to 1.4.3
All direct Go dependencies except Azure/azure-sdk-for-go which required
code changes.
Signed-off-by: Chris Crone <christopher.crone@docker.com>
2020-10-27 14:09:38 +01:00
62aca4457d
Merge pull request #827 from gtardif/api_deprecated_fields
...
Removing API deprecated fields (unused in VSCode Docker extension)
2020-10-27 12:11:41 +01:00
56b4c772a2
Merge pull request #833 from docker/add-run-rm
...
Add --rm to run command (as not yet implemented)
2020-10-27 11:54:30 +01:00
511df55a76
Merge pull request #835 from docker/e2e_GET_timeout
...
Fix e2e GET timeout, was *1000 twice
2020-10-27 11:54:01 +01:00
7490584a41
Fix e2e GET timeout, was *1000 twice :facepalm
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-27 11:33:44 +01:00
367753303d
Merge pull request #832 from gtardif/fix_aci_etchosts
...
Add trailing empty line in /etc/hosts
2020-10-27 09:50:04 +01:00
74b35e3ef3
Merge pull request #834 from sarathkumarsivan/fix-typo-prompt
...
Fix typo in comments against Password method attached to User struct
2020-10-27 09:43:06 +01:00
3e797f5088
Add trailing empty line in /etc/hosts that seem to be causing flakiness in name resolution for the last service mentioned
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-27 09:41:19 +01:00
0293ef185d
Fix typo in comments against Password method attached to User struct
...
Signed-off-by: Sarath Kumar Sivan <sarathkumarsivan@gmail.com>
2020-10-26 22:09:27 -07:00
69083e07e6
Add --rm to run command (as not yet implemented)
...
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-10-27 01:57:35 +01:00
1ecfa703f5
Merge pull request #831 from gtardif/fix_ecs_resolve
...
Fix Dockerfile syntax in ecs sidecars
2020-10-26 16:51:27 +01:00
0d197401a2
Fix Dockerfile syntax in ecs sidecars introduced by https://github.com/docker/compose-cli/pull/799
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-26 16:42:51 +01:00
382827241d
Merge pull request #799 from docker/aci_etchosts
...
minimalist container image to setup /etc/hosts on ACI
2020-10-26 15:58:19 +01:00
2740b0a38d
Merge pull request #828 from gtardif/doc_fix_secrets
...
Small fixes in secrets docs
2020-10-26 15:25:24 +01:00
b138a3e4f6
Log something to be able to see what is happening remotely
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-26 15:21:16 +01:00
99390d1dd8
Merge pull request #826 from sarathkumarsivan/typo-Event
...
Fix typo in comments against Event struct definition inside writer.go
2020-10-26 15:15:11 +01:00
3fadf9068e
Small fixes in secrets docs
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-26 15:13:02 +01:00
18e43b277c
fmt.Scanln() does not wait forever… waiting for process termination signal
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-26 15:06:30 +01:00
3dddbcd7df
We need to pass the full command and not rely on ENTRYPOINT for ACI containers, ACI overrides the ENTRYPOINT with commands.
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-26 15:03:37 +01:00
63c6a3ee0b
Merge pull request #820 from docker/fix-secrets-docs
...
Fix secrets docs on mounts
2020-10-26 11:17:01 +01:00
83bdb94cb1
Removing API deprecated fields (unused in VSCode Docker extension) while we are still beta. Keeping field numbering to not break all gRPC calls
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-26 09:57:16 +01:00
f1badf0da8
Fix typo in comments against Event struct definition inside writer.go
...
Signed-off-by: Sarath Kumar Sivan <sarathkumarsivan@gmail.com>
2020-10-25 20:09:18 -07:00
flaviostutz
Guillaume Tardif
aiordache
Gergely Imreh
Guillaume Tardif
Chris Crone
Sarath Kumar Sivan
Ulysses Souza