tyler.durden
/
compose
mirror of https://github.com/docker/compose.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
2,236 Commits 25 Branches 265 Tags 67 MiB
Commit Graph

518 Commits

Author SHA1 Message Date
Chris Crone 25e6a18fef backend: Add --rm support to local backend 
Signed-off-by: Chris Crone <christopher.crone@docker.com>
 2020-10-30 18:19:02 +01:00
aiordache de0be8650e Remove region from contexts and cleanup 
Signed-off-by: aiordache <anca.iordache@docker.com>
 2020-10-30 17:51:16 +01:00
Guillaume Tardif c3cc54316b This new field Named “Type” breaks VSCode extension for some strange reason, lets rename it ContextType 
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
 2020-10-30 13:32:13 +01:00
Guillaume Tardif 7cc3bc3870 No breaking change on `docker context ls —format “{{ json . }}` , this is used by VSCode extension 
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
 2020-10-30 10:37:36 +01:00
Guillaume Tardif b604ba6246 Fix 2 corner cases with PATH settings 
* windows PATH should use windows separator (;)
* do not add separator if initial PATH is empty (was creating PATH=:/path)

Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
 2020-10-29 15:35:22 +01:00
Guillaume Tardif 5e809acd87 Use OS-dependant pathListSeparator, when appending to PATH 
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
 2020-10-29 15:09:38 +01:00
aiordache 53efa312c8 Refactor context create options 
Signed-off-by: aiordache <anca.iordache@docker.com>
 2020-10-29 10:25:23 +01:00
aiordache 2dcd1a5826 refactor ecs context creation 
Signed-off-by: aiordache <anca.iordache@docker.com>
 2020-10-29 10:10:00 +01:00
Guillaume Tardif 02501407de Add update command for backward compatibility 
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
 2020-10-28 14:26:32 +01:00
Ulysses Souza 69083e07e6 Add --rm to run command (as not yet implemented) 
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
 2020-10-27 01:57:35 +01:00
Ulysses Souza 29ba42bbc4 Fix volume create cli bug 
This passes the pointer to the concrete struct instead of a copy

Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
 2020-10-20 19:34:06 +02:00
Nicolas De Loof de96a0c1d0
CLI command to manage ECS volumes 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
 2020-10-20 16:52:50 +02:00
aiordache 8f31ad59be Refactor secrets 
- create secrets from files
  - update Secret structure

Signed-off-by: aiordache <anca.iordache@docker.com>
 2020-10-19 11:33:55 +02:00
Guillaume Tardif 85c94a2f7f Replace `docker run —envFile` with `docker run —env-file` 
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
 2020-10-16 18:03:47 +02:00
Anca Iordache 05295b5e8a
Merge pull request #765 from docker/ecs_default_profile 
Populate ~/.aws/config(credentials) on ecs context create
 2020-10-16 11:33:03 +02:00
aiordache c2af0a136a Populate ~/.aws/config(credentials) on ecs context create 
Signed-off-by: aiordache <anca.iordache@docker.com>
 2020-10-15 20:26:38 +02:00
Guillaume Tardif 50a2ae1100 Display summary of reclaimed ACI resources (CPU/mem) in `docker prune` 
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
 2020-10-15 15:45:48 +02:00
Guillaume Tardif a5e34323e2 Add `docker prune` command and ACI implementation 
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
 2020-10-14 17:48:11 +02:00
Ulysses Souza 660c7bbdcf Add command "volume inspect" 
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
 2020-10-14 11:11:55 +02:00
Ulysses Souza 6c1ea32dae Add --quiet for some commands 
- compose ls
- compose ps
- secret ls // Not implemented on ACI so no e2e-aci tests
- volume ls

Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
 2020-10-12 11:34:27 +02:00
Nicolas De loof a067882b6d
Merge pull request #734 from docker/add-version-in-user-agent 
Add version to UserAgent on  ACI
 2020-10-12 11:11:55 +02:00
Ulysses Souza 10632b008b Add version to UserAgent on ACI 
This also refactors the Version insertion to make it global

Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
 2020-10-12 09:15:32 +02:00
Guillaume Tardif 6516632ecf Add resource reservations to container inspect 
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
 2020-10-08 17:47:16 +02:00
Guillaume Tardif b1edfb6507 Change inspect json output to group things a bit more nicely, and more like Moby json output 
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
 2020-10-08 17:03:30 +02:00
Guillaume Tardif 0d3f7186c5 Hardcoded list of commands and simplified metrics gathering. 
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
 2020-10-08 11:59:12 +02:00
aiordache 265dd197c3 Add detach flag to `compose up` 
Signed-off-by: aiordache <anca.iordache@docker.com>
 2020-10-07 15:51:43 +02:00
Guillaume Tardif a1bb2d5abe Allow `docker context ls —formatter {{json.}}` to not delegate to Moby and include context type in the json 
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
 2020-10-06 18:00:35 +02:00
aiordache c15d05f7f4 refactor task failure detection 
Signed-off-by: aiordache <anca.iordache@docker.com>
 2020-10-05 19:37:13 +02:00
aiordache d3effd2ead Detect task failures 
Signed-off-by: aiordache <anca.iordache@docker.com>
 2020-10-05 16:55:35 +02:00
Guillaume Tardif 144c403e96
Merge pull request #721 from ahlaw/main 
Normalize case of command and flag help
 2020-10-05 11:45:47 +02:00
Guillaume Tardif 97576db803
Merge pull request #689 from ulyssessouza/json-out 
Add json output format to several commands
 2020-10-05 10:30:30 +02:00
Amos Law e10424e316 Normalize case of command and flag help 
Signed-off-by: Amos Law <ahlaw.dev@gmail.com>
 2020-10-03 20:43:18 -04:00
Ulysses Souza 344db70274 Fix version command on bypassing to moby cli 
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
 2020-10-02 19:04:43 +02:00
Ulysses Souza 74e86ab06a Fix HTML escape encoding 
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
 2020-10-02 18:53:22 +02:00
Guillaume Tardif 6d0f7f399f Fix regression: let users login to local registry (no '.' In registry name) 
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
 2020-10-02 13:54:59 +02:00
Ulysses Souza 83f21b9293 Remove unused files 
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
 2020-10-01 15:41:18 +02:00
Ulysses Souza b8a1e6c888 Change JSON output to individual lines 
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
 2020-10-01 15:41:18 +02:00
Ulysses Souza 3e9095a873 Fix docker context ls for retrocompatibility 
It writes each context as an independent object line

Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
 2020-10-01 15:41:18 +02:00
Ulysses Souza 6c883dc4a5 Print only the information present in pretty on json 
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
 2020-10-01 15:41:18 +02:00
Ulysses Souza 604cf0c911 Add comment on legacy --json option 
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
 2020-10-01 15:41:18 +02:00
Ulysses Souza 044e7f571d Remove go template from help on list commands 
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
 2020-10-01 15:41:18 +02:00
Ulysses Souza fb59c9385d Fix tests 
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
 2020-10-01 15:41:18 +02:00
Ulysses Souza 0f6f547214 Refactor Print method for lists 
This also fixes in the case of nil list

Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
 2020-10-01 15:41:18 +02:00
Ulysses Souza 8961805412 Add json output format to several commands 
- docker context ls
- docker ps
- docker compose ls
- docker compose ps
- docker secret ls
- docker volume ls
- docker version

Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
 2020-10-01 15:41:18 +02:00
Guillaume Tardif abd6af6386
Merge pull request #704 from ulyssessouza/add-envFile 
Add envFile arguments to run command
 2020-10-01 13:55:24 +02:00
Guillaume Tardif 0ac5ce6a76
Merge pull request #702 from gtardif/run-args 
Add argument support to run command
 2020-10-01 11:22:03 +02:00
Ulysses Souza 2e899202ec Add envFile arguments to run command 
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
 2020-10-01 06:19:08 +02:00
Ulysses Souza 277702dc6b Add argument support to run command 
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
 2020-09-30 15:34:22 +02:00
Guillaume Tardif b8968e83cd Do not fail when constructing error message for commands not implemented. Use metrics GetCommand() the is already used 3 lines above for metrics tracking. 
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
 2020-09-30 10:49:14 +02:00
Guillaume Tardif b9d6c2e701 Add volume as a new served API, use `one of` in proto for context specific parameters, proxy volume creation 
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
 2020-09-28 14:56:32 +02:00
Chris Crone 7b169744a2 cli: Sort main imports 
Signed-off-by: Chris Crone <christopher.crone@docker.com>
 2020-09-25 14:28:26 +02:00
Guillaume Tardif ca35ccfb0e ACI Volumes : create takes one required arg, instead of required flag `--fileshare` (we still have required flag `--storage-account` specifically for ACI) 
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
 2020-09-24 17:10:32 +02:00
Guillaume Tardif 8302266212 In metrics, send context type, not context name (metrics for Moby calls) 
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
 2020-09-23 16:12:09 +02:00
Guillaume Tardif cf3bb18c0e User compose.service.domainname rather than custom ACI extension for ACI DNSLabelName 
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
 2020-09-22 14:44:22 +02:00
Guillaume Tardif 334ebf5f75 Implement --domainname flag on compose up, also defining compose extension "x-aci-domain-name" to store ACI DNSLabelName. 
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
 2020-09-22 14:41:31 +02:00
Guillaume Tardif 268c02523a Only add `--domainname` flag to `docker run` in ACI context 
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
 2020-09-22 14:41:31 +02:00
Guillaume Tardif 701d1b834e ACI: allow users to set DNSLabelName and deploy containers with fqdn like `myapp.eastus.azurecontainers.io` 
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
 2020-09-22 14:41:31 +02:00
Guillaume Tardif f42e05fcc3
Merge pull request #636 from docker/update-copyright 
Update copyright
 2020-09-22 12:21:16 +02:00
Guillaume Tardif 772493d70d
Merge pull request #617 from ulyssessouza/volumes_ro 
Add 'readOnly' capability to volumes on ACI
 2020-09-22 12:14:31 +02:00
Chris Crone d154c41586 Update copyright 
Signed-off-by: Chris Crone <christopher.crone@docker.com>
 2020-09-22 12:13:00 +02:00
Guillaume Tardif a71b2a39bd Add status field in API metrics 
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
 2020-09-18 15:22:34 +02:00
Ulysses Souza 02d59ae510 Add 'readOnly' capability to volumes on ACI 
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
 2020-09-18 12:07:42 +02:00
Guillaume Tardif 3ccc603461 Add status field in CLI metrics : success, failure, cancelled 
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
 2020-09-18 10:47:50 +02:00
Guillaume Tardif 10372b7098
Merge pull request #625 from docker/aci_context_create_no_sub 
Check specified subscription in context create and if not found, prompt users they might need to login with -—tenant-id.
 2020-09-17 22:29:06 +02:00
Guillaume Tardif 292ec55f46 Check specified subscription in context create and if not found, prompt users they might need to login with -—tenant-id. 
Cf https://github.com/docker/aci-integration-beta/issues/27

Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
 2020-09-17 22:05:43 +02:00
Guillaume Tardif 9c6aead797 Allow running commands with HOME=“”. 
Do not try to create ~/.docker before using CONFIG_DIR. HOME=“” will result in trying to use a relative .docker folder as default config folder, and if we cannot create the context store for any reason, try delegate to Moby CLI.

Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
 2020-09-17 09:08:17 +02:00
Nicolas De loof 6d35a6d644
Merge pull request #609 from docker/refacto_multi_error_format 
Remove duplicated code formatting multi errors
 2020-09-15 18:14:45 +02:00
Guillaume Tardif 267b267201 Progress functions can return a string, that can be used in the caller of progress.Run to display final result after progress display 
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
 2020-09-14 14:29:03 +02:00
Guillaume Tardif 2ce4e98d88 In version, replace “Azure integration” version info by “Cloud integration” 
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
 2020-09-11 17:29:40 +02:00
Guillaume Tardif b85eddd09c Remove duplicated code formatting multi errors 
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
 2020-09-11 16:08:14 +02:00
Guillaume Tardif 57ded74aee
Merge pull request #598 from docker/encode_env_values 
Properly send env variables containing “=“ in their value in ACI payload. Also properly send quoted values
 2020-09-10 17:17:02 +02:00
Guillaume Tardif 98f0064fe9 Properly send env variables containing “=“ in their value in ACI payload. Also properly send quoted values 
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
 2020-09-10 17:03:34 +02:00
Guillaume Tardif 0b3fdb637d Change volume IDs from “storageaccount@fileshare“ to “storageaccount/fileshare” 
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
 2020-09-10 16:07:22 +02:00
Guillaume Tardif 07547d7b87 ACI Volume create flags are required 
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
 2020-09-10 15:24:51 +02:00
Guillaume Tardif 099b64935b Minor fixes 
Co-authored-by: Chris Crone <christopher.crone@docker.com>

Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
 2020-09-10 14:55:46 +02:00
Guillaume Tardif 80d23a6097 Removed NAME from `volume ls` output, allow `volume delete <ID>` using IDs from `volume ls`. 
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
 2020-09-10 09:14:39 +02:00
Guillaume Tardif 38a8f5310b Volume command is only available in aci context type, with ACI specific flags 
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
 2020-09-10 09:14:39 +02:00
Guillaume Tardif b96a6d1086 Add progress on volume creation 
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
 2020-09-08 17:54:45 +02:00
Guillaume Tardif 96d785a5bd Added volume delete, can delete juste a file share or the storage account if confirmed 
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
 2020-09-08 16:32:16 +02:00
Guillaume Tardif dcbc1c3fb2 Volume cli minor refactor 
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
 2020-09-08 15:30:50 +02:00
Guillaume Tardif 08562b403e Connecting it all 
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
 2020-09-08 15:30:50 +02:00
Guillaume Tardif 9ed06ece5b Adding volume API & initial CLI command 
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
 2020-09-08 15:30:50 +02:00
Guillaume Tardif 64a28f6636 Also move client => api/client 
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
 2020-09-07 13:23:06 +02:00
Guillaume Tardif d06aa2827f Move containers, compose, secrets to /api 
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
 2020-09-07 13:22:08 +02:00
Guillaume Tardif f24f02bbbb
Merge pull request #581 from docker/remove_delete_alias 
Remove delete alias, no reason to add this (does not exist in Moby)
 2020-09-04 15:47:27 +02:00
Nicolas De loof a8c290fe98
Merge pull request #583 from docker/compose_ls 2020-09-04 14:13:27 +02:00
Guillaume Tardif 1a41d0a90b Remove delete alias, no reason to add this (does not exist in Moby) 
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
 2020-09-04 13:22:28 +02:00
aiordache 02be463fd7 Add `compose ls` command for ECS 
Signed-off-by: aiordache <anca.iordache@docker.com>
 2020-09-04 13:20:11 +02:00
Guillaume Tardif 303958bb44
Merge pull request #574 from ulyssessouza/alias-rm-kill 
Add 'kill' as an alias to 'stop'
 2020-09-04 13:07:38 +02:00
Guillaume Tardif adeba9b124 Fix bug not allowing users to run any context command when set to an aws context type. 
When users have an “aws" context type, we try to exec the command (will execute context ls, context use, etc.) and when it fails because it doesn’t find the aws backend, then display the custom error for aws context type.

Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
 2020-09-04 11:01:55 +02:00
Ulysses Souza 15066ce999 Add 'kill' command 
- On ACI that's implemented as a stop,
since ACI does not implement a kill

Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
 2020-09-04 02:57:54 +02:00
Guillaume Tardif c7e2db077e
Merge pull request #544 from docker/simulation 
Introduce ECS emulation mode
 2020-09-01 15:18:32 +02:00
Nicolas De Loof fed50d79f2
introduce ecs-local context 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
 2020-08-31 15:30:05 +02:00
Nicolas De Loof 7f8bb030e6
Introduce ECS emulation mode 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
 2020-08-31 10:01:52 +02:00
Guillaume Tardif b0c50ed6dd Implement compose ps on ACI 
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
 2020-08-28 17:43:18 +02:00
Guillaume Tardif f80e90caca
Merge pull request #529 from docker/api 
Revisit compose API so it uses compose-go Project as parameter
 2020-08-27 11:52:27 +02:00
Nicolas De Loof edb30e7e82
Revisit compose API so it uses compose-go Project as parameter 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
 2020-08-27 10:59:20 +02:00
Guillaume Tardif ed395a1e64 Display nice message on context creation (message taken from Moby cli) 
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
 2020-08-26 18:09:01 +02:00
Guillaume Tardif ad5c465bd1
Merge pull request #485 from docker/repo-rename 
Rename docker/api -> docker/compose-cli
 2020-08-25 15:58:51 +02:00
Ulysses Souza 59f7d7cd00 Redirect user from plugin usage to integrated ECS 
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
 2020-08-24 19:29:10 +02:00
Chris Crone 4c6280b0e9 Rename docker/api -> docker/compose-cli 
Signed-off-by: Chris Crone <christopher.crone@docker.com>
 2020-08-21 17:28:39 +02:00
Guillaume Tardif 69ce33321f
Merge pull request #528 from docker/secrets 
Secrets
 2020-08-21 14:52:36 +02:00
Guillaume Tardif 4c3b563182 ECS context type is not for delegation to Moby ! 
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
 2020-08-21 14:32:46 +02:00
Nicolas De Loof 32adf3e4e6
Introduce `secret` management command and ECS implementation 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
 2020-08-21 13:56:52 +02:00
Guillaume Tardif bff1fa1872
Merge pull request #525 from docker/workingdir 
workdir default value is defined by compose file
 2020-08-21 10:22:31 +02:00
Nicolas De Loof 838937c907
workdir default value is defined by compose file 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
 2020-08-20 15:18:03 +02:00
Djordje Lukic 635ecd7b99 Return a default implementation when nil 
Some backends can decide not to implement a whole set of APIs (compose
for example), we now return a default implementation that returns a
`errdefs.ErrNotImplemented` for each action making it easy for the cli
to print a helpful error message. We also remove any possible nil
panics.

Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
 2020-08-20 14:32:03 +02:00
Guillaume Tardif 2df4112913
Merge pull request #511 from docker/ecs-e2e 
First ECS E2E test
 2020-08-20 10:57:23 +02:00
Guillaume Tardif 9b0b1129a6 Build without ecs build flag, not required anymore. Fix context create ecs command not build 
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
 2020-08-20 10:11:23 +02:00
aiordache 6657dd2774 Add error message for aws context 
Signed-off-by: aiordache <anca.iordache@docker.com>
 2020-08-19 18:22:07 +02:00
aiordache 44b2b8b21d integrate functionality from ecs-plugin 
Signed-off-by: aiordache <anca.iordache@docker.com>
 2020-08-19 17:49:21 +02:00
aiordache fe0cc0d2cc Add progress.Run to down cmd 
Signed-off-by: aiordache <anca.iordache@docker.com>
 2020-08-19 16:19:21 +02:00
Nicolas De Loof ec4615ae57
Apply linter recommendations 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
 2020-08-19 08:16:19 +02:00
Nicolas De Loof 2791542fea
Merge remote-tracking branch 'origin/main' into ecs 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
 2020-08-18 10:36:17 +02:00
Nicolas De Loof cfbd963c3d
Adjust commands to latest compose-go 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
 2020-08-18 10:01:32 +02:00
Nicolas De Loof e02d8d549b
Make ECS integration a compose-cli backend 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
 2020-08-17 21:30:49 +02:00
Guillaume Lours 95de770e87 Update or add license header which are not valid 
Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>
 2020-08-17 16:55:25 +02:00
Guillaume Tardif b060d8acfc Do not display warning if cannot forward signal to child. See https://github.com/docker/pinata/pull/14327 2020-08-13 14:06:52 +02:00
Djordje Lukic 88c405e025 Use buffered channels for signals 2020-08-13 10:34:42 +02:00
Djordje Lukic aa8bf1daaa Add test for ACI start 2020-08-12 14:50:47 +02:00
Djordje Lukic 1a3182fb7f Implement `docker start` for ACI 2020-08-12 14:50:47 +02:00
Guillaume Tardif ee062e8333 ACI Stop implementation 2020-08-12 10:32:35 +02:00
Djordje Lukic 611667d252 Fix linting 2020-08-11 17:36:54 +02:00
Sebastiaan van Stijn c862d7821d
Remove custom multierrors package 
The hashicorp/go-multierror package provides functionality to do
this. Replacing the custom package in favor of those (at the cost
of some small duplication).

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2020-08-11 17:24:51 +02:00
Djordje Lukic 80c1b2246b
Merge pull request #457 from docker/feat-aci-force-rm 
Add --force to rm on ACI
 2020-08-11 16:42:49 +02:00
Djordje Lukic 093a69136f Add --force to rm on ACI 
If a container is running the user must force the removal of the
container.
 2020-08-11 16:30:42 +02:00
Guillaume Tardif 6ff20cf104
more concise validation 
Co-authored-by: Djordje Lukic <djordje.lukic@docker.com>
 2020-08-11 13:45:46 +02:00
Guillaume Tardif ec5f4e9202 Add options to `docker login azure` to support Service Principal login. Use it in E2E tests 2020-08-11 12:11:51 +02:00
aiordache 00f17534a3 error check 
Signed-off-by: aiordache <anca.iordache@docker.com>
 2020-08-06 18:13:17 +02:00
aiordache 64c517f375 remove unused parameter 
Signed-off-by: aiordache <anca.iordache@docker.com>
 2020-08-06 18:13:17 +02:00
aiordache 46e58a28d0 Add ps and logs to compose API 
Signed-off-by: aiordache <anca.iordache@docker.com>
 2020-08-06 18:13:17 +02:00
Anca Iordache 4c3c219518
Merge pull request #411 from docker/enable_ecs 
Enable ecs backend
 2020-08-06 12:17:00 +02:00
aiordache 42a5dfc0d2 rename runCompose() to checkComposeSupport() 
Signed-off-by: aiordache <anca.iordache@docker.com>
 2020-08-06 12:02:11 +02:00
aiordache bb3500d77b check with client if context is supported (has a backend) 
Signed-off-by: aiordache <anca.iordache@docker.com>
 2020-08-06 11:49:54 +02:00
Guillaume Tardif cdd4028788 Fix flaky nil pointer in signal forwarding to child process (see https://github.com/docker/api/runs/949400778) 2020-08-06 10:23:12 +02:00
Guillaume Tardif 29fe26620a Stop forwarding signals to child process when the child terminates 2020-08-05 15:05:32 +02:00
Guillaume Tardif 05a8582126 Forward all signals to child process 2020-08-05 15:05:32 +02:00
aiordache d1b8bcb2c7 fix signal passing to mobycli 
Signed-off-by: aiordache <anca.iordache@docker.com>
 2020-08-05 15:05:32 +02:00
Guillaume Tardif f442eafe0b Validate run restart option value. Default value is “none”, instead of “no”, this is more in line with compose values, and changes only the default so should not have too much impact on legacy usage. 2020-08-04 17:11:21 +02:00
Ulysses Souza a2c2d6aa5d Add Restart Policy support when running single container 2020-08-04 16:57:58 +02:00
Chris Crone 0e92fd21d0 cli.options: Do not test port list order 
Signed-off-by: Chris Crone <christopher.crone@docker.com>
 2020-08-04 16:31:02 +02:00
Chris Crone f8ce7a4780 cli: Move to gotest.tools 
Signed-off-by: Chris Crone <christopher.crone@docker.com>
 2020-08-04 14:03:24 +02:00
aiordache 5f7c284d58 update delegation test to check all context types 
Signed-off-by: aiordache <anca.iordache@docker.com>
 2020-07-30 11:40:44 +02:00
aiordache 87245ef727 rename packages ( amazon to ecs and azure to aci ) 
Signed-off-by: aiordache <anca.iordache@docker.com>
 2020-07-30 11:34:34 +02:00
aiordache 2471e51b39 set build tag for the ecs context and backend 
Signed-off-by: aiordache <anca.iordache@docker.com>
 2020-07-30 11:34:34 +02:00
aiordache cfa7406d73 fix tests 
Signed-off-by: aiordache <anca.iordache@docker.com>
 2020-07-30 11:34:34 +02:00
aiordache fb63373a9b remove cluster property from aws context 
Signed-off-by: aiordache <anca.iordache@docker.com>
 2020-07-30 11:34:34 +02:00
aiordache 355295696f Create aws context 
Signed-off-by: aiordache <anca.iordache@docker.com>
 2020-07-30 11:34:34 +02:00
aiordache 648f0139df add e2e test for compose up on default context 
Signed-off-by: aiordache <anca.iordache@docker.com>
 2020-07-29 17:33:23 +02:00
aiordache 5a26b25709 handle compose on all context types 
Signed-off-by: aiordache <anca.iordache@docker.com>
 2020-07-29 11:58:09 +02:00
aiordache cfd6d2f5d1 Error out for contexts not implementing compose command 
Signed-off-by: aiordache <anca.iordache@docker.com>
 2020-07-28 16:30:08 +02:00
Christopher Crone d1a929eb7f cli: Fix logout when specifying a registry 
Signed-off-by: Christopher Crone <christopher.crone@docker.com>
 2020-07-17 16:29:12 +02:00
Christopher Crone af0417c758 cli: Refactor Azure logout 
Signed-off-by: Christopher Crone <christopher.crone@docker.com>
 2020-07-17 16:23:15 +02:00
Djordje Lukic 84dbd1467d Move the struct for creating and aci context to azure package 2020-07-13 11:05:19 +02:00
Guillaume Tardif 43b54ef75a Also remove map[string]string for azure login (tenantId param) 2020-07-10 16:55:44 +02:00
Guillaume Tardif 97d408d25d Replaced map[string] string by existing aciCreateOpts struct for context create 2020-07-10 16:39:09 +02:00
Guillaume Tardif c36b64c10b Fixing subscription-id parameter not passed to backend... 2020-07-10 15:27:41 +02:00
Guillaume Tardif 1fbdbbbbe3
Merge pull request #381 from docker/fix-logs-windows 
Get the real width of the terminal
 2020-07-10 13:06:07 +02:00
Guillaume Tardif 52c2d09eae
Merge pull request #376 from docker/logout 
Implement azure logout
 2020-07-10 09:48:39 +02:00
Djordje Lukic ef2d304762 Allow non-interactive exec on ACI 
If the request is for a non-interactive exec we don't attach the stdin
when executing.
 2020-07-09 11:47:22 +02:00
Djordje Lukic e6c115dc17 Get the real width of the terminal 
github.com/buger/goterm always returns 80 on windows...
 2020-07-09 10:50:48 +02:00
Guillaume Tardif 492ce96dd4 Implement azure logout 2020-07-08 17:48:10 +02:00
Guillaume Tardif c5cd0f44f8 Fix ACI e2e tests : do not use console if no tty option set in exec 2020-07-07 14:05:25 +02:00
Guillaume Tardif cb3ac513cc Add run env variables support (KEY=AVLUE or KEY, will grab the process env value). 
No support yet for env files
 2020-07-07 11:39:35 +02:00
Guillaume Tardif efea5c8c83
Merge pull request #352 from docker/fix_error_cancel_logs 
Exit without error message if user canceled command
 2020-07-07 11:27:33 +02:00
Guillaume Tardif 0776e79e8e Exit without error message if user canceled command (typical scenario : ACI `logs — follow` and ctrl-C while querying ACI) 2020-07-06 17:28:02 +02:00
Guillaume Tardif 7296290408 Add ”Platform” in docker inspect result, showing container OS (this field is used by VSCode) 2020-07-06 12:16:02 +02:00
Guillaume Tardif ae76e0cf27
Merge pull request #325 from docker/error_status_context_needs_login 
Specific exit code when command fails because azure login is required
 2020-07-02 17:02:57 +02:00
Guillaume Tardif 4a1b50a9cd
Merge pull request #326 from docker/run_follow_logs 
Run containers and attach to logs by default, detach with -d option
 2020-07-02 17:02:33 +02:00
Guillaume Tardif 5eea111ecf Run containers and attach to logs by default, detach with -d option 2020-07-02 16:45:04 +02:00
Guillaume Tardif 3c83e01e9c
Merge pull request #327 from docker/compose-go 
Use compose-go's Project and ProjectOptions
 2020-07-02 16:43:34 +02:00
Nicolas De Loof 622402709a
Use compose-go's Project and ProjectOptions 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
 2020-07-02 16:05:45 +02:00
Guillaume Tardif 964e331a10 Specific exit code when command fails because azure login is required. Will be used by VSCode Docker integration 2020-07-02 13:52:57 +02:00
Djordje Lukic e4354c82d1 Make sure we can have a console 2020-07-02 11:49:39 +02:00
Djordje Lukic 8e8c868a70
Merge pull request #322 from docker/fix_attach_logs 
Fix logs replacement when streaming logs on windows
 2020-07-02 10:37:27 +02:00
Guillaume Tardif 736b7a4707 Fix logs replacement when streaming logs on windows 2020-07-02 10:17:55 +02:00
Guillaume Tardif bba9e055af Allow users to specify tenanted when logging into azure (if several tenants for azure account) 2020-07-01 12:27:18 +02:00
Guillaume Tardif f0ab42e109
Merge pull request #300 from docker/aci_ci 
Run ACI e2e tests in the CI with basic support for service principal login
 2020-06-30 10:29:13 +02:00
Guillaume Tardif 88ccad0449
Merge pull request #297 from docker/aci_exec_it 
Let -it go through for aci exec, same as -t flag for the moment.
 2020-06-30 09:45:34 +02:00
Guillaume Tardif eda438aaed Added basic support for service principal login, run ACI e2e tests with it 2020-06-29 20:35:23 +02:00
Guillaume Tardif d71ae04936 Let -it flag go through for aci exec, same as -t for the moment. 
Will need to check how we can implement -I specifically on ACI
 2020-06-29 10:50:04 +02:00
Ulysses Souza 1deb2b8b09 Integrate limits on inspect 
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
 2020-06-29 10:32:28 +02:00
Ulysses Souza 0a57fd7d5c Add cpu and memory limits 
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
 2020-06-29 10:28:43 +02:00
Djordje Lukic d5b674fba9
Merge pull request #291 from docker/chore-cleanup 
Cleanup entrypoint
 2020-06-26 17:21:39 +02:00
Guillaume Tardif d97f9d68fd Add missing f shorthand for version command 2020-06-26 12:35:51 +02:00
Djordje Lukic 98976e4cb4 Cleanup entrypoint 
* use the `fatal` function when we can
* rename moby.ExecRegardlessContext to Exec
 2020-06-26 10:23:37 +02:00
Guillaume Tardif 4fb039164d
Merge pull request #289 from gtardif/automate_version_from_tag 
Automate version from tag
 2020-06-25 15:58:00 +02:00
Guillaume Tardif 0bcba8d1d2 Set LD_FLAG version from git tag. Displayed version will be (default behaviour of git describe —tags): 
* release version : if tag `v0.1.2` is exactly on the built commit : `0.1.2` (strip v when displaying `docker version`)
* dev version : if tag `v0.1.2` is 3 commits before, and we are on commit `xyz` : `0.1.2-3-xyz` 
* will only match tags starting with `v[0-9]`
 2020-06-25 13:50:16 +02:00
Djordje Lukic 908212a947 Add version in the main package 
This way, when we release goreleaser will inject the right version in
the ldflags
 2020-06-25 12:00:37 +02:00
Guillaume Tardif 839b1b0b44 Delegate to Moby CLI, to allow executing ecs CLI plugin if user has switched to the AWS context (created by the plugin) 2020-06-25 11:49:28 +02:00
Guillaume Tardif 0d75d58089 Bump version 0.1.4 2020-06-24 11:38:34 +02:00
Guillaume Tardif bf76fe2f32 Bump version to 0.1.3 2020-06-23 17:05:07 +02:00
Djordje Lukic 0c1f0f81df Usage metrics 
Send usage to Docker Desktop
 2020-06-23 16:52:52 +02:00
Guillaume Tardif e24f2a36c2
Merge pull request #269 from docker/aci_detach_flags 
Add ACI detach flags
 2020-06-23 16:43:42 +02:00
Guillaume Tardif 90914603ba Add ACI detach flags, not used at the moment, but more makes new command more compatible with previous ones. 2020-06-23 16:17:02 +02:00
Guillaume Tardif fa8b911cd8 Allow running `docker -v` or `--version` even if context is not default 2020-06-23 15:13:43 +02:00
Guillaume Tardif 4197ef8b68
Merge pull request #263 from docker/fix_host_flag 
Shell out to Moby cli if user uses -H, regardless of context set.
 2020-06-23 14:57:54 +02:00
Guillaume Tardif ab39310771 Allow --format on docker context ls. Fixing VS Code extension shellout 2020-06-23 13:25:43 +02:00
Guillaume Tardif 38d4f8d25a Shell out to Moby cli if user uses -H, regardless of context set. Moby cli will refuse both options (context & host) to be set at the same time 2020-06-23 12:00:46 +02:00
Guillaume Tardif 03f11e2953
Merge pull request #247 from docker/main_command_cleanup 
Main command cleanup
 2020-06-23 10:35:07 +02:00