Starting with Docker 20.10, the docker daemon has support for
"dual logging", which allows reading back logs, irregardless of
the logging-driver that is configured (except for "none" as logging
driver).
This patch removes the local check, which used a hard-coded list of
logging drivers that are expected to support reading logs.
When using an older version of Docker, the API should return an
error that reading logs is not supported, so no local check should
be needed.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This allows us to revert from Debian Buster to Stretch which allows
us to relax the glibc version requirements.
Signed-off-by: Chris Crone <christopher.crone@docker.com>
* Move global console_handler into function scope
Signed-off-by: Mike Seplowitz <mseplowitz@bloomberg.net>
* Improve control over ANSI output
- Disabled parallel logger ANSI output if not attached to a tty.
The console handler and progress stream already checked whether the
output stream is a tty, but ParallelStreamWriter did not.
- Added --ansi=(never|always|auto) option to allow clearer control over
ANSI output. Since --no-ansi is the same as --ansi=never, --no-ansi is
now deprecated.
Signed-off-by: Mike Seplowitz <mseplowitz@bloomberg.net>
The `docker` command accepts duplicate values, so there is no benefit to
performing this check.
Fixes#7342.
Signed-off-by: Mark Gallagher <mark@fts.scot>
This changes compose to use "native" build through the CLI
by default. With this, docker-compose can take advantage of
BuildKit (which is now enabled by default on Docker Desktop
2.5 and up).
Users that want to use the python client for building can
opt-out of this feature by setting COMPOSE_DOCKER_CLI_BUILD=0
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
When 'up' is run with explicit list of services, compose will
start them together with their dependencies. It will attach to all
started services, but won't read output from dependencies (their
logs are not printed by 'up') - so the receive buffer of
dependencies will fill and at some point will start blocking those
services. Fix that by only attaching to services given in the
list.
To do that, move logic of choosing which services to attach from
cli/main.py to utils.py and use it from project.py to decide if
service should be attached.
Fixes#6018
Signed-off-by: Daniil Sigalov <asterite@seclab.cs.msu.ru>
This allows us to revert from Debian Buster to Stretch which allows
us to relax the glibc version requirements.
Signed-off-by: Chris Crone <christopher.crone@docker.com>
* Move global console_handler into function scope
Signed-off-by: Mike Seplowitz <mseplowitz@bloomberg.net>
* Improve control over ANSI output
- Disabled parallel logger ANSI output if not attached to a tty.
The console handler and progress stream already checked whether the
output stream is a tty, but ParallelStreamWriter did not.
- Added --ansi=(never|always|auto) option to allow clearer control over
ANSI output. Since --no-ansi is the same as --ansi=never, --no-ansi is
now deprecated.
Signed-off-by: Mike Seplowitz <mseplowitz@bloomberg.net>
When 'up' is run with explicit list of services, compose will
start them together with their dependencies. It will attach to all
started services, but won't read output from dependencies (their
logs are not printed by 'up') - so the receive buffer of
dependencies will fill and at some point will start blocking those
services. Fix that by only attaching to services given in the
list.
To do that, move logic of choosing which services to attach from
cli/main.py to utils.py and use it from project.py to decide if
service should be attached.
Fixes#6018
Signed-off-by: Daniil Sigalov <asterite@seclab.cs.msu.ru>
