Djordje Lukic
e604e7efc9
Merge pull request #181 from rumpl/fix-logs
...
Use stdcopy if the container doesn't have a tty
2020-06-08 00:34:05 -07:00
Guillaume Tardif
4700364667
Merge pull request #180 from docker/unknown_comand_error
...
Display friendly message if unknown command is available in default context
2020-06-08 09:25:18 +02:00
Djordje Lukic
31a0716c87
Use stdcopy if the container doesn't have a tty
2020-06-08 08:46:30 +02:00
Djordje Lukic
e81c7ae8e3
Merge pull request #185 from docker/dependabot/go_modules/github.com/Azure/azure-sdk-for-go-42.3.0incompatible
...
Bump github.com/Azure/azure-sdk-for-go from 42.0.0+incompatible to 42.3.0+incompatible
2020-06-06 15:13:44 -07:00
dependabot-preview[bot]
b6f8d9cd80
Bump github.com/Azure/azure-sdk-for-go
...
Bumps [github.com/Azure/azure-sdk-for-go](https://github.com/Azure/azure-sdk-for-go ) from 42.0.0+incompatible to 42.3.0+incompatible.
- [Release notes](https://github.com/Azure/azure-sdk-for-go/releases )
- [Changelog](https://github.com/Azure/azure-sdk-for-go/blob/master/CHANGELOG.md )
- [Commits](https://github.com/Azure/azure-sdk-for-go/compare/v42.0.0...v42.3.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-06-06 21:49:23 +00:00
Djordje Lukic
4cc89f577d
Merge pull request #183 from docker/dependabot/go_modules/google.golang.org/protobuf-1.24.0
...
Bump google.golang.org/protobuf from 1.22.0 to 1.24.0
2020-06-06 14:44:22 -07:00
dependabot-preview[bot]
5951db58c1
Bump google.golang.org/protobuf from 1.22.0 to 1.24.0
...
Bumps [google.golang.org/protobuf](https://github.com/protocolbuffers/protobuf-go ) from 1.22.0 to 1.24.0.
- [Release notes](https://github.com/protocolbuffers/protobuf-go/releases )
- [Changelog](https://github.com/protocolbuffers/protobuf-go/blob/master/release.bash )
- [Commits](https://github.com/protocolbuffers/protobuf-go/compare/v1.22.0...v1.24.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-06-06 21:41:25 +00:00
Djordje Lukic
bd198c741e
Merge pull request #186 from docker/dependabot/go_modules/github.com/golang/protobuf-1.4.2
...
Bump github.com/golang/protobuf from 1.4.1 to 1.4.2
2020-06-06 14:38:02 -07:00
Djordje Lukic
c57cc28f29
Merge pull request #187 from docker/dependabot/go_modules/github.com/opencontainers/go-digest-1.0.0
...
Bump github.com/opencontainers/go-digest from 1.0.0-rc1 to 1.0.0
2020-06-06 14:37:49 -07:00
Djordje Lukic
a1d3ba398a
Merge pull request #184 from docker/dependabot/go_modules/github.com/Azure/go-autorest/autorest-0.10.2
...
Bump github.com/Azure/go-autorest/autorest from 0.10.0 to 0.10.2
2020-06-06 14:37:34 -07:00
dependabot-preview[bot]
5bb15bbf58
Bump github.com/opencontainers/go-digest from 1.0.0-rc1 to 1.0.0
...
Bumps [github.com/opencontainers/go-digest](https://github.com/opencontainers/go-digest ) from 1.0.0-rc1 to 1.0.0.
- [Release notes](https://github.com/opencontainers/go-digest/releases )
- [Commits](https://github.com/opencontainers/go-digest/compare/v1.0.0-rc1...v1.0.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-06-06 21:23:14 +00:00
dependabot-preview[bot]
cd711e5f6b
Bump github.com/golang/protobuf from 1.4.1 to 1.4.2
...
Bumps [github.com/golang/protobuf](https://github.com/golang/protobuf ) from 1.4.1 to 1.4.2.
- [Release notes](https://github.com/golang/protobuf/releases )
- [Commits](https://github.com/golang/protobuf/compare/v1.4.1...v1.4.2 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-06-06 21:22:53 +00:00
dependabot-preview[bot]
3774557392
Bump github.com/Azure/go-autorest/autorest from 0.10.0 to 0.10.2
...
Bumps [github.com/Azure/go-autorest/autorest](https://github.com/Azure/go-autorest ) from 0.10.0 to 0.10.2.
- [Release notes](https://github.com/Azure/go-autorest/releases )
- [Changelog](https://github.com/Azure/go-autorest/blob/master/CHANGELOG.md )
- [Commits](https://github.com/Azure/go-autorest/compare/autorest/v0.10.0...autorest/v0.10.2 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-06-06 21:21:36 +00:00
Guillaume Tardif
f939dd4d47
Display friendly message if unknown command is available in default context
2020-06-05 18:24:08 +02:00
Guillaume Tardif
54141a9bdd
Do not display exit status when classic cli exit in error
2020-06-05 18:17:18 +02:00
Djordje Lukic
e84b508e80
Merge pull request #171 from docker/windows_kill_child_processes
...
Windows : kill child processes
2020-06-05 00:42:21 -07:00
guillaume.tardif
995d047608
Windows specific : ensure all child processes are killed when parent exits (also works when killing parent). From Desktop code
2020-06-04 17:58:24 +02:00
guillaume.tardif
7c6b04f28e
make e2e TestKillChildOnCancel exec properly on windows
2020-06-04 17:58:24 +02:00
Guillaume Tardif
b91eab0544
Merge pull request #170 from docker/context_create_check
...
Do not allow context creation for unknown types
2020-06-04 16:51:11 +02:00
Guillaume Tardif
4a4b62ded2
Do not allow context creation for unknown types
2020-06-04 16:44:08 +02:00
Guillaume Tardif
e77513c1c8
Merge pull request #165 from docker/azure_private_images
...
Allow pulling private images from hub or other registries
2020-06-04 15:43:42 +02:00
Guillaume Tardif
427527d197
Merge pull request #146 from docker/chore-refactor-azure-login
...
Refactor Azure login local server
2020-06-04 10:39:30 +02:00
Christopher Crone
e5335adedd
Azure: Refactor login errors
...
Signed-off-by: Christopher Crone <christopher.crone@docker.com>
2020-06-04 10:20:39 +02:00
Guillaume Tardif
c37f666c07
Merge pull request #164 from docker/interactive_context_create
...
Interactive context create
2020-06-03 18:06:41 +02:00
Christopher Crone
35789ace12
Azure: Refactor creation of login server
...
Signed-off-by: Christopher Crone <christopher.crone@docker.com>
2020-06-03 17:10:54 +02:00
Djordje Lukic
dae54a3c1f
Merge pull request #166 from docker/grpc_container_errfix
...
Fix slight bug in error handling
2020-06-03 04:12:47 -07:00
Guillaume Tardif
1c94893d2f
Fix slight bug in error handling
2020-06-03 12:20:49 +02:00
Guillaume Tardif
39140c8ea0
Refactoring, add unit test or various interactive context creation
2020-06-03 12:05:58 +02:00
Guillaume Tardif
774bfea341
Refactoring, add unit test or various interactive context creation
2020-06-03 10:55:55 +02:00
Guillaume Tardif
5675763856
Interactive context create, adding method CreateContextData to CloudService interface, so Cloud Backends can provide a custom context creation method.
2020-06-02 16:04:08 +02:00
Guillaume Tardif
11f1c057dc
Allow pulling private images from hub or other registries, as long as the user is logged in against the registry(ies).
...
Registry creds are passed along with the ACI payload (cf https://docs.microsoft.com/en-us/azure/container-registry/container-registry-auth-aci ).
Manually tested against hub & ACR private repo
2020-06-02 15:56:24 +02:00
Chris Crone
21b6a2ae71
Merge pull request #160 from chris-crone/dockerfile-improvements
...
Dockerfile improvements
2020-06-02 12:15:43 +02:00
Christopher Crone
654f9ebbaf
Tidy Makefiles
...
* Make BINARY mutability explicit
* Default docker build output type is local so use this
Signed-off-by: Christopher Crone <christopher.crone@docker.com>
2020-06-02 11:58:29 +02:00
Christopher Crone
9920fe2284
Remove unused variables
...
Signed-off-by: Christopher Crone <christopher.crone@docker.com>
2020-06-02 11:58:29 +02:00
Christopher Crone
247fa56ee1
More Dockerfile best practices
...
* Use mounts for RUN commands to avoid creating extra layers
* Use built-in platform support
Signed-off-by: Christopher Crone <christopher.crone@docker.com>
2020-06-02 11:58:24 +02:00
Djordje Lukic
3a2e16dc7a
Merge pull request #163 from docker/chore-remove-backend
...
Remove unused backend proto
2020-06-02 00:56:37 -07:00
Guillaume Tardif
ec5e61b645
Merge pull request #162 from docker/login_command
...
Move login to root command
2020-06-02 09:42:38 +02:00
Djordje Lukic
45b672a39d
Remove unused backend proto
2020-06-02 09:41:57 +02:00
Guillaume Tardif
e2b9f5bc57
Move login to root command, delegate to classic login when only one arg and not dot in it
2020-06-01 22:55:46 +02:00
Guillaume Tardif
f1fb80ecc5
Merge pull request #161 from docker/context_inspect
...
Add docker context inspect command relying on classic docker
2020-05-29 15:51:10 +02:00
Djordje Lukic
6830724ab9
Merge pull request #159 from docker/fix_azure_login
...
Fix Azure login : no need for ACI context first
2020-05-29 06:23:27 -07:00
Guillaume Tardif
528d47ce08
Add docker context inspect command relying on classic docker
2020-05-29 12:02:14 +02:00
Guillaume Tardif
01aaec2dbe
Fix Azure login : allow getting a backend when no corresponding context already exists with an explicit call from the login command. Will be usefull next for context creation with azure interactive things
2020-05-29 11:35:35 +02:00
Christopher Crone
9097b1f750
Add .git to .dockerignore
...
Signed-off-by: Christopher Crone <christopher.crone@docker.com>
2020-05-29 11:29:28 +02:00
Djordje Lukic
832651b1dc
Merge pull request #157 from docker/kill_child_process_on_cancel
...
Kill child process "docker-classic" on cancel
2020-05-28 04:53:47 -07:00
Guillaume Tardif
c8acbc33fd
Merge pull request #158 from docker/azure_backend_dependency
...
Remove azure resourceGroupClient from backend initialisation.
2020-05-28 10:52:01 +02:00
Guillaume Tardif
a948b6e1d0
Remove azure resourceGroupClient from backend initialisation. Several advantages :
...
- less dependencies to init backend. (Will need to work more on this to make login command not need an existing subscription ID)
- backend does not get login token at init time. For a long running process (grace server) this would cause issues with token lifetime
- we benefit from the client config (polling options especially) set in aci.go, without duplicating stuff
2020-05-28 10:16:42 +02:00
Guillaume Tardif
ea98a2dd78
Fix docker-classic creation makefile target
2020-05-27 21:14:07 +02:00
Guillaume Tardif
cc46f84043
Forward closing signal to docker-classic when closing docker. Note this will not forward Kill signal, impossible to intercept / process this one.
2020-05-27 18:38:51 +02:00
Guillaume Tardif
e630ace677
Merge pull request #154 from docker/fix_context_inspect_shellout
...
Fix shell out to docker-classic when invoking
2020-05-27 17:02:01 +02:00