Commit Graph

858 Commits

Author SHA1 Message Date
Guillaume Tardif 5eea111ecf Run containers and attach to logs by default, detach with -d option 2020-07-02 16:45:04 +02:00
Guillaume Tardif 3c83e01e9c
Merge pull request #327 from docker/compose-go
Use compose-go's Project and ProjectOptions
2020-07-02 16:43:34 +02:00
Guillaume Tardif 5a7f780bae
Merge pull request #328 from docker/do_not_wait_cleanup_results
In ACI e2e tests, do not wait for full resource group deletion at the end
2020-07-02 16:43:19 +02:00
Guillaume Tardif a9ef20eefd In ACI e2e tests, do not wait for full resource group deletion at the end, let ACI clean things UP (timeframe ~45 sec). This is costing GH Action minutes for nothing, and slows test results. 2020-07-02 16:13:38 +02:00
Nicolas De Loof 622402709a
Use compose-go's Project and ProjectOptions
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-07-02 16:05:45 +02:00
Guillaume Tardif 42b516e738
Merge pull request #323 from docker/fix-log-lines
Count the lines from the terminal, not from ACI
2020-07-02 14:00:11 +02:00
Guillaume Tardif 2f90715ba2
Merge pull request #321 from docker/dependabot/go_modules/github.com/Azure/azure-storage-file-go-0.8.0
Bump github.com/Azure/azure-storage-file-go from 0.7.0 to 0.8.0
2020-07-02 13:59:55 +02:00
Guillaume Tardif 15cdcf831e
Merge pull request #324 from docker/fix-non-console
Make sure we can have a console
2020-07-02 13:58:48 +02:00
Guillaume Tardif 964e331a10 Specific exit code when command fails because azure login is required. Will be used by VSCode Docker integration 2020-07-02 13:52:57 +02:00
Djordje Lukic e4354c82d1 Make sure we can have a console 2020-07-02 11:49:39 +02:00
Djordje Lukic d3f1209bab Add test for the backtracking of lines 2020-07-02 11:11:09 +02:00
Djordje Lukic e852e8f96a Count the lines from the terminal, not from ACI
Count the number of lines output on the terminal wrt the terminal width
so that we can go up the right amount.
2020-07-02 10:38:03 +02:00
Djordje Lukic 8e8c868a70
Merge pull request #322 from docker/fix_attach_logs
Fix logs replacement when streaming logs on windows
2020-07-02 10:37:27 +02:00
Guillaume Tardif 736b7a4707 Fix logs replacement when streaming logs on windows 2020-07-02 10:17:55 +02:00
dependabot-preview[bot] 5462d38969
Bump github.com/Azure/azure-storage-file-go from 0.7.0 to 0.8.0
Bumps [github.com/Azure/azure-storage-file-go](https://github.com/Azure/azure-storage-file-go) from 0.7.0 to 0.8.0.
- [Release notes](https://github.com/Azure/azure-storage-file-go/releases)
- [Changelog](https://github.com/Azure/azure-storage-file-go/blob/master/ChangeLog.md)
- [Commits](https://github.com/Azure/azure-storage-file-go/compare/v0.7.0...v0.8.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-07-01 21:27:44 +00:00
Djordje Lukic 14b2e54c06
Merge pull request #318 from docker/chore-browser
Return an error if unable to open the browser
2020-07-01 16:55:24 +02:00
Djordje Lukic e22b0ba676 Return an error if unable to open the browser
Also use github.com/pkg/browser instead of our own code
2020-07-01 16:47:49 +02:00
Djordje Lukic c9449dbf83
Merge pull request #315 from docker/fix_cve_guava
Fix cve guava
2020-07-01 15:59:32 +02:00
Guillaume Tardif 8bdb4dee77 Remove debug stuff from web images, that is causing apt-get install issues 2020-07-01 15:47:41 +02:00
Guillaume Tardif 514aa50ebc
Merge pull request #313 from docker/azure_multi_tenants
Allow users to specify tenanted when logging into azure (if several tenants for azure account)
2020-07-01 15:46:00 +02:00
Djordje Lukic 41c84ac313
Merge pull request #316 from docker/feat-ecs-metrics
Add ecs as a management command
2020-07-01 15:30:33 +02:00
Djordje Lukic 3a1cb0aaa0 Add ecs as a management command
This, with the "compose" being a management command makes it possible to
track ecs usage. See tests for more info
2020-07-01 15:18:35 +02:00
Djordje Lukic 5b79bb613a
Merge pull request #317 from docker/fix-master-ci
Indent master-ci.yml
2020-07-01 15:18:29 +02:00
Djordje Lukic 7a9a3d0e7e Indent master-ci.yml 2020-07-01 15:15:44 +02:00
Djordje Lukic e1967921bd
Merge pull request #314 from docker/hide_sidecar
Hide sidecar container from compose progress
2020-07-01 15:13:36 +02:00
Guillaume Tardif 29f8c81afc Hide sidecar container from compose progress 2020-07-01 15:08:18 +02:00
Guillaume Tardif 7cde96e8b6 Update guava to fix CVE 2020-07-01 14:59:23 +02:00
Guillaume Tardif bba9e055af Allow users to specify tenanted when logging into azure (if several tenants for azure account) 2020-07-01 12:27:18 +02:00
Guillaume Tardif 22b1de00ac
Merge pull request #309 from docker/win_aci_e2e
Win aci e2e tests
2020-07-01 10:53:40 +02:00
Guillaume Tardif efc1d21448 Add ACI e2e tests on windows, do not build with example + local contexts for ACI E2E on linux 2020-06-30 22:19:16 +02:00
Guillaume Tardif 664c48ba1e
Merge pull request #306 from docker/fix-credential-check
Fix credential checking on ACR image (for linux)
2020-06-30 22:16:40 +02:00
Guillaume Tardif 94877b18ab
Merge pull request #304 from docker/aci_inspect_memory_cpu
In ACI inspect, display memory limit in bytes, like Moby `docker inspect`.
2020-06-30 22:16:01 +02:00
Djordje Lukic fc4e0f6216
Merge pull request #308 from docker/test-stream-logs
Make log stream test more readable
2020-06-30 18:32:46 +02:00
Djordje Lukic 94a530b05f Make log stream test more readable 2020-06-30 18:26:38 +02:00
Guillaume Tardif 84e1522400
Merge pull request #301 from docker/no_double_build_on_master
Avoid running build twice on master with master.yml
2020-06-30 18:18:47 +02:00
Guillaume Tardif a48c4fb41c
Merge pull request #307 from docker/aci_e2e_group
Random ACI group name for tests, otherwise we are conflicting with each other + the CI
2020-06-30 18:18:16 +02:00
Guillaume Tardif f850dc557d Random ACI group name for tests, otherwise we are conflicting with each other + the CI.
Same for storage account name (outside of the scope of resource group)
2020-06-30 18:13:07 +02:00
Djordje Lukic 614a62b388
Merge pull request #305 from docker/feat-stream-aci-logs
Follow logs on ACI.
2020-06-30 17:49:00 +02:00
Djordje Lukic fdc2bd34d7 Add test for `logs --follow` on ACI 2020-06-30 17:13:51 +02:00
Djordje Lukic 06596dcd90 Follow logs on ACI.
This is not ideal, the ACI API doesn't give us a stream of logs, so we
need to fake it by moving the cursor up and rewriting the logs to
stdout. This means that, on gRPC side, we will stream the whole logs
each time. This is ok for now but we need to push Azure to give us a
real streaming API for logs
2020-06-30 16:34:32 +02:00
Ulysses Souza a72ffee4ff Fix credential checking on ACR image (for linux)
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-06-30 16:11:54 +02:00
Guillaume Tardif 96075236ee In ACI inspect, display memory limit in bytes, like Moby `docker inspect`.
Displaying in Gb also was rounding memory to zero if set to 0.xGb
2020-06-30 12:10:18 +02:00
Guillaume Tardif e5e87d3357
Merge pull request #302 from gtardif/aci_e2e_readme
Doc on running e2e tests
2020-06-30 11:54:20 +02:00
Guillaume Tardif 7fac6bf766 Avoid running build/tests/lint twice on master with master.yml 2020-06-30 11:52:44 +02:00
Guillaume Tardif 6d2d510027 Doc on running e2e tests 2020-06-30 11:31:49 +02:00
Guillaume Tardif f0ab42e109
Merge pull request #300 from docker/aci_ci
Run ACI e2e tests in the CI with basic support for service principal login
2020-06-30 10:29:13 +02:00
Guillaume Tardif f3cbbc48b8 Aci e2e tests moved to master build only 2020-06-30 10:14:19 +02:00
Guillaume Tardif 2268f0c598 Renamed Login method specific to tests, to make things more explicit 2020-06-30 10:11:06 +02:00
Guillaume Tardif 82ff8dcd7d Fix resource limit defaults and make aci e2e tests pass 2020-06-30 10:10:23 +02:00
Guillaume Tardif 5d29124498
Merge pull request #298 from docker/fix-aci-tail
Send the `tail` parameter to ACI if present
2020-06-30 09:45:48 +02:00