Commit Graph

1325 Commits

Author SHA1 Message Date
Guillaume Tardif e56061d27c Move fire and forget code from metrics.Track() (used only by CLI) to metrics.Send (used by both CLI and API)
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-15 17:28:23 +02:00
Djordje Lukic 2570ebec86 Add interceptor for API metrics, ensure registered methods have a corresponding method set for metrics
Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
2020-09-15 17:16:10 +02:00
Nicolas De Loof 46cebb3194
Prefer external.name over x-aws-securitygroup
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-09-15 15:34:18 +02:00
Nicolas De Loof 30de56f64f
Introduce support for external EFS volumes
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-09-15 13:03:53 +02:00
Guillaume Tardif 0c1de64c84
Merge pull request #610 from docker/fix_volume_error_message
fix error message on ACI docker volume rm
2020-09-15 12:38:32 +02:00
Guillaume Tardif 317659be8e
Merge pull request #613 from docker/progress_result
Progress functions can return a string, that can be used in the caller of progress.Run() to display final result after progress display
2020-09-15 12:38:14 +02:00
Guillaume Tardif 6cb19ed26d
Merge pull request #620 from gtardif/ci_labeller
Allow running action labeller on PR from forks, using pull_request-target
2020-09-15 12:29:05 +02:00
Guillaume Tardif d087d665d8 Trying back with pull_request_target event
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-15 11:40:38 +02:00
Guillaume Tardif 5e4470b153 Trying back with pull_request event
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-15 11:35:56 +02:00
Guillaume Tardif f6d26b321c Allow running action labeller on PR from forks, using pull_request-target. Cf https://github.com/actions/labeler/issues/12#issuecomment-670967607
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-15 10:20:32 +02:00
Guillaume Tardif 06d0ffae82 Fix volume error message
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-15 09:27:22 +02:00
Guillaume Tardif 1ffdab15b2
Merge pull request #616 from docker/go-1.15.2
Bump Golang to 1.15.2, golangci-lint to 1.31.0
2020-09-14 18:16:06 +02:00
Guillaume Tardif 4ce1fafc0a
Merge pull request #615 from docker/fix_linux_install
Fix linux install script parsing version
2020-09-14 18:14:42 +02:00
Chris Crone 5ef51722d0 deps: Bump Golang to 1.15.2, golangci-lint to 1.31.0
Signed-off-by: Chris Crone <christopher.crone@docker.com>
2020-09-14 17:23:18 +02:00
Guillaume Tardif 1bb1499675 Fix linux script parsing version to check if we have the new CLI already installed or not (need to keep azure check for users who have the previous version installed :/ )
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-14 16:59:56 +02:00
Guillaume Tardif 267b267201 Progress functions can return a string, that can be used in the caller of progress.Run to display final result after progress display
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-14 14:29:03 +02:00
Guillaume Tardif 9c07a7b3ad
Merge pull request #611 from docker/version_cloutd_integration
In version, replace “Azure integration” version info by “Cloud integration"
2020-09-12 16:02:55 +02:00
Guillaume Tardif 2ce4e98d88 In version, replace “Azure integration” version info by “Cloud integration”
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-11 17:29:40 +02:00
Guillaume Tardif b85eddd09c Remove duplicated code formatting multi errors
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-11 16:08:14 +02:00
Guillaume Tardif 57ded74aee
Merge pull request #598 from docker/encode_env_values
Properly send env variables containing “=“ in their value in ACI payload. Also properly send quoted values
2020-09-10 17:17:02 +02:00
Guillaume Tardif 98f0064fe9 Properly send env variables containing “=“ in their value in ACI payload. Also properly send quoted values
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-10 17:03:34 +02:00
Guillaume Tardif bcead6f5ce
Merge pull request #602 from docker/useragent
customize SDK user agent so AWS can track usage
2020-09-10 17:00:52 +02:00
Nicolas De Loof d649a5d92c
Use a custom user-agent so AWS can track usage
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-09-10 16:51:20 +02:00
Guillaume Tardif 3db0db04cb
Merge pull request #603 from docker/aci_volume_ids
Change volume IDs from “storageaccount@fileshare“ to “storageaccount/fileshare”
2020-09-10 16:46:53 +02:00
Guillaume Tardif 0b3fdb637d Change volume IDs from “storageaccount@fileshare“ to “storageaccount/fileshare”
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-10 16:07:22 +02:00
Guillaume Tardif c7a456ab83
Merge pull request #593 from docker/volume_create
ACI Volume create
2020-09-10 15:32:12 +02:00
Guillaume Tardif 07547d7b87 ACI Volume create flags are required
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-10 15:24:51 +02:00
Guillaume Tardif 099b64935b Minor fixes
Co-authored-by: Chris Crone <christopher.crone@docker.com>

Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-10 14:55:46 +02:00
Guillaume Tardif 80d23a6097 Removed NAME from `volume ls` output, allow `volume delete <ID>` using IDs from `volume ls`.
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-10 09:14:39 +02:00
Guillaume Tardif 38a8f5310b Volume command is only available in aci context type, with ACI specific flags
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-10 09:14:39 +02:00
Guillaume Tardif eaabee12e8
Merge pull request #595 from docker/IAM
Distinguish TaskExecutionRole and TaskRole
2020-09-09 11:37:22 +02:00
Guillaume Tardif 18ad20f1c5 Display errors if resource not found when deleting volumes (file share or storage account)
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-09 10:44:05 +02:00
Guillaume Tardif b96a6d1086 Add progress on volume creation
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-08 17:54:45 +02:00
Guillaume Tardif 96d785a5bd Added volume delete, can delete juste a file share or the storage account if confirmed
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-08 16:32:16 +02:00
Nicolas De Loof d4c745a7a8
AWS CI environment is not dedicated to tests
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-09-08 15:47:24 +02:00
Guillaume Tardif 2f672f6c4c Volume e2e test
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-08 15:30:50 +02:00
Guillaume Tardif 15addf5c22 Break out aci backend.go into several files for each service
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-08 15:30:50 +02:00
Guillaume Tardif dcbc1c3fb2 Volume cli minor refactor
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-08 15:30:50 +02:00
Guillaume Tardif 08562b403e Connecting it all
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-08 15:30:50 +02:00
Guillaume Tardif 9ed06ece5b Adding volume API & initial CLI command
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-08 15:30:50 +02:00
Guillaume Tardif 45179a5bff Add first volume create in ACI
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-08 15:30:50 +02:00
Nicolas De Loof 2f4011bfe6
Distinguish TaskExecutionRole and TaskRole
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-09-08 15:25:24 +02:00
Nicolas De Loof fda09712c0
Null safety
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-09-08 10:51:14 +02:00
Anca Iordache 12a15a9a4c
Merge pull request #594 from docker/minor_test_change
Most common scenario is to use `compose ls` without name option, and list all stacks
2020-09-08 10:50:09 +02:00
Guillaume Tardif 171ab1bd0c Most common scenario is to use `compose ls` without name option, and list all stacks
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-08 10:11:51 +02:00
Guillaume Tardif a2e0f16f07
Merge pull request #592 from docker/fix_compose_ls_tests
Fix `compose ls` tests
2020-09-08 09:06:39 +02:00
Guillaume Tardif 423f1a9ce8
Merge pull request #587 from docker/bump-golang
Bump Golang to 1.15.1
2020-09-08 09:02:34 +02:00
aiordache 9098405313 Fix `compose ls` tests
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-09-07 17:06:35 +02:00
Chris Crone 7545485f78
Merge pull request #591 from docker/flaky-aci
Attempt to fix flaky ACI tests
2020-09-07 17:05:58 +02:00
Guillaume Tardif dc7934d879
Merge pull request #585 from docker/aci_compose_ls
Implement `compose ls` for ACI
2020-09-07 15:15:09 +02:00