b3792dd258
progress for resource can be restarted after more Working event comes
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2024-04-15 22:05:46 +02:00
d8ee474e09
Revert "Stop the resource timer after last expected event"
...
This reverts commit a4ddbcb6b2
2024-04-15 22:05:46 +02:00
7d3616474d
Revert change to allow trying to kill again if a kill fails
...
Signed-off-by: Jaime Soriano Pastor <jaime.soriano@elastic.co>
2024-04-14 17:44:39 +02:00
6a3501f901
Handle errors and allow to send multiple kills if one failed
...
Signed-off-by: Jaime Soriano Pastor <jaime.soriano@elastic.co>
2024-04-14 17:44:39 +02:00
5daed33c6a
Ignore errors when killing on second Ctrl-C
...
Signed-off-by: Jaime Soriano Pastor <jaime.soriano@elastic.co>
2024-04-14 17:44:39 +02:00
5c1e5f3fc7
docker compose up always kills the containers on second Ctrl-C
...
Kill executed on the second Ctrl-C of docker compose up was
filtering containers depending on its state. In some cases the
containers can reach an state for what these filters don't get
any container, and the command keeps reporting `no container to
kill`.
Remove this filtering, so it tries to kill any container it
finds, independently of its state.
Fixes https://github.com/docker/compose/issues/10661
Signed-off-by: Jaime Soriano Pastor <jaime.soriano@elastic.co>
2024-04-14 17:44:39 +02:00
5059a1d7bf
Set Required false to depends_on containers for compose -p stop/down
...
Signed-off-by: koooge <koooooge@gmail.com>
2024-04-11 10:48:09 +02:00
54a525bbe6
Ignore missing containers when compose stop -p
...
Signed-off-by: koooge <koooooge@gmail.com>
2024-04-11 10:48:09 +02:00
8ceaf49296
Ignore missing containers when compose down -p
...
Signed-off-by: koooge <koooooge@gmail.com>
2024-04-11 10:48:09 +02:00
1d32592056
Introduce support for build.entitlements
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2024-04-10 12:27:49 +02:00
b4280fb561
e2e test for --all-resources
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2024-04-09 15:30:42 +02:00
29692b5921
Introduce --abort-on-container-failure
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2024-04-08 15:40:54 +02:00
ff20b641c7
Does not start keyboard manager if there is no tty
...
Signed-off-by: Joana Hrotko <joana.hrotko@docker.com>
2024-03-28 17:57:26 +00:00
466374bdd0
Unwrap error message.
...
Signed-off-by: Felix Fontein <felix@fontein.de>
2024-03-25 07:37:34 +01:00
2e85b3c265
Include error message in pull warning/errors
...
Signed-off-by: Felix Fontein <felix@fontein.de>
2024-03-25 07:37:34 +01:00
3371227794
chore(desktop): revised feature detection for file shares
...
Unfortunately, the feature flag mechanism for experimental features
isn't adequate. To avoid some edge cases where Compose might try to
use Synchronized file shares with Desktop when the feature isn't
available, we need to query a new endpoint.
Before we move any of this out of experimental, we need to improve
the integration here with Desktop & Compose so that we get all the
necessary feature/experiment state up-front to reduce the quantity
of IPC calls needed up-front.
For now, there's some intentional redundancy to avoid making this
extra call if we can avoid it. The actual endpoint is very cheap/
fast, but every IPC call is a potential point of of failure, so
it's worth it.
Signed-off-by: Milas Bowman <milas.bowman@docker.com>
2024-03-22 18:16:27 +01:00
e9dc82011f
Add Navigation Menu to compose up
...
Signed-off-by: Joana Hrotko <joana.hrotko@docker.com>
2024-03-22 17:48:25 +01:00
3950460703
Add support for volume Subpath option
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2024-03-22 14:33:56 +01:00
3b541b071c
Bump docker v26.0.0
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2024-03-22 14:33:56 +01:00
897d239fcb
Bump compose-go to v2.0.2
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2024-03-22 11:21:14 +01:00
c5a760ce43
add support for annotations
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2024-03-22 10:45:44 +01:00
26f687a12b
Revert "Bump compose-go to v2.0.1"
...
This reverts commit ad41461309
2024-03-21 13:43:44 -04:00
ad41461309
Bump compose-go to v2.0.1
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2024-03-21 15:54:41 +01:00
db4ed89528
feat(desktop): synchronized file share integration ( #11614 )
2024-03-20 14:41:24 -04:00
1b5fa3b93f
feat(experiments): add experimental feature state ( #11633 )
...
Use environment variable for global opt-out and Docker Desktop (if
available) to determine specific experiment states.
In the future, we'll allow per-feature opt-in/opt-out via env vars
as well, but currently there is a single `COMPOSE_EXPERIMENTAL` env
var that can be used to opt-out of all experimental features
independently of Docker Desktop configuration.
2024-03-20 13:44:27 +00:00
bc5fc6ba7e
fix `compose config --format json`
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2024-03-18 08:09:54 +01:00
b2d4c1b865
fix TestBuildPlatformsWithCorrectBuildxConfig
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2024-03-15 10:38:03 +01:00
5a1ba0efcf
only use ToModel when --no-interpolate is set
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2024-03-13 06:48:24 +01:00
17d4229e57
feat(desktop): add Docker Desktop detection and client skeleton ( #11593 )
2024-03-12 09:47:41 -04:00
c525373acb
make code simpler
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2024-03-01 09:55:03 +01:00
e99b8acea7
avoid duplicated "xx exited with code 0" message
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2024-02-29 13:57:17 +01:00
8ab8df86e0
introduce --watch
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2024-02-28 19:04:58 +01:00
1680f9a874
restore support for `config --no-interpolate`
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2024-02-28 18:54:43 +01:00
697a48af32
use an dedicated compose file --quiet-pull e2e test
...
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
2024-02-21 18:59:09 +01:00
94246f3cac
pass QuietOption when starting dependencies from run command
...
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
2024-02-19 14:19:01 +01:00
de3da829ea
sort containers to optimize scale down
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2024-02-15 17:47:42 +01:00
c79aabde32
discard stdout for laaarge log test
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2024-02-15 16:18:58 +01:00
a220043ca0
Merge pull request #11497 from milas/rm-docker-cp-syncer
...
chore(watch): remove old `docker cp` implementation
2024-02-14 21:26:05 +01:00
e330f5905b
docs: unify no trailing dots in docstrings and help ( #11301 )
2024-02-14 14:02:37 -05:00
16c8099cf8
Use listener for file metadata
...
Signed-off-by: jhrotko <joana.hrotko@docker.com>
2024-02-14 16:51:56 +00:00
07bda5960e
fix deadlock collecting large logs
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2024-02-13 20:15:19 +01:00
d203402998
chore(watch): remove old `docker cp` implementation
...
This has not been the default for quite a while and required
setting an environment variable to revert back.
The tar implementation is more performant and addresses several
edge cases with the original `docker cp` version, so it's time
to fully retire it.
The scaffolding for multiple sync implementations remains to
support future experimentation here.
Signed-off-by: Milas Bowman <milas.bowman@docker.com>
2024-02-13 12:56:53 -05:00
aaa7ef6de5
Include all networks in ContainerCreate call if API >= 1.44
...
Previously, we included the container's primary network in the
ContainerCreate API call, and then connected the created container
to each extra network one-by-one, by calling NetworkConnect.
However, starting API version 1.44, the ContainerCreate endpoint now
takes multiple EndpointsConfigs, allowing us to just include all the
network configurations there and skip connecting the container to each
extra network separately.
Signed-off-by: Laura Brehm <laurabrehm@hey.com>
2024-02-07 16:21:15 +01:00
3c25af4fe9
Merge pull request #11405 from ndeloof/issue_11392
...
Fix load .env from project directory when project file is set by COMPOSE_FILE
2024-01-31 10:52:28 +01:00
8fdd45cd4c
chore(e2e): fix flaky test & standalone behavior ( #11382 )
2024-01-30 10:49:53 -05:00
0582001810
Fix canonical container name
...
Signed-off-by: jhrotko <joana.hrotko@docker.com>
2024-01-30 15:12:22 +01:00
da1a34a8f2
don't check external network existence when swarm is enabled
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2024-01-29 20:00:29 +01:00
7e991515bc
Add support for storage_opt
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2024-01-29 19:24:23 +01:00
a8bd3b7af1
Fix load .env from project directory when project file is set by COMPOSE_FILE
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2024-01-25 09:26:22 +01:00
1551fcb4e6
introduce stopAndRemoveContainer to share logic scaling down
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2024-01-23 14:16:13 +01:00
Nicolas De Loof
Jaime Soriano Pastor
koooge
Joana Hrotko
Felix Fontein
Milas Bowman
Guillaume Lours
Piotr Dąbrowski
Laura Brehm