Commit Graph

193 Commits

Author SHA1 Message Date
Guillaume Tardif b0c50ed6dd Implement compose ps on ACI
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-08-28 17:43:18 +02:00
Guillaume Tardif ed395a1e64 Display nice message on context creation (message taken from Moby cli)
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-08-26 18:09:01 +02:00
Guillaume Tardif ad5c465bd1
Merge pull request #485 from docker/repo-rename
Rename docker/api -> docker/compose-cli
2020-08-25 15:58:51 +02:00
Ulysses Souza 59f7d7cd00 Redirect user from plugin usage to integrated ECS
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-08-24 19:29:10 +02:00
Guillaume Tardif a61c2d16de
Merge pull request #537 from docker/e2e_better_logs
E2e improvements
2020-08-24 17:12:15 +02:00
Guillaume Tardif 981665b02c Better renaming
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-08-24 16:09:20 +02:00
Guillaume Lours 10b7197e4a Remove version in test compose files
Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>
2020-08-24 10:15:42 +02:00
Guillaume Tardif 2bac8cf94e Fix linter
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-08-21 21:28:15 +02:00
Guillaume Tardif 7204692e3a Use test name instead of arbitrary string that needs to be different for each test
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-08-21 18:46:31 +02:00
Guillaume Tardif 30884ad91a Display executed commands (prefixed with test name for readable logs in // runs)
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-08-21 18:46:17 +02:00
Guillaume Tardif da6334f415 Renaming, expect commands to succeed by default (removed a bunch of res.Assert(success) )
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-08-21 18:45:38 +02:00
Chris Crone 4c6280b0e9 Rename docker/api -> docker/compose-cli
Signed-off-by: Chris Crone <christopher.crone@docker.com>
2020-08-21 17:28:39 +02:00
Guillaume Tardif e05603a5ca More ECS E2E tests (secrets), in // of compose
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-08-21 15:56:00 +02:00
Guillaume Tardif 73f5f030ac Fix flakiness in ECS E2E : wait when reaching nginx welcome page, sometimes stack is not fully up and we get 503 errors
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-08-21 11:53:01 +02:00
Guillaume Tardif bff1fa1872
Merge pull request #525 from docker/workingdir
workdir default value is defined by compose file
2020-08-21 10:22:31 +02:00
Guillaume Tardif e19a740102 Adapt aci compose test reflecting the change.
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-08-21 09:59:50 +02:00
Djordje Lukic 635ecd7b99 Return a default implementation when nil
Some backends can decide not to implement a whole set of APIs (compose
for example), we now return a default implementation that returns a
`errdefs.ErrNotImplemented` for each action making it easy for the cli
to print a helpful error message. We also remove any possible nil
panics.

Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
2020-08-20 14:32:03 +02:00
Guillaume Tardif d49d4473c3 Allow running ECS E2E tests locally
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-08-20 09:59:24 +02:00
Guillaume Tardif 3a83d85d7a First ECS E2E test
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-08-19 19:13:23 +02:00
Guillaume Tardif 64dd7a5674 Check that AZURE creds are defined when running E2E tests
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-08-19 11:58:02 +02:00
Guillaume Tardif 6ad48b9212 Updated ACI e2e flaky test to avoid failing when https://github.com/docker/desktop-microsoft/issues/49 happens
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-08-18 12:42:01 +02:00
Guillaume Lours 95de770e87 Update or add license header which are not valid
Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>
2020-08-17 16:55:25 +02:00
Guillaume Tardif 27e7a0ced3
Merge pull request #475 from docker/aci_volume_keys
Get storage account key from azure login, no need to specify it in compose file or run -v option
2020-08-14 17:55:56 +02:00
Guillaume Tardif 274dc8283f Use proper context in storage key retrieval 2020-08-14 17:01:44 +02:00
Chris Crone d902c968e7
Merge pull request #481 from ulyssessouza/fix-golang114-e2e-local-tests
Fix e2e-local tests when compiled with go1.14
2020-08-14 14:32:46 +02:00
Guillaume Tardif a86854effd Slightly update timeout, failing on windows nodes (https://github.com/docker/api/runs/984443961). Didn’t want to make it too long either, avoid waiting 2 mins to see when it’s failing. We’ll update this again if we see it’s not enough. 2020-08-14 12:42:19 +02:00
Guillaume Tardif 3a60c957ae Get storage account key from azure login, no need to specify it in compose file or run -v option 2020-08-14 12:26:09 +02:00
Guillaume Tardif 104b3d4dc8 Change ACI test region to eastus2. Improve error output when waiting for container status 2020-08-14 12:12:06 +02:00
Ulysses Souza 2f16ca1e7a Fix e2e-local tests when compiled with go1.14
Check https://github.com/golang/go/commit/64cfe9f

Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-08-14 09:45:03 +02:00
Djordje Lukic 9a29037e0f Put 40 seconds for timeout instead of 20
For some reason this test fails on CI with a timeout.
2020-08-13 09:50:06 +02:00
Djordje Lukic aa8bf1daaa Add test for ACI start 2020-08-12 14:50:47 +02:00
Guillaume Tardif 3d758b7f26 Implement `docker ps —all` filter on ACI 2020-08-12 11:59:36 +02:00
Guillaume Tardif ee062e8333 ACI Stop implementation 2020-08-12 10:32:35 +02:00
Djordje Lukic f44d29f4df Fix the rm test without force
mutlierror didn't append an `Error:` if there is only one error...
2020-08-11 17:06:45 +02:00
Djordje Lukic 80c1b2246b
Merge pull request #457 from docker/feat-aci-force-rm
Add --force to rm on ACI
2020-08-11 16:42:49 +02:00
Djordje Lukic 093a69136f Add --force to rm on ACI
If a container is running the user must force the removal of the
container.
2020-08-11 16:30:42 +02:00
Guillaume Tardif ec5f4e9202 Add options to `docker login azure` to support Service Principal login. Use it in E2E tests 2020-08-11 12:11:51 +02:00
Chris Crone fc64f2923b aci-e2e: Windows fixes
Signed-off-by: Chris Crone <christopher.crone@docker.com>
2020-08-10 17:23:50 +02:00
Chris Crone 65fb6020a0 tests.e2e: Check Windows specific error
Signed-off-by: Chris Crone <christopher.crone@docker.com>
2020-08-10 15:06:20 +02:00
Chris Crone 6e99119a4b tests.e2e: Fix Windows tests
Signed-off-by: Chris Crone <christopher.crone@docker.com>
2020-08-10 14:26:47 +02:00
Chris Crone 017053e19a tests.e2e: Refactor
Signed-off-by: Chris Crone <christopher.crone@docker.com>
2020-08-10 14:12:46 +02:00
Guillaume Tardif 4dd1918ac2 Improve test that was sometimes passing too quickly where it should fail 2020-08-05 15:05:32 +02:00
Guillaume Tardif f442eafe0b Validate run restart option value. Default value is “none”, instead of “no”, this is more in line with compose values, and changes only the default so should not have too much impact on legacy usage. 2020-08-04 17:11:21 +02:00
Ulysses Souza a2c2d6aa5d Add Restart Policy support when running single container 2020-08-04 16:57:58 +02:00
Chris Crone f8ce7a4780 cli: Move to gotest.tools
Signed-off-by: Chris Crone <christopher.crone@docker.com>
2020-08-04 14:03:24 +02:00
aiordache 87245ef727 rename packages ( amazon to ecs and azure to aci )
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-07-30 11:34:34 +02:00
aiordache 648f0139df add e2e test for compose up on default context
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-07-29 17:33:23 +02:00
Christopher Crone eac315c6ec tests: Fix logout test on Windows
The macOS/Linux output when logging out from a registry that you're not
logged into is different to that of Windows. As the login test doesn't
really test if the registry login works, the test now just checks that
the command is properly parsed.

Signed-off-by: Christopher Crone <christopher.crone@docker.com>
2020-07-17 16:55:12 +02:00
Christopher Crone d1a929eb7f cli: Fix logout when specifying a registry
Signed-off-by: Christopher Crone <christopher.crone@docker.com>
2020-07-17 16:29:12 +02:00
Djordje Lukic 4480d27595 Don't set the container name in the test
This will help us catch errors such as
https://github.com/docker/desktop-microsoft/issues/42
2020-07-16 10:39:41 +02:00