Commit Graph

1571 Commits

Author SHA1 Message Date
Guillaume Tardif 487a4e485c Fix Flaky test due to array random order
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-16 17:13:52 +02:00
Guillaume Tardif 869a0b8dd8 Apply suggestions from code review
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-16 17:01:52 +02:00
Guillaume Tardif 6a4d14e03d Apply suggestions from code review
Co-authored-by: Chris Crone <christopher.crone@docker.com>

Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-16 17:01:51 +02:00
Guillaume Tardif e705d4915c Adding documentation for single container run and `docker run flags` support in ACI
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-16 17:01:51 +02:00
Guillaume Tardif a1a99786b0 Add log section for compose application, Add log limitation. Fix sections links
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-16 17:01:51 +02:00
Guillaume Tardif 5dd4f9d2a8
Merge pull request #796 from gtardif/fix_aci_e2e_cleanup
Fix Makefile command to cleanup ACI E2E resource groups
2020-10-16 16:30:05 +02:00
Nicolas De loof 31a0cf08d7
Merge pull request #779 from docker/ulimits
add support for ulimits.nofile
2020-10-16 16:12:02 +02:00
Guillaume Tardif 77f8718f03
Merge pull request #800 from docker/fix_windows_tests
Fix unit tests on windows: for secret target path, use path.Join etc. instead of filepath.Join
2020-10-16 15:32:31 +02:00
guillaume.tardif 18966eb3a1 for secret target path, use path.Join etc. instead of filepath.Join, as these paths are container side, not cli side. (do not use windows paths).
Signed-off-by: guillaume.tardif <guillaume.tardif@gmail.com>
2020-10-16 14:57:47 +02:00
Nicolas De Loof 10b8fabaae
Allow user to set ami/machine by Deploy.Placement.Constraint
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-10-16 14:19:51 +02:00
Nicolas De loof d55f8e4ee1
Merge pull request #795 from docker/kirikou
Store external cluster as metadata
2020-10-16 13:59:53 +02:00
Nicolas De Loof 4760ae334d
Store external cluster as metadata
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-10-16 13:42:20 +02:00
Guillaume Tardif 333e4e5675
Merge pull request #787 from docker/add-abs-path-secret-target
Support absolute paths for secrets
2020-10-16 11:59:27 +02:00
Guillaume Tardif 0f417e9997 Fix Makefile command to cleanup ACI E2E resource groups
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-16 11:43:03 +02:00
Anca Iordache 05295b5e8a
Merge pull request #765 from docker/ecs_default_profile
Populate ~/.aws/config(credentials) on ecs context create
2020-10-16 11:33:03 +02:00
Nicolas De loof 6d7348c9b4
Merge pull request #792 from docker/examples
Add compose file examples for ECS
2020-10-16 11:10:48 +02:00
aiordache 9e69386d75 Add examples for several features
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-10-16 10:37:02 +02:00
aiordache c2af0a136a Populate ~/.aws/config(credentials) on ecs context create
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-10-15 20:26:38 +02:00
Ulysses Souza 06e44a813c Support absolute paths for secrets
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-10-15 15:46:07 +02:00
Guillaume Tardif 50a2ae1100 Display summary of reclaimed ACI resources (CPU/mem) in `docker prune`
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-15 15:45:48 +02:00
Guillaume Tardif 7f4bfd16dc
Merge pull request #782 from gtardif/doc_cross_build_ci
Document cross build step reason & timing in CI
2020-10-15 10:26:16 +02:00
Guillaume Tardif e02176004b Document cross build step reason & timing in CI
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-15 10:07:17 +02:00
Chris Crone bb9b059288
Merge pull request #785 from docker/disable_more_aci_tests
Make ACI exec test less strict to handle differing outputs
2020-10-15 09:45:57 +02:00
Nicolas De loof 2f64376f84
Merge pull request #786 from docker/feat_prune 2020-10-14 18:19:21 +02:00
Guillaume Tardif a5e34323e2 Add `docker prune` command and ACI implementation
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-14 17:48:11 +02:00
Guillaume Tardif 7cf7b00584 Add ResourceService definition and ACI NOOP implementation
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-14 15:40:24 +02:00
Nicolas De loof 82db90646f
Merge pull request #783 from docker/efs_opts
Let user pass EFS create option by driver_opts
2020-10-14 15:20:18 +02:00
Guillaume Tardif 1bd5ed56bc Make one ACI test less strict, we still encounter issues related to deployments on Atlas platform (errors on `docker exec`: failed to read input from container: ws closed: 1000, cf https://github.com/docker/compose-cli/runs/1247798295)
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-14 14:35:00 +02:00
Nicolas De Loof 47344608b8
add support for ulimits.nofile
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-10-14 12:08:48 +02:00
Nicolas De Loof 8379bf467e
Let user pass EFS create option by driver_opts
fixes #781

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-10-14 11:52:03 +02:00
Ulysses Souza 660c7bbdcf Add command "volume inspect"
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-10-14 11:11:55 +02:00
Guillaume Tardif 18ac5d7e66
Merge pull request #774 from gtardif/fix_go_dep_darwin
Remove indirect dependency causing error on Darwin build. Adding cross compile in CI build (all PRs)
2020-10-13 17:29:35 +02:00
Guillaume Tardif 699f9a3dfb Cross compile in CI
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-13 17:16:12 +02:00
Guillaume Tardif c6ac64d66a Remove indirect dependency causing error on Darwin build. Adding cross compile in CI build (all PRs)
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-13 17:11:37 +02:00
Guillaume Tardif 243b0d1b6a
Merge pull request #771 from docker/fix_panic_inspect_empty
Fix panic when invoking inspect with empty container id
2020-10-13 15:44:33 +02:00
Guillaume Tardif d8cd4038c2 Fix panic when invoking inspect with empty container id (ACI SDK returns status 200 but nil container group properties)
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-13 15:33:52 +02:00
Nicolas De loof 9e06f42190
Merge pull request #747 from docker/efs_volumes 2020-10-13 15:26:33 +02:00
Guillaume Tardif b25c7696bf
Merge pull request #770 from gtardif/fix_gRPC_regression
Put back gRPC fields to avoid API breaking change with existing versi…
2020-10-13 15:11:17 +02:00
Nicolas De Loof a87300d1df
set filesystem name to make it more visible on AWS web console
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-10-13 15:08:40 +02:00
Guillaume Tardif 7d8a1398c9 Put back gRPC fields to avoid API breaking change with existing versions of node-sdk, introduced by cfc490fd92
(Even though these fields are unused in VSCode Docker extension, removing them and re-using the fields number totally breaks APIs returning containers : ls, inspect)

Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-13 15:07:08 +02:00
Nicolas De Loof 5d5765173e
Create volume for compose app
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-10-13 14:18:01 +02:00
Guillaume Tardif f7cce91b80
Merge pull request #768 from gtardif/disable_msql_aci_test_again
Disabling mysql ACI test again, see https://github.com/docker/compose-cli/runs/1246970427
2020-10-13 12:34:52 +02:00
Guillaume Tardif 1a4d45dd06 Too flaky, see https://github.com/docker/compose-cli/runs/1246970427
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-13 12:28:22 +02:00
Guillaume Tardif b1382c9dc3
Merge pull request #766 from docker/debug_aci_db_error
Add debug information when mysql cannot start on ACI E2E test
2020-10-13 12:09:00 +02:00
Nicolas De Loof e903326e1a
Check external filesystems exist on compose up
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-10-13 10:43:01 +02:00
Guillaume Tardif 9f5f1cc4c3 Add debug information when mysql cannot start on ACI E2E test
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-13 09:37:12 +02:00
Guillaume Tardif be4b9a6812
Merge pull request #760 from docker/add-quiet-flags
Add --quiet for some commands
2020-10-13 09:00:58 +02:00
Guillaume Tardif a6e06342d1
Merge pull request #763 from docker/fiw_windows_tests_secrets
Trim line returns for windows tests
2020-10-13 08:45:32 +02:00
Nicolas De loof 45bb05ee19
Merge pull request #764 from docker/test_with_mock
More unit tests with aws-sdk behind an interface + mocks
2020-10-12 21:21:38 +02:00
Guillaume Tardif 7b8255c953 Replaces windows carriage return for windows tests
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-12 17:23:47 +02:00