Guillaume Tardif
9b140930a7
Merge pull request #979 from docker/console
...
Don't start buildx' build with empty opts
2020-11-27 14:54:39 +01:00
Nicolas De loof
e94646f56a
Merge pull request #978 from gtardif/fix_compose_up_display
...
Ensure images are pulled/build with build first, before creating networks / volumes.
2020-11-27 14:32:50 +01:00
Nicolas De Loof
a542b5d37f
Don't start buildx' build with empty opts
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-11-27 14:18:06 +01:00
Guillame Tardif
bc9099de9b
Ensure images are pulled/build with build first, before creating networks / volumes and starting containers.
...
Will also avoid mixing build output and compose-cli progress display
Signed-off-by: Guillame Tardif <guillaume.tardif@gmail.com>
2020-11-27 13:52:58 +01:00
Nicolas De loof
c0805464f5
Merge pull request #976 from docker/volume_labels
...
Volume labels
2020-11-27 12:15:38 +01:00
Nicolas De Loof
b42b61e307
rename method for clarity
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-11-27 12:05:57 +01:00
Nicolas De Loof
3ff6923d2e
align coding-style with network labels
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-11-27 10:51:58 +01:00
Nicolas De Loof
49e653f142
unused context parameter
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-11-27 10:29:08 +01:00
Nicolas De Loof
f65a0d3720
Create volume with labels
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-11-27 10:21:36 +01:00
Nicolas De Loof
646aca82d9
composeService to rely on apiClient
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-11-27 10:21:36 +01:00
Nicolas De loof
a60b008819
Merge pull request #973 from gtardif/compose_name_workingDir
...
Latest compose-go, keeping “-“ in project names derived from workingDir
2020-11-27 09:38:27 +01:00
Guillaume Tardif
3c073b51a2
Latest compose-go, keeping “-“ in project names derived from workingDir
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-11-27 09:13:05 +01:00
Guillaume Tardif
de3b6cb450
Add compose labels for composefiles
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-11-26 17:13:24 +00:00
Nicolas De loof
f7905efc36
Merge pull request #960 from docker/build
2020-11-26 17:58:22 +01:00
Nicolas De loof
775c46084c
Merge pull request #969 from gtardif/compose-network_labels
...
Add compose labels for network
2020-11-26 16:28:52 +01:00
Guillaume Tardif
efdf80ebb8
Merge pull request #962 from gtardif/fix_panic_terminal_size_debug
...
Avoid panic in some weird cases (debug in VSCode for example)
2020-11-26 16:00:20 +01:00
Guillaume Tardif
e441fbba5a
Add compose labels for network
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-11-26 15:45:25 +01:00
Nicolas De Loof
1e2f0c75c5
fix path to build context
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-11-26 14:22:45 +01:00
Nicolas De Loof
0f4bcb9f17
Build and pull in parallel with BuildKit
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-11-26 14:11:40 +01:00
Nicolas De Loof
a0b609a5dd
implement service image build by BuildKit
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-11-26 14:07:53 +01:00
Guillaume Tardif
426b333dd8
Merge pull request #961 from gtardif/compose_container_labels
...
Add container labels to improve compatibility with docker-compose
2020-11-25 18:14:18 +01:00
Guillaume Tardif
f997d7a128
Avoid panic in some weird cases (debug in VSCode for example)
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-11-25 18:07:22 +01:00
Guillaume Tardif
24328c4620
Add container labels to improve compatibility with docker-compose
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-11-25 17:53:12 +01:00
Nicolas De loof
9e1de51f82
Merge pull request #956 from docker/fix-port-collision
...
Avoid port collision with compose up test
2020-11-24 18:20:41 +01:00
Guillaume Tardif
a80998e0b2
Merge pull request #958 from docker/bump-azure-go-sdk
...
Bump `azure-sdk-for-go`: v43.3.0 -> v48.2.0
2020-11-24 16:06:54 +01:00
Ulysses Souza
fe566d24e6
Bump `azure-sdk-for-go`: v43.3.0 -> v48.2.0
...
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-11-24 11:48:26 -03:00
Ulysses Souza
794a182bdd
Avoid port collision with compose up test
...
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-11-24 11:10:17 -03:00
Nicolas De loof
b473c6db63
Merge pull request #959 from docker/update-make-pre-commit
...
Update `make pre-commit` with more checks
2020-11-24 10:00:39 +01:00
Nicolas De loof
3c8938dc76
Merge pull request #955 from docker/bump-deps
2020-11-24 09:00:21 +01:00
Nicolas De loof
bdde820989
Merge pull request #957 from docker/linter-dependencies-local
...
Fix some linter issues when running `make lint`
2020-11-24 09:00:04 +01:00
Ulysses Souza
1ecf8b5c5b
Update `make pre-commit` with more checks
...
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-11-23 18:37:13 -03:00
Ulysses Souza
8f8b97d031
Fix linter issues when running `make lint`
...
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-11-23 17:05:40 -03:00
Chris Crone
03e95839c8
deps: Update Go modules, remove duplicate
...
Signed-off-by: Chris Crone <christopher.crone@docker.com>
2020-11-23 15:03:03 +01:00
Chris Crone
7a740aebf5
deps: Bump Go and golangci-lint
...
* Go to 1.15.5
* golangci-lint 1.33.0
Signed-off-by: Chris Crone <christopher.crone@docker.com>
2020-11-23 15:01:02 +01:00
Guillaume Tardif
97560f8ffc
Merge pull request #953 from docker/windows_e2e_docker_logout
...
On GH Actions windows nodes, ensure there is no automatic docker login before running ACI E2E tests
2020-11-23 14:56:00 +01:00
Guillaume Tardif
1f8fbe5f11
On GH Actions windows nodes, ensure there is no automatic docker login before running ACI E2E tests
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-11-23 14:32:49 +01:00
Nicolas De loof
e984f76544
Merge pull request #948 from docker/fix-compose-pull
2020-11-23 10:05:38 +01:00
Djordje Lukic
5ffdaa5cca
Use json progress message
...
It contains the same output that `docker pull` shows
Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
2020-11-23 10:00:13 +01:00
Guillaume Tardif
8d7f213ba8
Merge pull request #886 from docker/auto-create-aci-fileshare
...
Add auto creation of fileshares
2020-11-23 09:31:57 +01:00
Nicolas De loof
93490d5f4f
Merge pull request #942 from docker/chore-remove-done
...
Remove useless Done in the progress writer
2020-11-22 19:07:38 +01:00
Djordje Lukic
be40bdb032
Remove useless Done in the progress writer
...
Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
2020-11-22 17:30:28 +01:00
Nicolas De loof
34e4a006c0
Merge pull request #947 from docker/feat-dependency-graph
2020-11-22 09:47:51 +01:00
Djordje Lukic
5cf5410bc8
Detect cycles
...
Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
2020-11-21 23:58:12 +01:00
Djordje Lukic
1f43b83409
Use a dependency graph to start services
...
The algorithm is like so:
* get all the leaves of the graph, these are all the service that don't have any dependency
* once a service is started we take the list of its parents (dependents)
* if all the dependencies of each of those dependents are started then we can start it as well
* if not then we continue to the next dependent
Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
2020-11-21 22:30:32 +01:00
Nicolas De loof
162c6036b2
Merge pull request #946 from HollowMan6/patch-1
...
Fix typos in `docs/aci-compose-features.md`
2020-11-21 15:41:28 +01:00
Hollow Man
b91fbb934f
Fix typos
...
symetrical -> symmetrical
resoure -> resource
Signed-off-by: Hollow Man <hollowman@hollowman.ml>
2020-11-21 22:12:37 +08:00
Nicolas De loof
7a49736d06
Merge pull request #944 from gtardif/compose_e2e
...
First local compose e2e tests
2020-11-21 13:23:00 +01:00
Guillaume Tardif
aa534979bc
First local compose e2e tests
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-11-20 18:06:11 +01:00
Guillaume Tardif
a4dfe706d6
Merge pull request #943 from docker/fix_graph
...
Fix processing dependency graph only onces per node
2020-11-20 18:04:23 +01:00
Nicolas De Loof
98cc5cc1eb
Fix processing dependency graph only onces per node
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-11-20 17:56:27 +01:00