Djordje Lukic
611667d252
Fix linting
2020-08-11 17:36:54 +02:00
Sebastiaan van Stijn
c862d7821d
Remove custom multierrors package
...
The hashicorp/go-multierror package provides functionality to do
this. Replacing the custom package in favor of those (at the cost
of some small duplication).
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2020-08-11 17:24:51 +02:00
Djordje Lukic
80c1b2246b
Merge pull request #457 from docker/feat-aci-force-rm
...
Add --force to rm on ACI
2020-08-11 16:42:49 +02:00
Djordje Lukic
093a69136f
Add --force to rm on ACI
...
If a container is running the user must force the removal of the
container.
2020-08-11 16:30:42 +02:00
Guillaume Tardif
6ff20cf104
more concise validation
...
Co-authored-by: Djordje Lukic <djordje.lukic@docker.com>
2020-08-11 13:45:46 +02:00
Guillaume Tardif
ec5f4e9202
Add options to `docker login azure` to support Service Principal login. Use it in E2E tests
2020-08-11 12:11:51 +02:00
aiordache
00f17534a3
error check
...
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-08-06 18:13:17 +02:00
aiordache
64c517f375
remove unused parameter
...
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-08-06 18:13:17 +02:00
aiordache
46e58a28d0
Add ps and logs to compose API
...
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-08-06 18:13:17 +02:00
Anca Iordache
4c3c219518
Merge pull request #411 from docker/enable_ecs
...
Enable ecs backend
2020-08-06 12:17:00 +02:00
aiordache
42a5dfc0d2
rename runCompose() to checkComposeSupport()
...
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-08-06 12:02:11 +02:00
aiordache
bb3500d77b
check with client if context is supported (has a backend)
...
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-08-06 11:49:54 +02:00
Guillaume Tardif
cdd4028788
Fix flaky nil pointer in signal forwarding to child process (see https://github.com/docker/api/runs/949400778 )
2020-08-06 10:23:12 +02:00
Guillaume Tardif
29fe26620a
Stop forwarding signals to child process when the child terminates
2020-08-05 15:05:32 +02:00
Guillaume Tardif
05a8582126
Forward all signals to child process
2020-08-05 15:05:32 +02:00
aiordache
d1b8bcb2c7
fix signal passing to mobycli
...
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-08-05 15:05:32 +02:00
Guillaume Tardif
f442eafe0b
Validate run restart option value. Default value is “none”, instead of “no”, this is more in line with compose values, and changes only the default so should not have too much impact on legacy usage.
2020-08-04 17:11:21 +02:00
Ulysses Souza
a2c2d6aa5d
Add Restart Policy support when running single container
2020-08-04 16:57:58 +02:00
Chris Crone
0e92fd21d0
cli.options: Do not test port list order
...
Signed-off-by: Chris Crone <christopher.crone@docker.com>
2020-08-04 16:31:02 +02:00
Chris Crone
f8ce7a4780
cli: Move to gotest.tools
...
Signed-off-by: Chris Crone <christopher.crone@docker.com>
2020-08-04 14:03:24 +02:00
aiordache
5f7c284d58
update delegation test to check all context types
...
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-07-30 11:40:44 +02:00
aiordache
87245ef727
rename packages ( amazon to ecs and azure to aci )
...
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-07-30 11:34:34 +02:00
aiordache
2471e51b39
set build tag for the ecs context and backend
...
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-07-30 11:34:34 +02:00
aiordache
cfa7406d73
fix tests
...
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-07-30 11:34:34 +02:00
aiordache
fb63373a9b
remove cluster property from aws context
...
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-07-30 11:34:34 +02:00
aiordache
355295696f
Create aws context
...
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-07-30 11:34:34 +02:00
aiordache
648f0139df
add e2e test for compose up on default context
...
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-07-29 17:33:23 +02:00
aiordache
5a26b25709
handle compose on all context types
...
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-07-29 11:58:09 +02:00
aiordache
cfd6d2f5d1
Error out for contexts not implementing compose command
...
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-07-28 16:30:08 +02:00
Christopher Crone
d1a929eb7f
cli: Fix logout when specifying a registry
...
Signed-off-by: Christopher Crone <christopher.crone@docker.com>
2020-07-17 16:29:12 +02:00
Christopher Crone
af0417c758
cli: Refactor Azure logout
...
Signed-off-by: Christopher Crone <christopher.crone@docker.com>
2020-07-17 16:23:15 +02:00
Djordje Lukic
84dbd1467d
Move the struct for creating and aci context to azure package
2020-07-13 11:05:19 +02:00
Guillaume Tardif
43b54ef75a
Also remove map[string]string for azure login (tenantId param)
2020-07-10 16:55:44 +02:00
Guillaume Tardif
97d408d25d
Replaced map[string] string by existing aciCreateOpts struct for context create
2020-07-10 16:39:09 +02:00
Guillaume Tardif
c36b64c10b
Fixing subscription-id parameter not passed to backend...
2020-07-10 15:27:41 +02:00
Guillaume Tardif
1fbdbbbbe3
Merge pull request #381 from docker/fix-logs-windows
...
Get the real width of the terminal
2020-07-10 13:06:07 +02:00
Guillaume Tardif
52c2d09eae
Merge pull request #376 from docker/logout
...
Implement azure logout
2020-07-10 09:48:39 +02:00
Djordje Lukic
ef2d304762
Allow non-interactive exec on ACI
...
If the request is for a non-interactive exec we don't attach the stdin
when executing.
2020-07-09 11:47:22 +02:00
Djordje Lukic
e6c115dc17
Get the real width of the terminal
...
github.com/buger/goterm always returns 80 on windows...
2020-07-09 10:50:48 +02:00
Guillaume Tardif
492ce96dd4
Implement azure logout
2020-07-08 17:48:10 +02:00
Guillaume Tardif
c5cd0f44f8
Fix ACI e2e tests : do not use console if no tty option set in exec
2020-07-07 14:05:25 +02:00
Guillaume Tardif
cb3ac513cc
Add run env variables support (KEY=AVLUE or KEY, will grab the process env value).
...
No support yet for env files
2020-07-07 11:39:35 +02:00
Guillaume Tardif
efea5c8c83
Merge pull request #352 from docker/fix_error_cancel_logs
...
Exit without error message if user canceled command
2020-07-07 11:27:33 +02:00
Guillaume Tardif
0776e79e8e
Exit without error message if user canceled command (typical scenario : ACI `logs — follow` and ctrl-C while querying ACI)
2020-07-06 17:28:02 +02:00
Guillaume Tardif
7296290408
Add ”Platform” in docker inspect result, showing container OS (this field is used by VSCode)
2020-07-06 12:16:02 +02:00
Guillaume Tardif
ae76e0cf27
Merge pull request #325 from docker/error_status_context_needs_login
...
Specific exit code when command fails because azure login is required
2020-07-02 17:02:57 +02:00
Guillaume Tardif
4a1b50a9cd
Merge pull request #326 from docker/run_follow_logs
...
Run containers and attach to logs by default, detach with -d option
2020-07-02 17:02:33 +02:00
Guillaume Tardif
5eea111ecf
Run containers and attach to logs by default, detach with -d option
2020-07-02 16:45:04 +02:00
Guillaume Tardif
3c83e01e9c
Merge pull request #327 from docker/compose-go
...
Use compose-go's Project and ProjectOptions
2020-07-02 16:43:34 +02:00
Nicolas De Loof
622402709a
Use compose-go's Project and ProjectOptions
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-07-02 16:05:45 +02:00