Commit Graph

8 Commits

Author SHA1 Message Date
Umar Faruq Chowdhury 06e71371ff
docs: fix grammatical issues (#9997)
Signed-off-by: Umar Chowdhury <umarfchy@gmail.com>
Co-authored-by: Milas Bowman <milasb@gmail.com>
2022-11-29 10:52:22 -05:00
Nicolas De Loof 1ae9b3cb5d
move compose-cli code into docker/compose/v2
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2021-08-31 19:09:19 +02:00
Guillaume Tardif 794f638bec Check context description in kube e2e
Signed-off-by: Guillaume Tardif <guillaume.tardif@gmail.com>
2021-02-02 17:56:01 +01:00
Guillaume Tardif 666b859f71 Trigger tests manually with “/“ instead of “@“
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-08-20 12:19:43 +02:00
Guillaume Tardif 3a83d85d7a First ECS E2E test
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-08-19 19:13:23 +02:00
Guillaume Tardif d06d5ae358 Document optional test triggers in PR template. Beware, @test-aci or @test-windows in comments will also trigger tests, comments are not ignored for this 2020-08-11 16:49:42 +02:00
Djordje Lukic 11339761ca Change the way a context is stored
Initially we stored the context data in the `Metadata` of the context
but in hindsight this data would be better of in the `Endpoints` because
that's what it is used for.

Before:
```json
{
  "Name": "aci",
  "Metadata": {
    "Type": "aci",
    "Data": {
      "key": "value"
    }
  },
  "Endpoints": {
      "docker": {}
  }
}
```

After:
```json
{
  "Name": "aci",
  "Type": "aci",
  "Metadata": {},
  "Endpoints": {
      "aci": {
          "key": "value"
      },
      "docker": {}
  }
}
```

With this change the contexts that we create are more in line with the contexts the docker cli creates.

It also makes the code less complicated since we don't need to marsal twice any more. The API is nicer too:

```go
// Get a context:
c, err := store.Get(contextName)

// Get the stored endpoint:
var aciContext store.AciContext
if err := contextStore.GetEndpoint(currentContext, &aciContext); err != nil {
	return nil, err
}
```
2020-05-22 16:32:43 +02:00
Djordje Lukic e902e2ad93 Add pull request template 2020-05-20 14:36:46 +02:00