46d936c750
support `attach`
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2023-07-10 14:34:28 +02:00
15bc7850bb
build(deps): bump github.com/opencontainers/image-spec
...
Bumps [github.com/opencontainers/image-spec](https://github.com/opencontainers/image-spec ) from 1.1.0-rc3 to 1.1.0-rc4.
- [Release notes](https://github.com/opencontainers/image-spec/releases )
- [Changelog](https://github.com/opencontainers/image-spec/blob/main/RELEASES.md )
- [Commits](https://github.com/opencontainers/image-spec/compare/v1.1.0-rc3...v1.1.0-rc4 )
---
updated-dependencies:
- dependency-name: github.com/opencontainers/image-spec
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-07-10 14:17:14 +02:00
8a64ab56a0
Merge pull request #10760 from docker/dependabot/go_modules/gotest.tools/v3-3.5.0
...
build(deps): bump gotest.tools/v3 from 3.4.0 to 3.5.0
2023-07-10 14:16:34 +02:00
1178c51e6a
build(deps): bump gotest.tools/v3 from 3.4.0 to 3.5.0
...
Bumps [gotest.tools/v3](https://github.com/gotestyourself/gotest.tools ) from 3.4.0 to 3.5.0.
- [Release notes](https://github.com/gotestyourself/gotest.tools/releases )
- [Commits](https://github.com/gotestyourself/gotest.tools/compare/v3.4.0...v3.5.0 )
---
updated-dependencies:
- dependency-name: gotest.tools/v3
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-07-10 12:40:37 +02:00
3b3fd3e56c
build(deps): bump github.com/docker/docker
...
Bumps [github.com/docker/docker](https://github.com/docker/docker ) from 24.0.2+incompatible to 24.0.4+incompatible.
- [Release notes](https://github.com/docker/docker/releases )
- [Commits](https://github.com/docker/docker/compare/v24.0.2...v24.0.4 )
---
updated-dependencies:
- dependency-name: github.com/docker/docker
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-07-10 10:39:23 +00:00
b1e10f559e
Merge pull request #10781 from milas/deps-docs-0.6
...
deps: bump docker/cli-docs-tool to v0.6.0
2023-07-10 12:38:04 +02:00
baea5a48f5
deps: bump docker/cli-docs-tool to v0.6.0
...
Required re-running `make docs` to pick up changes.
Signed-off-by: Milas Bowman <milas.bowman@docker.com>
2023-07-10 12:23:48 +02:00
cb3a6ce52b
Merge pull request #10787 from docker/dependabot/go_modules/google.golang.org/grpc-1.56.2
...
build(deps): bump google.golang.org/grpc from 1.56.0 to 1.56.2
2023-07-10 12:23:25 +02:00
28f3802a07
build(deps): bump google.golang.org/grpc from 1.56.0 to 1.56.2
...
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go ) from 1.56.0 to 1.56.2.
- [Release notes](https://github.com/grpc/grpc-go/releases )
- [Commits](https://github.com/grpc/grpc-go/compare/v1.56.0...v1.56.2 )
---
updated-dependencies:
- dependency-name: google.golang.org/grpc
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-07-10 09:23:22 +00:00
fd0e0a2cbd
fix(secrets): file permission value does not comply with spec
...
closes #10783
Compose Spec mentions that default values for secrets is `0444` aka. world-readable permissions. However, the value was previously set to `0400`.
Signed-off-by: Shan Desai <shantanoo.desai@gmail.com>
2023-07-07 18:58:21 +02:00
e90df62bb0
Merge pull request #10763 from ndeloof/exec_index
...
when --index is not set select first service container
2023-07-07 14:39:50 +02:00
b0af2deb2b
when --index is not set select first service container
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2023-07-07 14:08:24 +02:00
be22bc735a
network: fix random missing network when service has more than one
...
As part of the fix for #10668 , the logic was adjusted so that the
default (highest-priority) network is used in the `ContainerCreate`,
and then the remaining networks are connected via calls to
`NetworkConnect` before starting the container.
Unfortunately, `ServiceConfig::NetworksByPriority` is neither
deterministic nor stable when networks have the same priority.
It's non-deterministic because the order of networks from parsing
YAML is random, since they are loaded into a Go map (which have
random iteration order). Additionally, it's not using a `SortStable`
in `compose-go`, so even if the load order was predictable, it
still might produce different results.
While I look at improving `compose-go` here to prevent this from
tripping us up in the future, this fix looks at _all_ networks for
a service and ignores the "default" one now. Before, it would
always skip the first one in the slice since that _should_ have
been the "default".
Signed-off-by: Milas Bowman <milas.bowman@docker.com>
2023-07-07 09:18:01 +02:00
b5f5e27597
don't use unitialized cli to setup DryRunClient
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2023-07-06 14:27:57 +02:00
b1334b8dfc
Merge pull request #10768 from cloud-native-team/v2
...
fix some comments
2023-07-06 10:06:05 +02:00
25ca75db4d
fix some comments
...
Signed-off-by: cui fliter <imcusg@gmail.com>
2023-07-04 11:34:49 +08:00
827e864ed0
Merge pull request #10745 from glours/add-builder-support
...
add support of --builder and BUILDX_BUILDER
2023-07-03 10:46:02 +02:00
28301fb1a4
add support of --builder and BUILDX_BUILDER
...
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
2023-07-03 10:11:18 +02:00
fa3e16c66b
Merge pull request #10742 from ulyssessouza/add-wait
...
Add `docker compose wait`
2023-07-02 13:54:34 +02:00
edd76bfd70
Add `docker compose wait`
...
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2023-06-30 16:07:03 +02:00
c496c23071
ci: upgrade compose-go to v1.15.1 ( #10757 )
...
* Fix for "`build.context` is required" errors
https://github.com/compose-spec/compose-go/releases/tag/v1.15.1
Signed-off-by: Milas Bowman <milas.bowman@docker.com>
2023-06-29 16:50:10 -04:00
02284378bf
Merge pull request #10756 from milas/network-race
...
up: fix race condition on network connect
2023-06-29 22:47:29 +02:00
10b290e682
up: fix race condition on network connect
...
Engine API only allows at most one network to be connected as
part of the ContainerCreate API request. Compose will pick the
highest priority network.
Afterwards, the remaining networks (if any) are connected before
the container is actually started.
The big change here is that, previously, the highest-priority
network was connected in the create, and then disconnected and
immediately reconnected along with all the others. This was
racy because evidently connecting the container to the network
as part of the create isn't synchronous, so sometimes when Compose
tried to disconnect it, the API would return an error like:
```
container <id> is not connected to the network <network>
```
To avoid needing to disconnect and immediately reconnect, the
network config logic has been refactored to ensure that it sets
up the network config correctly the first time.
Signed-off-by: Milas Bowman <milas.bowman@docker.com>
2023-06-29 16:00:55 -04:00
3906a7a67c
Updated documentation files for my contribution
...
Ran 'make docs' to generate updated doc files from the reference.
Signed-off-by: aroramrinaal <aroramrinaal@gmail.com>
2023-06-27 22:48:17 +02:00
83671db3dd
Fix capitalization error in sentence by adding an uppercase letter at beginning
...
Signed-off-by: aroramrinaal <aroramrinaal@gmail.com>
2023-06-27 22:48:17 +02:00
1a41678c58
fix typos
...
Signed-off-by: Jes Cok <xigua67damn@gmail.com>
2023-06-27 16:12:25 +02:00
035276e027
watch: add warning when a path is already used by a bind mount volume ( #10741 )
...
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
2023-06-26 18:56:04 -04:00
db24023884
Merge pull request #10720 from docker/dependabot/go_modules/google.golang.org/grpc-1.56.0
...
build(deps): bump google.golang.org/grpc from 1.53.0 to 1.56.0
2023-06-21 13:02:20 +02:00
c48f542962
build(deps): bump google.golang.org/grpc from 1.53.0 to 1.56.0
...
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go ) from 1.53.0 to 1.56.0.
- [Release notes](https://github.com/grpc/grpc-go/releases )
- [Commits](https://github.com/grpc/grpc-go/compare/v1.53.0...v1.56.0 )
---
updated-dependencies:
- dependency-name: google.golang.org/grpc
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-06-21 12:08:40 +02:00
42dc7a6a87
Merge pull request #10730 from glours/bump-compose-go-1.15.0
...
bump compose-go to version v1.15.0
2023-06-21 11:58:37 +02:00
30b3b47383
bump compose-go to version v1.15.0
...
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
2023-06-21 11:45:36 +02:00
061b52da9a
ci: build fix for new buildx
...
Signed-off-by: Milas Bowman <milas.bowman@docker.com>
2023-06-21 11:17:39 +02:00
04aa155878
ci: upgrade to buildx v0.11
...
https://github.com/docker/buildx/releases/tag/v0.11.0
Several `replace` directives have been removed and dependencies
aligned with buildx as needed.
Signed-off-by: Milas Bowman <milas.bowman@docker.com>
2023-06-21 11:17:39 +02:00
2d4f8d31fc
Merge pull request #10709 from ndeloof/secret_uid
...
warn user build.secrets uid,gid,mode are not implemented
2023-06-21 10:19:43 +02:00
e1f8603a62
otel: refactor root command span reporting
...
* Move all the initialization code out of `main.go`
* Ensure spans are reported when there's an error with the
command
* Attach the Compose version & active Docker context to the
resource instead of the span
* Name the root CLI span `cli/<cmd>` for clarity and grab
the full subcommand path (e.g. `alpha-viz` instead of just
`viz`)
Signed-off-by: Milas Bowman <milas.bowman@docker.com>
2023-06-20 17:25:58 +02:00
a2ce602f6c
fix race condition, waiting for containers when one exit
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2023-06-20 16:17:15 +02:00
401334e03f
build(deps): bump github.com/AlecAivazis/survey/v2 from 2.3.6 to 2.3.7 ( #10699 )
...
Bumps [github.com/AlecAivazis/survey/v2](https://github.com/AlecAivazis/survey ) from 2.3.6 to 2.3.7.
- [Release notes](https://github.com/AlecAivazis/survey/releases )
- [Commits](https://github.com/AlecAivazis/survey/compare/v2.3.6...v2.3.7 )
---
updated-dependencies:
- dependency-name: github.com/AlecAivazis/survey/v2
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-06-20 09:15:33 -04:00
93cf2b921a
use main branch of Docker Desktop repo to trigger remote workflow
...
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
2023-06-20 12:14:08 +02:00
83b2433a27
Merge pull request #10724 from glours/add-missing-comma-merge
...
add missing comma in desktop-edge-test job
2023-06-19 21:02:00 +02:00
c8d06137b5
add missing comma in desktop-edge-test job
...
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
2023-06-19 20:01:52 +02:00
c61b8aa5ac
introduce run --cap-add to run maintenance commands using service image
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2023-06-19 14:20:20 +02:00
ff3984e609
otel: fix initialization / error-handling ( #10717 )
...
* If there's no `otel` key (or the value is `null`) in the config,
don't return an error
* Propagate error from the exporter instead of panicking
Signed-off-by: Milas Bowman <milas.bowman@docker.com>
2023-06-15 12:43:15 -04:00
2efea2e9f5
Merge pull request #10715 from docker/dependabot/go_modules/golang.org/x/sync-0.3.0
...
build(deps): bump golang.org/x/sync from 0.2.0 to 0.3.0
2023-06-15 18:03:23 +02:00
6a3a95c4a8
build(deps): bump golang.org/x/sync from 0.2.0 to 0.3.0
...
Bumps [golang.org/x/sync](https://github.com/golang/sync ) from 0.2.0 to 0.3.0.
- [Commits](https://github.com/golang/sync/compare/v0.2.0...v0.3.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/sync
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-06-15 17:52:44 +02:00
fee8a1c6c6
Merge pull request #10703 from glours/add-repo-input-dd-token
...
specify origin repo in generation token step of docker desktop edge testing
2023-06-15 17:47:48 +02:00
7ffe83dc95
don't apply "rebuild" watch strategy by default
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2023-06-15 15:30:21 +02:00
d20c2551f2
warn user build.secrets uid,gid,mode are not implemented
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2023-06-14 10:21:20 +02:00
0e9a5b6b78
specify origin repo in generation token step of docker desktop edge testing
...
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
2023-06-13 16:23:51 +02:00
6887a3fc3e
Merge pull request #10702 from glours/fix-DD-APP-ID
...
add vars. prefix to DOCKERDESKTOP_APP_ID
2023-06-13 14:46:52 +02:00
586fe87f98
add vars. prefix to DOCKERDESKTOP_APP_ID
...
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
2023-06-13 14:45:26 +02:00
Nicolas De Loof
dependabot[bot]
Guillaume Lours
Milas Bowman
Shan Desai
cui fliter
Ulysses Souza
aroramrinaal
Jes Cok