119 Commits

Author SHA1 Message Date
Guillaume Tardif
f8c750277f Do not run compose local e2e tests on windows GHA nodes for now (buildkit failing with failed to mount C:\ProgramData\docker\tmp\buildkit-mount370086869: [{Type:bind Source:C:\ProgramData\docker\windowsfilter\y3952h88q6ikevun9li41hjcb Options:[rbind ro]}]: invalid windows mount type: 'bind’).
Signed-off-by: Guillaume Tardif <guillaume.tardif@gmail.com>
2020-12-15 16:21:42 +01:00
Guillaume Tardif
6d34f28beb Ensure local compose E2E are run in CI.
Signed-off-by: Guillaume Tardif <guillaume.tardif@gmail.com>
2020-12-15 15:24:02 +01:00
Chris Crone
f55616d37b build: Do not unnecessarily export images
When we do not require an image output from a `docker build` command,
we should not export an image as this just wastes time.

I believe this requires using buildx which can be enabled with
`docker buildx install`

Signed-off-by: Chris Crone <christopher.crone@docker.com>
2020-12-11 11:17:01 +01:00
Guillaume Tardif
6fc8eefb1b Remove build flag for local backend
Signed-off-by: Guillaume Tardif <guillaume.tardif@gmail.com>
2020-12-07 14:41:27 +01:00
Chris Crone
78190f8346 build: Add containerized go mod tidy
Signed-off-by: Chris Crone <christopher.crone@docker.com>
2020-12-07 12:22:58 +01:00
Ulysses Souza
1ecf8b5c5b Update make pre-commit with more checks
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-11-23 18:37:13 -03:00
Guillaume Tardif
3940b98da5 Lint packages behind feature flag : local, e2e
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-11-18 17:18:15 +01:00
Guillaume Tardif
8cc438c9a5 Pin ECS secrets sidecar image & add makefile targets
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-11-04 10:30:46 +01:00
Guillaume Tardif
8deee73857
Merge pull request #860 from gtardif/aci_bettre_clean_e2e_resource_groups
Nicer cleanup make target for ACI resources
2020-11-02 11:30:53 +01:00
Guillaume Tardif
72377355a9 Nicer cleanup make target for ACI resources
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-11-02 09:40:15 +01:00
Guillaume Tardif
3cfb252ff0 Pinned and publish docker/ecs-searchdomain-sidecar:1.0
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-30 18:35:28 +01:00
Guillaume Tardif
5bdcfe2e4a Pin version of ACI sidecar image, so that we don’t affect prod users when re-publishing :latest.
Makefile includes a target to publish new versions, ensuring we don’t override an existing image tag

Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-28 17:19:12 +01:00
Guillaume Tardif
0f417e9997 Fix Makefile command to cleanup ACI E2E resource groups
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-16 11:43:03 +02:00
Guillaume Tardif
8325768a72 Add ACI E2E resource cleanup command
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-09 10:07:13 +02:00
Guillaume Tardif
9ad06e55b5 E2e test on metrics
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-07 10:11:46 +02:00
Ulysses Souza
112794e6c9 Add pre-commit target to Makefile
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-10-01 10:55:02 +02:00
Chris Crone
d154c41586 Update copyright
Signed-off-by: Chris Crone <christopher.crone@docker.com>
2020-09-22 12:13:00 +02:00
Guillaume Lours
ae45e08d43 Remove dependabot and add a check-dependencies command in make file
Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>
2020-08-26 09:54:01 +02:00
Guillaume Tardif
3a83d85d7a First ECS E2E test
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-08-19 19:13:23 +02:00
Djordje Lukic
b41d216aaa Add import restrictions check
Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
2020-08-19 12:31:30 +02:00
Guillaume Lours
b4e45bf597 Add a script to check if go.mod and go.sum are up-to-date
Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>
2020-08-18 14:57:53 +02:00
Guillaume Lours
95de770e87 Update or add license header which are not valid
Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>
2020-08-17 16:55:25 +02:00
Guillaume Lours
97a50f8d51 Add CI step to check license headers
Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>
2020-08-17 16:55:25 +02:00
Chris Crone
017053e19a tests.e2e: Refactor
Signed-off-by: Chris Crone <christopher.crone@docker.com>
2020-08-10 14:12:46 +02:00
aiordache
2471e51b39 set build tag for the ecs context and backend
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-07-30 11:34:34 +02:00
Guillaume Tardif
0639aab22e Allow single test run with make 2020-07-08 17:07:32 +02:00
Christopher Crone
539464ed3d build: Set version when building with Docker
Signed-off-by: Christopher Crone <christopher.crone@docker.com>
2020-07-07 15:48:09 +02:00
Djordje Lukic
ad72c866cc Add license headers 2020-06-18 16:48:03 +02:00
Guillaume Tardif
bbcdad39d5 Renamed docker-classic to “com.docker.com”. 2020-06-17 17:57:53 +02:00
Djordje Lukic
39042aa8bd Build example and local backend conditionaly
* `make` will build the cli with all backends exnabled
* `make cross` will cross build without the example and local backend

You can still cross compile with all backends by doing

```console
$ BUILD_TAGS=example,local make cross
```

Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
2020-06-15 18:02:30 +02:00
Guillaume Tardif
0de2522079 Renamed Moby backend to “local” backend. This will leave “moby” available for default type contexts 2020-06-15 12:20:03 +02:00
Djordje Lukic
f19fe9e188
Merge pull request #208 from metcalfc/wsl2
Update classic Docker location depending on OS.
2020-06-13 02:41:48 -07:00
Chad Metcalf
130cb87ec9
Add a target to run docker serve
It documents how to use it and just makes it easy.
2020-06-12 16:37:42 -07:00
Chad Metcalf
39f2093827
Update classic Docker location depending on OS.
Adding support for devs on WSL2 and Linux.
2020-06-12 16:29:41 -07:00
Guillaume Tardif
93984f8c68 Removed test requiring linux containers 2020-06-11 12:58:58 +02:00
Christopher Crone
654f9ebbaf Tidy Makefiles
* Make BINARY mutability explicit
* Default docker build output type is local so use this

Signed-off-by: Christopher Crone <christopher.crone@docker.com>
2020-06-02 11:58:29 +02:00
Christopher Crone
9920fe2284 Remove unused variables
Signed-off-by: Christopher Crone <christopher.crone@docker.com>
2020-06-02 11:58:29 +02:00
Christopher Crone
247fa56ee1 More Dockerfile best practices
* Use mounts for RUN commands to avoid creating extra layers
* Use built-in platform support

Signed-off-by: Christopher Crone <christopher.crone@docker.com>
2020-06-02 11:58:24 +02:00
Guillaume Tardif
ea98a2dd78 Fix docker-classic creation makefile target 2020-05-27 21:14:07 +02:00
Djordje Lukic
129e675932 Put all protos inside the protos package 2020-05-25 15:04:28 +02:00
Djordje Lukic
1c3673c421 Add moby backend e2e tests 2020-05-25 10:24:37 +02:00
Christopher Crone
3c5d37326d Use docker build for lint
This approach allows better caching of results (so faster subsequent
lints). It also avoids bind mounts which are slow.

Benchmarks on my machine (2017 MacBook Pro 13"):
* bind mount lint: 2m 38s
* new lint (after docker builder prune): 1m 35s
* old lint (rerun no changes): 2m 38s
* new lint (rerun added println in random Go file): 9s

Signed-off-by: Christopher Crone <christopher.crone@docker.com>
2020-05-22 13:14:44 +02:00
Christopher Crone
a8146ad59c Rework e2e tests into suite
Signed-off-by: Christopher Crone <christopher.crone@docker.com>
2020-05-20 15:57:10 +02:00
Guillaume Tardif
2610b986fd delegate Moby to docker-classic binary, link docker-classic in e2e tests 2020-05-20 14:23:29 +02:00
Christopher Crone
ee4ffcb5f4 Extend lint timeout
Signed-off-by: Christopher Crone <christopher.crone@docker.com>
2020-05-18 15:12:35 +02:00
Djordje Lukic
6fd290e2b1 Add ports convet tests 2020-05-18 12:21:27 +02:00
Djordje Lukic
d8a38afecc Implement printing published ports 2020-05-16 10:41:35 +02:00
Ulysses Souza
14fb12c8c8 Let make protos affect host files
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-05-13 10:44:04 +02:00
Guillaume Tardif
eb712ac75f Added aci e2e tests, not run in CI since requiring azure login.
Need a `docker rm` command to add nginx e2e test, and compose sample to follow
2020-05-06 15:48:01 +02:00
Djordje Lukic
688e7e5deb Implement quiet flag for ps command 2020-05-06 12:18:53 +02:00