Sebastiaan van Stijn
c23a7e7281
golangci-lint: enable copyloopvar linter
...
capturing loop variables is no longer needed in go1.22 and higher;
https://go.dev/blog/loopvar-preview
This path enables the copyloopvar linter, which finds places where capturing
is no longer needed, and removes locations where they could be removed.
Also made some minor changes, and renamed some vars in places where
we could use a shorter name that's less likely to conflict with imports.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2025-02-10 13:46:41 +01:00
Nicolas De Loof
ed61e42f93
CI to validate fmt
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2024-12-17 16:50:14 +01:00
Matthieu MOREL
11e9621da5
ci: enable testifylint linter
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2024-11-12 11:12:32 +01:00
Nathan Baulch
524a97e553
Fix typos
...
Signed-off-by: Nathan Baulch <nathan.baulch@gmail.com>
2024-09-11 11:21:24 +02:00
Matthieu MOREL
4f694919ff
deps: remove deprecated github.com/pkg/errors
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2023-09-29 06:28:58 +02:00
Milas Bowman
19bbb12fac
ci: tweak restricted imports in linter ( #10992 )
...
* Eliminate direct dependency on gopkg.in/yaml.v2
* Add gopkg.in/yaml.v2 as a restricted import
* Add github.com/distribution/distribution as a restricted dependency in favor of distribution/reference which is the subset of functionality that Compose needs
* Remove an unused exclusion
NOTE: This does change the `compose config` output slightly but does NOT change the semantics:
* YAML indentation is slightly different for lists (this is a `v2` / `v3` thing)
* JSON is now "minified" instead of pretty-printed (I think this generally desirable and more consistent with other JSON command outputs)
Signed-off-by: Milas Bowman <milas.bowman@docker.com>
2023-09-11 15:53:19 +00:00
Milas Bowman
be6c9565e3
ci: bump golangci-lint to v1.53.x ( #10659 )
...
Requires some changes for depguard config
Signed-off-by: Milas Bowman <milas.bowman@docker.com>
2023-06-06 16:31:41 -04:00
Sebastiaan van Stijn
34e945a598
ci: remove uses of deprecated gotest.tools v2 ( #9935 )
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2022-11-07 14:07:41 -05:00
Milas Bowman
f72a604cbd
ci: upgrade golangci-lint
...
Need a compatible version for 1.19
Signed-off-by: Milas Bowman <milas.bowman@docker.com>
2022-09-06 17:59:11 -04:00
Ulysses Souza
9e7ae6cb30
Wake up!
...
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2022-08-19 17:18:28 +02:00
CrazyMax
5ec20296e4
Better sandboxed workflow and enhanced cross compilation
...
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
2022-08-12 15:05:58 +02:00
Milas Bowman
27227a8824
lint: add nolintlint
and clean up nolint
directives ( #9738 )
...
Signed-off-by: Milas Bowman <milas.bowman@docker.com>
2022-08-09 16:43:58 -04:00
Ulysses Souza
96cbb1cbcf
Add "style" tag to gocritic
...
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2022-07-13 19:33:06 +02:00
Ulysses Souza
d42adf6efb
Add "opinionated" tag to gocritic
...
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2022-07-13 19:33:06 +02:00
Ulysses Souza
a81f23a199
Add "diagnostic" tag to gocritic
...
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2022-07-13 19:33:06 +02:00
Ulysses Souza
2e96829607
Add gocritic to linters
...
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2022-07-13 19:33:03 +02:00
TaeyoungKwak
94f50b520c
Fix golangci syntax error in run configuration
...
Signed-off-by: TaeyoungKwak <astrokwak@gmail.com>
2022-07-03 01:45:52 +09:00
Abhinav Nair
a783cc4574
Blacklist ioutil pkg in golangci-lint
...
This is to prevent anyone from accidentally importing the pkg
Signed-off-by: Abhinav Nair <11939846+abhinavnair@users.noreply.github.com>
2022-06-28 09:20:29 +08:00
Nicolas De Loof
b6552cd935
add support for detach keys on compose run|exec
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2021-06-29 17:27:43 +02:00
Chris Crone
d27bda5e1d
build: Update golangci-lint
...
* Replace goling with revive as the former is deprecated
Signed-off-by: Chris Crone <christopher.crone@docker.com>
2021-05-19 15:00:53 +00:00
Guillaume Tardif
69f10fe80c
Extract interface / types to allow unit tests / mock
2020-05-15 10:15:56 +02:00
Guillaume Tardif
9a2ec752b5
Add ACI compose basic e2e test
2020-05-06 15:56:47 +02:00
Guillaume Tardif
eb712ac75f
Added aci e2e tests, not run in CI since requiring azure login.
...
Need a `docker rm` command to add nginx e2e test, and compose sample to follow
2020-05-06 15:48:01 +02:00
Djordje Lukic
4e9a4185af
Add make lint
and run it on CI
2020-05-05 10:50:30 +02:00
Djordje Lukic
24c035e822
Add comments on exported items, remove example command
...
Also add `make lint` to run the linter
2020-05-05 10:27:44 +02:00