mirror of
https://github.com/docker/compose.git
synced 2025-08-25 11:38:18 +02:00
4d3d9f64b9
Closes: #6890 Some remarks, - `# coding ... utf-8` statements are not needed - isdigit on strings instead of a try-catch. - Default opening mode is read, so we can do `open()` without the `'r'` everywhere - Removed inheritinng from `object` class, it isn't necessary in python3. - `super(ClassName, self)` can now be replaced with `super()` - Use of itertools and `chain` on a couple places dealing with sets. - Used the operator module instead of lambdas when warranted `itemgetter(0)` instead of `lambda x: x[0]` `attrgetter('name')` instead of `lambda x: x.name` - `sorted` returns a list, so no need to use `list(sorted(...))` - Removed `dict()` using dictionary comprehensions whenever possible - Attempted to remove python3.2 support Signed-off-by: alexrecuenco <alejandrogonzalezrecuenco@gmail.com>
241 lines
6.6 KiB
Python
241 lines
6.6 KiB
Python
import pytest
|
|
|
|
from compose.config.errors import DependencyError
|
|
from compose.config.sort_services import sort_service_dicts
|
|
from compose.config.types import VolumeFromSpec
|
|
|
|
|
|
class TestSortService:
|
|
def test_sort_service_dicts_1(self):
|
|
services = [
|
|
{
|
|
'links': ['redis'],
|
|
'name': 'web'
|
|
},
|
|
{
|
|
'name': 'grunt'
|
|
},
|
|
{
|
|
'name': 'redis'
|
|
}
|
|
]
|
|
|
|
sorted_services = sort_service_dicts(services)
|
|
assert len(sorted_services) == 3
|
|
assert sorted_services[0]['name'] == 'grunt'
|
|
assert sorted_services[1]['name'] == 'redis'
|
|
assert sorted_services[2]['name'] == 'web'
|
|
|
|
def test_sort_service_dicts_2(self):
|
|
services = [
|
|
{
|
|
'links': ['redis', 'postgres'],
|
|
'name': 'web'
|
|
},
|
|
{
|
|
'name': 'postgres',
|
|
'links': ['redis']
|
|
},
|
|
{
|
|
'name': 'redis'
|
|
}
|
|
]
|
|
|
|
sorted_services = sort_service_dicts(services)
|
|
assert len(sorted_services) == 3
|
|
assert sorted_services[0]['name'] == 'redis'
|
|
assert sorted_services[1]['name'] == 'postgres'
|
|
assert sorted_services[2]['name'] == 'web'
|
|
|
|
def test_sort_service_dicts_3(self):
|
|
services = [
|
|
{
|
|
'name': 'child'
|
|
},
|
|
{
|
|
'name': 'parent',
|
|
'links': ['child']
|
|
},
|
|
{
|
|
'links': ['parent'],
|
|
'name': 'grandparent'
|
|
},
|
|
]
|
|
|
|
sorted_services = sort_service_dicts(services)
|
|
assert len(sorted_services) == 3
|
|
assert sorted_services[0]['name'] == 'child'
|
|
assert sorted_services[1]['name'] == 'parent'
|
|
assert sorted_services[2]['name'] == 'grandparent'
|
|
|
|
def test_sort_service_dicts_4(self):
|
|
services = [
|
|
{
|
|
'name': 'child'
|
|
},
|
|
{
|
|
'name': 'parent',
|
|
'volumes_from': [VolumeFromSpec('child', 'rw', 'service')]
|
|
},
|
|
{
|
|
'links': ['parent'],
|
|
'name': 'grandparent'
|
|
},
|
|
]
|
|
|
|
sorted_services = sort_service_dicts(services)
|
|
assert len(sorted_services) == 3
|
|
assert sorted_services[0]['name'] == 'child'
|
|
assert sorted_services[1]['name'] == 'parent'
|
|
assert sorted_services[2]['name'] == 'grandparent'
|
|
|
|
def test_sort_service_dicts_5(self):
|
|
services = [
|
|
{
|
|
'links': ['parent'],
|
|
'name': 'grandparent'
|
|
},
|
|
{
|
|
'name': 'parent',
|
|
'network_mode': 'service:child'
|
|
},
|
|
{
|
|
'name': 'child'
|
|
}
|
|
]
|
|
|
|
sorted_services = sort_service_dicts(services)
|
|
assert len(sorted_services) == 3
|
|
assert sorted_services[0]['name'] == 'child'
|
|
assert sorted_services[1]['name'] == 'parent'
|
|
assert sorted_services[2]['name'] == 'grandparent'
|
|
|
|
def test_sort_service_dicts_6(self):
|
|
services = [
|
|
{
|
|
'links': ['parent'],
|
|
'name': 'grandparent'
|
|
},
|
|
{
|
|
'name': 'parent',
|
|
'volumes_from': [VolumeFromSpec('child', 'ro', 'service')]
|
|
},
|
|
{
|
|
'name': 'child'
|
|
}
|
|
]
|
|
|
|
sorted_services = sort_service_dicts(services)
|
|
assert len(sorted_services) == 3
|
|
assert sorted_services[0]['name'] == 'child'
|
|
assert sorted_services[1]['name'] == 'parent'
|
|
assert sorted_services[2]['name'] == 'grandparent'
|
|
|
|
def test_sort_service_dicts_7(self):
|
|
services = [
|
|
{
|
|
'network_mode': 'service:three',
|
|
'name': 'four'
|
|
},
|
|
{
|
|
'links': ['two'],
|
|
'name': 'three'
|
|
},
|
|
{
|
|
'name': 'two',
|
|
'volumes_from': [VolumeFromSpec('one', 'rw', 'service')]
|
|
},
|
|
{
|
|
'name': 'one'
|
|
}
|
|
]
|
|
|
|
sorted_services = sort_service_dicts(services)
|
|
assert len(sorted_services) == 4
|
|
assert sorted_services[0]['name'] == 'one'
|
|
assert sorted_services[1]['name'] == 'two'
|
|
assert sorted_services[2]['name'] == 'three'
|
|
assert sorted_services[3]['name'] == 'four'
|
|
|
|
def test_sort_service_dicts_circular_imports(self):
|
|
services = [
|
|
{
|
|
'links': ['redis'],
|
|
'name': 'web'
|
|
},
|
|
{
|
|
'name': 'redis',
|
|
'links': ['web']
|
|
},
|
|
]
|
|
|
|
with pytest.raises(DependencyError) as exc:
|
|
sort_service_dicts(services)
|
|
assert 'redis' in exc.exconly()
|
|
assert 'web' in exc.exconly()
|
|
|
|
def test_sort_service_dicts_circular_imports_2(self):
|
|
services = [
|
|
{
|
|
'links': ['postgres', 'redis'],
|
|
'name': 'web'
|
|
},
|
|
{
|
|
'name': 'redis',
|
|
'links': ['web']
|
|
},
|
|
{
|
|
'name': 'postgres'
|
|
}
|
|
]
|
|
|
|
with pytest.raises(DependencyError) as exc:
|
|
sort_service_dicts(services)
|
|
assert 'redis' in exc.exconly()
|
|
assert 'web' in exc.exconly()
|
|
|
|
def test_sort_service_dicts_circular_imports_3(self):
|
|
services = [
|
|
{
|
|
'links': ['b'],
|
|
'name': 'a'
|
|
},
|
|
{
|
|
'name': 'b',
|
|
'links': ['c']
|
|
},
|
|
{
|
|
'name': 'c',
|
|
'links': ['a']
|
|
}
|
|
]
|
|
|
|
with pytest.raises(DependencyError) as exc:
|
|
sort_service_dicts(services)
|
|
assert 'a' in exc.exconly()
|
|
assert 'b' in exc.exconly()
|
|
|
|
def test_sort_service_dicts_self_imports(self):
|
|
services = [
|
|
{
|
|
'links': ['web'],
|
|
'name': 'web'
|
|
},
|
|
]
|
|
|
|
with pytest.raises(DependencyError) as exc:
|
|
sort_service_dicts(services)
|
|
assert 'web' in exc.exconly()
|
|
|
|
def test_sort_service_dicts_depends_on_self(self):
|
|
services = [
|
|
{
|
|
'depends_on': ['web'],
|
|
'name': 'web'
|
|
},
|
|
]
|
|
|
|
with pytest.raises(DependencyError) as exc:
|
|
sort_service_dicts(services)
|
|
assert 'A service can not depend on itself: web' in exc.exconly()
|