From b8d1940bd8b74808b951284305c3c666a874ca7d Mon Sep 17 00:00:00 2001 From: Sayem Chowdhury Date: Sun, 18 Apr 2021 01:16:45 +0600 Subject: [PATCH] fix genre tagging --- src/metadata-writer/flacmetata.ts | 4 +++- src/metadata-writer/id3.ts | 8 +++++--- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/src/metadata-writer/flacmetata.ts b/src/metadata-writer/flacmetata.ts index e1fb0fb..98848cb 100644 --- a/src/metadata-writer/flacmetata.ts +++ b/src/metadata-writer/flacmetata.ts @@ -21,7 +21,9 @@ export const writeMetadataFlac = ( flac.setTag('TRACKNUMBER=' + track.TRACK_NUMBER); if (album) { - flac.setTag('GENRE=' + album.genres.data[0].name); + if (album.genres.data.length > 0) { + flac.setTag('GENRE=' + album.genres.data[0].name); + } flac.setTag('RELEASETYPE=' + album.record_type); flac.setTag('ALBUMARTIST=' + album.artist.name); flac.setTag('BARCODE=' + album.upc); diff --git a/src/metadata-writer/id3.ts b/src/metadata-writer/id3.ts index c22289c..f2a9257 100644 --- a/src/metadata-writer/id3.ts +++ b/src/metadata-writer/id3.ts @@ -22,11 +22,13 @@ export const writeMetadataMp3 = ( .setFrame('TLEN', Number(track.DURATION) * 1000); if (album) { - writer - .setFrame( + if (album.genres.data.length > 0) { + writer.setFrame( 'TCON', album.genres.data.map((g) => g.name), - ) + ); + } + writer .setFrame('TPE2', album.artist.name) .setFrame('TYER', RELEASE_YEAR) .setFrame('TDAT', album.release_date)