From ee452e67c08dce207a028661777dd58b17f829fd Mon Sep 17 00:00:00 2001
From: Sayem Chowdhury <sayem314@gmail.com>
Date: Tue, 13 Apr 2021 14:03:29 +0600
Subject: [PATCH] join artists

---
 src/metadata-writer/id3.ts | 24 +++++++++++-------------
 1 file changed, 11 insertions(+), 13 deletions(-)

diff --git a/src/metadata-writer/id3.ts b/src/metadata-writer/id3.ts
index a280536..3c8c88b 100644
--- a/src/metadata-writer/id3.ts
+++ b/src/metadata-writer/id3.ts
@@ -11,14 +11,14 @@ export const writeMetadataMp3 = (
   const writer = new id3Writer(buffer);
   const RELEASE_YEAR = album ? album.release_date.split('-')[0] : null;
 
-  const artists = track.ART_NAME.split(
-    new RegExp(' featuring | feat. | Ft. | ft. | vs | vs. | x | - |, ', 'g'),
-  ).map((a) => a.trim());
+  const artists = track.ART_NAME.split(new RegExp(' featuring | feat. | Ft. | ft. | vs | vs. | x | - |, ', 'g'))
+    .map((a) => a.trim())
+    .join(', ');
 
   writer
     .setFrame('TIT2', track.SNG_TITLE)
     .setFrame('TALB', track.ALB_TITLE)
-    .setFrame('TPE1', [artists])
+    .setFrame('TPE1', artists)
     .setFrame('TLEN', Number(track.DURATION) * 1000);
 
   if (album) {
@@ -48,7 +48,7 @@ export const writeMetadataMp3 = (
     .setFrame('TMED', 'Digital Media')
     .setFrame('TXXX', {
       description: 'Artists',
-      value: artists.join(', '),
+      value: artists,
     })
     .setFrame('TXXX', {
       description: 'ISRC',
@@ -68,16 +68,14 @@ export const writeMetadataMp3 = (
     });
 
   if (track.DISK_NUMBER) {
+    const TRACK_NUMBER = track.TRACK_NUMBER.toLocaleString('en-US', {minimumIntegerDigits: 2});
     writer.setFrame('TPOS', track.DISK_NUMBER).setFrame(
       'TRCK',
-      `${track.TRACK_NUMBER.toLocaleString('en-US', {minimumIntegerDigits: 2})}${
-        album
-          ? '/' +
-            album.nb_tracks.toLocaleString('en-US', {
-              minimumIntegerDigits: 2,
-            })
-          : ''
-      }`,
+      album
+        ? `${TRACK_NUMBER}/${album.nb_tracks.toLocaleString('en-US', {
+            minimumIntegerDigits: 2,
+          })}`
+        : TRACK_NUMBER,
     );
   }