tyler.durden
/
dashy
mirror of https://github.com/Lissy93/dashy.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

🔒 Properly deregisters event listener on destroy

This commit is contained in:
Alicia Sykes 2021-12-27 01:04:35 +00:00
parent 76ea9e0cee
commit 051ed1841c
1 changed files with 2 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/components/Widgets/EmbedWidget.vue
View File

@ -35,13 +35,8 @@ export default {
this.initiate(); this.initiate();
}, },
beforeDestroy() { beforeDestroy() {
if (this.eventListener) { window.removeEventListener('load', this.injectHtml);
window.removeEventListener(this.eventListener);
}
}, },
data: () => ({
eventListener: null,
}),
methods: { methods: {
/* Injects users content */ /* Injects users content */
injectHtml() { injectHtml() {
@ -70,9 +65,7 @@ export default {
if (document.readyState === 'complete' || document.readyState === 'loaded') { if (document.readyState === 'complete' || document.readyState === 'loaded') {
this.injectHtml(); this.injectHtml();
} else { } else {
this.eventListener = window.addEventListener('load', () => { window.addEventListener('load', this.injectHtml);
this.injectHtml();
});
} }
}, },
update() { update() {