tyler.durden/dashy
1
0
Fork 0
mirror of https://github.com/Lissy93/dashy.git synced 2025-07-23 13:45:33 +02:00
Code Issues Packages Projects Releases Wiki Activity

👷 Update PR size checker, with strip hash regex, and custom tags

Browse Source
This commit is contained in:
Alicia Sykes 2021-10-02 20:06:09 +01:00
parent 8926eab1f0
commit 248b65537e
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
.github/workflows/get-size.yml vendored
View File

@ -1,5 +1,5 @@
# Adds a comment to new PRs, showing the compressed size and size difference of new code # Adds a comment to new PRs, showing the compressed size and size difference of new code
# And labels the PR based on the number of lines changes # And also labels the PR based on the number of lines changes
name: 🌈 Check PR Size name: 🌈 Check PR Size
on: [pull_request] on: [pull_request]
jobs: jobs:
@ -13,7 +13,10 @@ jobs:
uses: preactjs/compressed-size-action@v2 uses: preactjs/compressed-size-action@v2
with: with:
repo-token: ${{ secrets.BOT_GITHUB_TOKEN }} repo-token: ${{ secrets.BOT_GITHUB_TOKEN }}
pattern: "./dist/**/**" pattern: './dist/**/*.{js,css,html}'
strip-hash: '\\b\\w{8}\\.'
exclude: '{./dist/manifest.json,**/*.map,**/node_modules/**}'
minimum-change-threshold: 100
# Check number of lines of code added # Check number of lines of code added
- name: Label based on Lines of Code - name: Label based on Lines of Code
uses: codelytv/pr-size-labeler@v1 uses: codelytv/pr-size-labeler@v1
@ -23,8 +26,13 @@ jobs:
s_max_size: '100' s_max_size: '100'
m_max_size: '500' m_max_size: '500'
l_max_size: '1000' l_max_size: '1000'
s_label: '🟩 PR - Small'
m_label: '🟨 PR - Medium'
l_label: '🟧 PR - Large'
xl_label: '🟥 PR - XL'
fail_if_xl: 'false' fail_if_xl: 'false'
message_if_xl: > message_if_xl: >
It looks like this PR is very large (over 1000 lines). It looks like this PR is very large (over 1000 lines).
Try to avoid addressing multiple issues in a single PR, and Try to avoid addressing multiple issues in a single PR, and
in the future consider breaking large tasks down into smaller steps. in the future consider breaking large tasks down into smaller steps.
This it to make reviewing, testing, reverting and general quality management easier.