mirror of
				https://github.com/go-gitea/gitea.git
				synced 2025-11-03 21:16:26 +01:00 
			
		
		
		
	Fix workflow trigger event bugs (#29467)
1. Fix incorrect `HookEventType` for issue-related events in `IssueChangeAssignee` 2. Add `case "types"` in the `switch` block in `matchPullRequestEvent` to avoid warning logs
This commit is contained in:
		
							parent
							
								
									82405f808d
								
							
						
					
					
						commit
						1ad4bb9eb7
					
				@ -441,6 +441,9 @@ func matchPullRequestEvent(gitRepo *git.Repository, commit *git.Commit, prPayloa
 | 
				
			|||||||
	// all acts conditions should be satisfied
 | 
						// all acts conditions should be satisfied
 | 
				
			||||||
	for cond, vals := range acts {
 | 
						for cond, vals := range acts {
 | 
				
			||||||
		switch cond {
 | 
							switch cond {
 | 
				
			||||||
 | 
							case "types":
 | 
				
			||||||
 | 
								// types have been checked
 | 
				
			||||||
 | 
								continue
 | 
				
			||||||
		case "branches":
 | 
							case "branches":
 | 
				
			||||||
			refName := git.RefName(prPayload.PullRequest.Base.Ref)
 | 
								refName := git.RefName(prPayload.PullRequest.Base.Ref)
 | 
				
			||||||
			patterns, err := workflowpattern.CompilePatterns(vals...)
 | 
								patterns, err := workflowpattern.CompilePatterns(vals...)
 | 
				
			||||||
 | 
				
			|||||||
@ -152,7 +152,13 @@ func (n *actionsNotifier) IssueChangeAssignee(ctx context.Context, doer *user_mo
 | 
				
			|||||||
	} else {
 | 
						} else {
 | 
				
			||||||
		action = api.HookIssueAssigned
 | 
							action = api.HookIssueAssigned
 | 
				
			||||||
	}
 | 
						}
 | 
				
			||||||
	notifyIssueChange(ctx, doer, issue, webhook_module.HookEventPullRequestAssign, action)
 | 
					
 | 
				
			||||||
 | 
						hookEvent := webhook_module.HookEventIssueAssign
 | 
				
			||||||
 | 
						if issue.IsPull {
 | 
				
			||||||
 | 
							hookEvent = webhook_module.HookEventPullRequestAssign
 | 
				
			||||||
 | 
						}
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
						notifyIssueChange(ctx, doer, issue, hookEvent, action)
 | 
				
			||||||
}
 | 
					}
 | 
				
			||||||
 | 
					
 | 
				
			||||||
// IssueChangeMilestone notifies assignee to notifiers
 | 
					// IssueChangeMilestone notifies assignee to notifiers
 | 
				
			||||||
 | 
				
			|||||||
		Loading…
	
	
			
			x
			
			
		
	
		Reference in New Issue
	
	Block a user