tyler.durden
/
gitea
mirror of https://github.com/go-gitea/gitea.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add 'make revive' to instructions for checking code (#8314) 

* Add 'make revive' to instructions for checking code

This is performed on drone, hacking instructions should contain the same to avoid unnecessary PR builds.

* lint is deprecated. Denote revive +vet as code analysis in continuous text.
This commit is contained in:
David Svantesson 2019-09-29 22:36:52 +02:00 committed by Lauris BH
parent 5774260e9b
commit 223b9d9a64
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
docs/content/doc/advanced/hacking-on-gitea.en-us.md
View File

@ -108,10 +108,10 @@ and look at our
[`.drone.yml`](https://github.com/go-gitea/gitea/blob/master/.drone.yml) to see [`.drone.yml`](https://github.com/go-gitea/gitea/blob/master/.drone.yml) to see
how our continuous integration works. how our continuous integration works.
### Formatting, linting, vetting and spell-check ### Formatting, code analysis and spell check
Our continous integration will reject PRs that are not properly formatted, fail Our continous integration will reject PRs that are not properly formatted, fail
linting, vet or spell-check. code analysis or spell check.
You should format your code with `go fmt` using: You should format your code with `go fmt` using:
@ -130,10 +130,10 @@ You should run the same version of go that is on the continuous integration
server as mentioned above. `make fmt-check` will only check if your `go` would server as mentioned above. `make fmt-check` will only check if your `go` would
format differently - this may be different from the CI server version. format differently - this may be different from the CI server version.
You should lint, vet and spell-check with: You should run revive, vet and spell-check on the code with:
```bash ```bash
make vet lint misspell-check make revive vet misspell-check
``` ```
### Updating CSS ### Updating CSS