From 5eff19a77a0e047d9712717ab4b4707eaceca642 Mon Sep 17 00:00:00 2001 From: wxiaoguang <wxiaoguang@gmail.com> Date: Wed, 15 Jan 2025 02:01:53 +0800 Subject: [PATCH] Fix sidebar milestone link (#33269) Fix #33266 --- templates/repo/issue/sidebar/milestone_list.tmpl | 8 ++++---- templates/repo/issue/sidebar/project_list.tmpl | 4 ++-- templates/repo/issue/sidebar/reviewer_list.tmpl | 6 +++--- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/templates/repo/issue/sidebar/milestone_list.tmpl b/templates/repo/issue/sidebar/milestone_list.tmpl index 8b3e5b0eee..18a16dd9a6 100644 --- a/templates/repo/issue/sidebar/milestone_list.tmpl +++ b/templates/repo/issue/sidebar/milestone_list.tmpl @@ -24,7 +24,7 @@ {{if $data.OpenMilestones}} <div class="header">{{ctx.Locale.Tr "repo.issues.filter_milestone_open"}}</div> {{range $data.OpenMilestones}} - <a class="item muted" data-value="{{.ID}}" href="{{$pageMeta.RepoLink}}/issues?milestone={{.ID}}"> + <a class="item muted" data-value="{{.ID}}" href="{{$pageMeta.RepoLink}}/milestone/{{.ID}}"> {{svg "octicon-milestone" 18}} {{.Name}} </a> {{end}} @@ -33,7 +33,7 @@ {{if $data.ClosedMilestones}} <div class="header">{{ctx.Locale.Tr "repo.issues.filter_milestone_closed"}}</div> {{range $data.ClosedMilestones}} - <a class="item muted" data-value="{{.ID}}" href="{{$pageMeta.RepoLink}}/issues?milestone={{.ID}}"> + <a class="item muted" data-value="{{.ID}}" href="{{$pageMeta.RepoLink}}/milestone/{{.ID}}"> {{svg "octicon-milestone" 18}} {{.Name}} </a> {{end}} @@ -43,10 +43,10 @@ </div> </div> - <div class="ui list"> + <div class="ui list muted-links flex-items-block"> <span class="item empty-list {{if $issueMilestone}}tw-hidden{{end}}">{{ctx.Locale.Tr "repo.issues.new.no_milestone"}}</span> {{if $issueMilestone}} - <a class="item muted" href="{{$pageMeta.RepoLink}}/milestone/{{$issueMilestone.ID}}"> + <a class="item" href="{{$pageMeta.RepoLink}}/milestone/{{$issueMilestone.ID}}"> {{svg "octicon-milestone" 18}} {{$issueMilestone.Name}} </a> {{end}} diff --git a/templates/repo/issue/sidebar/project_list.tmpl b/templates/repo/issue/sidebar/project_list.tmpl index 0cbbdce760..39feb089ef 100644 --- a/templates/repo/issue/sidebar/project_list.tmpl +++ b/templates/repo/issue/sidebar/project_list.tmpl @@ -39,10 +39,10 @@ </div> </div> </div> - <div class="ui list"> + <div class="ui list muted-links flex-items-block"> <span class="item empty-list {{if $issueProject}}tw-hidden{{end}}">{{ctx.Locale.Tr "repo.issues.new.no_projects"}}</span> {{if $issueProject}} - <a class="item muted" href="{{$issueProject.Link ctx}}"> + <a class="item" href="{{$issueProject.Link ctx}}"> {{svg $issueProject.IconName 18}} {{$issueProject.Title}} </a> {{end}} diff --git a/templates/repo/issue/sidebar/reviewer_list.tmpl b/templates/repo/issue/sidebar/reviewer_list.tmpl index b3d9590d58..b08af03a01 100644 --- a/templates/repo/issue/sidebar/reviewer_list.tmpl +++ b/templates/repo/issue/sidebar/reviewer_list.tmpl @@ -51,9 +51,9 @@ <div class="item"> <div class="flex-text-inline tw-flex-1"> {{if .User}} - <a class="muted flex-text-inline" href="{{.User.HomeLink}}">{{ctx.AvatarUtils.Avatar .User 20}} {{.User.GetDisplayName}}</a> + <a class="muted flex-text-inline tw-gap-2" href="{{.User.HomeLink}}">{{ctx.AvatarUtils.Avatar .User 20}} {{.User.GetDisplayName}}</a> {{else if .Team}} - {{svg "octicon-people" 20}} {{$repoOwnerName}}/{{.Team.Name}} + <span class="flex-text-inline tw-gap-2">{{svg "octicon-people" 20}} {{$repoOwnerName}}/{{.Team.Name}}</span> {{end}} </div> <div class="flex-text-inline"> @@ -92,7 +92,7 @@ <div class="flex-text-inline tw-flex-1"> {{$originalURLHostname := $pageMeta.Repository.GetOriginalURLHostname}} {{$originalURL := $pageMeta.Repository.OriginalURL}} - <a class="muted flex-text-inline" href="{{$originalURL}}" data-tooltip-content="{{ctx.Locale.Tr "repo.migrated_from_fake" $originalURLHostname}}"> + <a class="muted flex-text-inline tw-gap-2" href="{{$originalURL}}" data-tooltip-content="{{ctx.Locale.Tr "repo.migrated_from_fake" $originalURLHostname}}"> {{svg (MigrationIcon $originalURLHostname) 20}} {{.OriginalAuthor}} </a> </div>