From 6929edabb90ab9111e5ec432d7d5df36516f6972 Mon Sep 17 00:00:00 2001
From: Andreas Svanberg <andreas.svanberg@mensa.se>
Date: Sun, 23 Feb 2025 20:28:02 +0100
Subject: [PATCH] Change magic number since -2 has some internal meaning

---
 models/db/search.go                               | 4 ++--
 templates/repo/issue/filter_item_user_assign.tmpl | 6 +++---
 templates/repo/issue/filter_list.tmpl             | 2 +-
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/models/db/search.go b/models/db/search.go
index fa72959fa5..6e82be6709 100644
--- a/models/db/search.go
+++ b/models/db/search.go
@@ -32,8 +32,8 @@ const NoConditionID int64 = -1
 
 // AnyConditionID means a condition to filter the records which match any id.
 // The inverse of the above NoConditionID
-// eg: "assignee_id=-2" means "find the issues with an assignee"
-const AnyConditionID int64 = -2
+// eg: "assignee_id=-1000001" means "find the issues with an assignee"
+const AnyConditionID int64 = -1000001
 
 // NonExistingID means a condition to match no result (eg: a non-existing user)
 // It doesn't use -1 or -2 because they are used as builtin users.
diff --git a/templates/repo/issue/filter_item_user_assign.tmpl b/templates/repo/issue/filter_item_user_assign.tmpl
index dd5d96319a..028a0bfca5 100644
--- a/templates/repo/issue/filter_item_user_assign.tmpl
+++ b/templates/repo/issue/filter_item_user_assign.tmpl
@@ -6,7 +6,7 @@
 * TextFilterTitle
 * TextZeroValue: the text for "all issues"
 * TextNegativeOne: the text for "issues with no assignee"
-* TextNegativeTwo: the text for "issues with any assignee"
+* TextAnyCondition: the text for "issues with any assignee"
 */}}
 {{$queryLink := .QueryLink}}
 <div class="item ui dropdown jump {{if not .UserSearchList}}disabled{{end}}">
@@ -22,8 +22,8 @@
 		{{if $.TextNegativeOne}}
 			<a class="item {{if eq .SelectedUserId -1}}selected{{end}}" href="{{QueryBuild $queryLink $.QueryParamKey -1}}">{{$.TextNegativeOne}}</a>
 		{{end}}
-		{{if $.TextNegativeTwo}}
-			<a class="item {{if eq .SelectedUserId -2}}selected{{end}}" href="{{QueryBuild $queryLink $.QueryParamKey -2}}">{{$.TextNegativeTwo}}</a>
+		{{if $.TextAnyCondition}}
+			<a class="item {{if eq .SelectedUserId -1000001}}selected{{end}}" href="{{QueryBuild $queryLink $.QueryParamKey -1000001}}">{{$.TextAnyCondition}}</a>
 		{{end}}
 		<div class="divider"></div>
 		{{range .UserSearchList}}
diff --git a/templates/repo/issue/filter_list.tmpl b/templates/repo/issue/filter_list.tmpl
index 56eec7469b..ce45b5d9b6 100644
--- a/templates/repo/issue/filter_list.tmpl
+++ b/templates/repo/issue/filter_list.tmpl
@@ -96,7 +96,7 @@
 	"TextFilterTitle" (ctx.Locale.Tr "repo.issues.filter_assignee")
 	"TextZeroValue" (ctx.Locale.Tr "repo.issues.filter_assginee_no_select")
 	"TextNegativeOne" (ctx.Locale.Tr "repo.issues.filter_assginee_no_assignee")
-	"TextNegativeTwo" (ctx.Locale.Tr "repo.issues.filter_assignee_any_assignee")
+	"TextAnyCondition" (ctx.Locale.Tr "repo.issues.filter_assignee_any_assignee")
 }}
 
 {{if .IsSigned}}