From 6c4a6a13b288e062acb77aa1bdbc4b4634f6377e Mon Sep 17 00:00:00 2001 From: wxiaoguang Date: Tue, 11 Mar 2025 09:41:24 +0800 Subject: [PATCH] remove tab autoTabActivation option (unused) --- web_src/js/features/common-page.ts | 2 +- web_src/js/features/imagediff.ts | 2 +- web_src/js/modules/fomantic/tab.ts | 7 +------ 3 files changed, 3 insertions(+), 8 deletions(-) diff --git a/web_src/js/features/common-page.ts b/web_src/js/features/common-page.ts index 235555a73d..6aabfc5d4f 100644 --- a/web_src/js/features/common-page.ts +++ b/web_src/js/features/common-page.ts @@ -77,7 +77,7 @@ export function initGlobalDropdown() { } export function initGlobalTabularMenu() { - fomanticQuery('.ui.menu.tabular:not(.custom) .item').tab({autoTabActivation: false}); + fomanticQuery('.ui.menu.tabular:not(.custom) .item').tab(); } // for performance considerations, it only uses performant syntax diff --git a/web_src/js/features/imagediff.ts b/web_src/js/features/imagediff.ts index e62734293a..20682f74d9 100644 --- a/web_src/js/features/imagediff.ts +++ b/web_src/js/features/imagediff.ts @@ -75,7 +75,7 @@ class ImageDiff { this.containerEl = containerEl; containerEl.setAttribute('data-image-diff-loaded', 'true'); - fomanticQuery(containerEl).find('.ui.menu.tabular .item').tab({autoTabActivation: false}); + fomanticQuery(containerEl).find('.ui.menu.tabular .item').tab(); // the container may be hidden by "viewed" checkbox, so use the parent's width for reference this.diffContainerWidth = Math.max(containerEl.closest('.diff-file-box').clientWidth - 300, 100); diff --git a/web_src/js/modules/fomantic/tab.ts b/web_src/js/modules/fomantic/tab.ts index e1fafd909b..ceae9dd098 100644 --- a/web_src/js/modules/fomantic/tab.ts +++ b/web_src/js/modules/fomantic/tab.ts @@ -2,8 +2,7 @@ import $ from 'jquery'; import {queryElemSiblings} from '../../utils/dom.ts'; export function initFomanticTab() { - $.fn.tab = function (this: any, arg0: any) { - const autoTabActivation = arg0?.autoTabActivation; + $.fn.tab = function (this: any) { for (const elBtn of this) { const tabName = elBtn.getAttribute('data-tab'); if (!tabName) continue; @@ -14,10 +13,6 @@ export function initFomanticTab() { elBtn.classList.add('active'); elTab.classList.add('active'); }); - if (autoTabActivation && elBtn.classList.contains('active')) { - const elTab = elBtn.querySelector(`.ui.tab[data-tab="${tabName}"]`); - elTab.classList.add('active'); - } } return this; };