From 7a687caca4313eb8a77470f5b162618c4428010f Mon Sep 17 00:00:00 2001
From: yp05327 <576951401@qq.com>
Date: Tue, 25 Jul 2023 21:46:02 +0900
Subject: [PATCH] Fix wrong commit status in web ui (#26121)
Before:
After:
There's a bug in the recent logic, `CalcCommitStatus` will always return
the first item of `statuses` or error status, because `state` is defined
with default value which should be `CommitStatusSuccess`
Then
``` golang
if status.State.NoBetterThan(state) {
```
this `if` will always return false unless `status.State =
CommitStatusError` which makes no sense.
So `lastStatus` will always be `nil` or error status.
Then we will always return the first item of `statuses` here or only
return error status, and this is why in the first picture the commit
status is `Success` but not `Failure`.
https://github.com/go-gitea/gitea/blob/af1ffbcd63569df8646b20c524378f25710f129e/models/git/commit_status.go#L204-L211
Co-authored-by: Giteabot <teabot@gitea.io>
---
models/git/commit_status.go | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/models/git/commit_status.go b/models/git/commit_status.go
index c418cd23eb..17090f30dd 100644
--- a/models/git/commit_status.go
+++ b/models/git/commit_status.go
@@ -194,7 +194,7 @@ func (status *CommitStatus) APIURL(ctx context.Context) string {
// CalcCommitStatus returns commit status state via some status, the commit statues should order by id desc
func CalcCommitStatus(statuses []*CommitStatus) *CommitStatus {
var lastStatus *CommitStatus
- var state api.CommitStatusState
+ state := api.CommitStatusSuccess
for _, status := range statuses {
if status.State.NoBetterThan(state) {
state = status.State