tyler.durden/gitea
1
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2025-07-25 23:06:11 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: truncated title

Browse Source
This commit is contained in:
Jason Song 2022-12-12 10:54:28 +08:00
parent 22203eeb38
commit dbef504584
No known key found for this signature in database
GPG Key ID: 8402EEEE4511A8B5
1 changed files with 15 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
modules/notification/actions/helper.go
View File

@ -6,6 +6,7 @@ package actions
import ( import (
"context" "context"
"fmt" "fmt"
"strings"
actions_model "code.gitea.io/gitea/models/actions" actions_model "code.gitea.io/gitea/models/actions"
"code.gitea.io/gitea/models/db" "code.gitea.io/gitea/models/db"
@ -22,6 +23,7 @@ import (
"code.gitea.io/gitea/modules/json" "code.gitea.io/gitea/modules/json"
"code.gitea.io/gitea/modules/log" "code.gitea.io/gitea/modules/log"
api "code.gitea.io/gitea/modules/structs" api "code.gitea.io/gitea/modules/structs"
"code.gitea.io/gitea/modules/util"
actions_service "code.gitea.io/gitea/services/actions" actions_service "code.gitea.io/gitea/services/actions"
"github.com/nektos/act/pkg/jobparser" "github.com/nektos/act/pkg/jobparser"
@ -134,7 +136,7 @@ func notify(ctx context.Context, input *notifyInput) error {
for id, content := range workflows { for id, content := range workflows {
run := actions_model.ActionRun{ run := actions_model.ActionRun{
Title: strings.SplitN(commit.CommitMessage, "\n", 2)[0], Title: truncateContent(strings.SplitN(commit.CommitMessage, "\n", 2)[0], 255),
RepoID: input.Repo.ID, RepoID: input.Repo.ID,
OwnerID: input.Repo.OwnerID, OwnerID: input.Repo.OwnerID,
WorkflowID: id, WorkflowID: id,
@ -146,9 +148,6 @@ func notify(ctx context.Context, input *notifyInput) error {
EventPayload: string(p), EventPayload: string(p),
Status: actions_model.StatusWaiting, Status: actions_model.StatusWaiting,
} }
if len(run.Title) > 255 {
run.Title = run.Title[:255] // FIXME: we should use a better method to cut title
}
jobs, err := jobparser.Parse(content) jobs, err := jobparser.Parse(content)
if err != nil { if err != nil {
log.Error("jobparser.Parse: %v", err) log.Error("jobparser.Parse: %v", err)
@ -215,3 +214,15 @@ func notifyPackage(ctx context.Context, sender *user_model.User, pd *packages_mo
}). }).
Notify(ctx) Notify(ctx)
} }
func truncateContent(content string, n int) string {
truncatedContent, truncatedRight := util.SplitStringAtByteN(content, n)
if truncatedRight != "" {
// in case the content is in a Latin family language, we remove the last broken word.
lastSpaceIdx := strings.LastIndex(truncatedContent, " ")
if lastSpaceIdx != -1 && (len(truncatedContent)-lastSpaceIdx < 15) {
truncatedContent = truncatedContent[:lastSpaceIdx] + "…"
}
}
return truncatedContent
}