mirror of
				https://github.com/go-gitea/gitea.git
				synced 2025-11-04 13:34:43 +01:00 
			
		
		
		
	Some bugs caused by less unit tests in fundamental packages. This PR refactor `setting` package so that create a unit test will be easier than before. - All `LoadFromXXX` files has been splited as two functions, one is `InitProviderFromXXX` and `LoadCommonSettings`. The first functions will only include the code to create or new a ini file. The second function will load common settings. - It also renames all functions in setting from `newXXXService` to `loadXXXSetting` or `loadXXXFrom` to make the function name less confusing. - Move `XORMLog` to `SQLLog` because it's a better name for that. Maybe we should finally move these `loadXXXSetting` into the `XXXInit` function? Any idea? --------- Co-authored-by: 6543 <6543@obermui.de> Co-authored-by: delvh <dev.lh@web.de>
		
			
				
	
	
		
			72 lines
		
	
	
		
			1.8 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			72 lines
		
	
	
		
			1.8 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
// Copyright 2023 The Gitea Authors. All rights reserved.
 | 
						|
// SPDX-License-Identifier: MIT
 | 
						|
 | 
						|
package setting
 | 
						|
 | 
						|
import (
 | 
						|
	"fmt"
 | 
						|
	"net/mail"
 | 
						|
	"strings"
 | 
						|
 | 
						|
	"code.gitea.io/gitea/modules/log"
 | 
						|
)
 | 
						|
 | 
						|
var IncomingEmail = struct {
 | 
						|
	Enabled              bool
 | 
						|
	ReplyToAddress       string
 | 
						|
	TokenPlaceholder     string `ini:"-"`
 | 
						|
	Host                 string
 | 
						|
	Port                 int
 | 
						|
	UseTLS               bool `ini:"USE_TLS"`
 | 
						|
	SkipTLSVerify        bool `ini:"SKIP_TLS_VERIFY"`
 | 
						|
	Username             string
 | 
						|
	Password             string
 | 
						|
	Mailbox              string
 | 
						|
	DeleteHandledMessage bool
 | 
						|
	MaximumMessageSize   uint32
 | 
						|
}{
 | 
						|
	Mailbox:              "INBOX",
 | 
						|
	DeleteHandledMessage: true,
 | 
						|
	TokenPlaceholder:     "%{token}",
 | 
						|
	MaximumMessageSize:   10485760,
 | 
						|
}
 | 
						|
 | 
						|
func loadIncomingEmailFrom(rootCfg ConfigProvider) {
 | 
						|
	mustMapSetting(rootCfg, "email.incoming", &IncomingEmail)
 | 
						|
 | 
						|
	if !IncomingEmail.Enabled {
 | 
						|
		return
 | 
						|
	}
 | 
						|
 | 
						|
	if err := checkReplyToAddress(IncomingEmail.ReplyToAddress); err != nil {
 | 
						|
		log.Fatal("Invalid incoming_mail.REPLY_TO_ADDRESS (%s): %v", IncomingEmail.ReplyToAddress, err)
 | 
						|
	}
 | 
						|
}
 | 
						|
 | 
						|
func checkReplyToAddress(address string) error {
 | 
						|
	parsed, err := mail.ParseAddress(IncomingEmail.ReplyToAddress)
 | 
						|
	if err != nil {
 | 
						|
		return err
 | 
						|
	}
 | 
						|
 | 
						|
	if parsed.Name != "" {
 | 
						|
		return fmt.Errorf("name must not be set")
 | 
						|
	}
 | 
						|
 | 
						|
	c := strings.Count(IncomingEmail.ReplyToAddress, IncomingEmail.TokenPlaceholder)
 | 
						|
	switch c {
 | 
						|
	case 0:
 | 
						|
		return fmt.Errorf("%s must appear in the user part of the address (before the @)", IncomingEmail.TokenPlaceholder)
 | 
						|
	case 1:
 | 
						|
	default:
 | 
						|
		return fmt.Errorf("%s must appear only once", IncomingEmail.TokenPlaceholder)
 | 
						|
	}
 | 
						|
 | 
						|
	parts := strings.Split(IncomingEmail.ReplyToAddress, "@")
 | 
						|
	if !strings.Contains(parts[0], IncomingEmail.TokenPlaceholder) {
 | 
						|
		return fmt.Errorf("%s must appear in the user part of the address (before the @)", IncomingEmail.TokenPlaceholder)
 | 
						|
	}
 | 
						|
 | 
						|
	return nil
 | 
						|
}
 |