mirror of
https://github.com/go-gitea/gitea.git
synced 2025-12-05 12:50:23 +01:00
52902d4ece
Backport #36068 by @lunny Follow #36058 for API edit user bug when editing email. - The Admin Edit User API includes a breaking change. Previously, when updating a user with an email from an unallowed domain, the request would succeed but return a warning in the response headers. Now, the request will fail and return an error in the response body instead. - Removed `AdminAddOrSetPrimaryEmailAddress` because it will not be used any where. Fix https://github.com/go-gitea/gitea/pull/36058#issuecomment-3600005186 Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
92 lines
2.8 KiB
Go
92 lines
2.8 KiB
Go
// Copyright 2024 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package user
|
|
|
|
import (
|
|
"testing"
|
|
|
|
organization_model "code.gitea.io/gitea/models/organization"
|
|
"code.gitea.io/gitea/models/unittest"
|
|
user_model "code.gitea.io/gitea/models/user"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestReplacePrimaryEmailAddress(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
|
|
t.Run("User", func(t *testing.T) {
|
|
user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 13})
|
|
|
|
emails, err := user_model.GetEmailAddresses(t.Context(), user.ID)
|
|
assert.NoError(t, err)
|
|
assert.Len(t, emails, 1)
|
|
|
|
primary, err := user_model.GetPrimaryEmailAddressOfUser(t.Context(), user.ID)
|
|
assert.NoError(t, err)
|
|
assert.NotEqual(t, "primary-13@example.com", primary.Email)
|
|
assert.Equal(t, user.Email, primary.Email)
|
|
|
|
assert.NoError(t, ReplacePrimaryEmailAddress(t.Context(), user, "primary-13@example.com"))
|
|
|
|
primary, err = user_model.GetPrimaryEmailAddressOfUser(t.Context(), user.ID)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, "primary-13@example.com", primary.Email)
|
|
assert.Equal(t, user.Email, primary.Email)
|
|
|
|
emails, err = user_model.GetEmailAddresses(t.Context(), user.ID)
|
|
assert.NoError(t, err)
|
|
assert.Len(t, emails, 1)
|
|
|
|
assert.NoError(t, ReplacePrimaryEmailAddress(t.Context(), user, "primary-13@example.com"))
|
|
})
|
|
|
|
t.Run("Organization", func(t *testing.T) {
|
|
org := unittest.AssertExistsAndLoadBean(t, &organization_model.Organization{ID: 3})
|
|
|
|
assert.Equal(t, "org3@example.com", org.Email)
|
|
|
|
assert.NoError(t, ReplacePrimaryEmailAddress(t.Context(), org.AsUser(), "primary-org@example.com"))
|
|
|
|
assert.Equal(t, "primary-org@example.com", org.Email)
|
|
})
|
|
}
|
|
|
|
func TestAddEmailAddresses(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
|
|
user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
|
|
|
|
assert.Error(t, AddEmailAddresses(t.Context(), user, []string{" invalid email "}))
|
|
|
|
emails := []string{"user1234@example.com", "user5678@example.com"}
|
|
|
|
assert.NoError(t, AddEmailAddresses(t.Context(), user, emails))
|
|
|
|
err := AddEmailAddresses(t.Context(), user, emails)
|
|
assert.Error(t, err)
|
|
assert.True(t, user_model.IsErrEmailAlreadyUsed(err))
|
|
}
|
|
|
|
func TestDeleteEmailAddresses(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
|
|
user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
|
|
|
|
emails := []string{"user2-2@example.com"}
|
|
|
|
err := DeleteEmailAddresses(t.Context(), user, emails)
|
|
assert.NoError(t, err)
|
|
|
|
err = DeleteEmailAddresses(t.Context(), user, emails)
|
|
assert.Error(t, err)
|
|
assert.True(t, user_model.IsErrEmailAddressNotExist(err))
|
|
|
|
emails = []string{"user2@example.com"}
|
|
|
|
err = DeleteEmailAddresses(t.Context(), user, emails)
|
|
assert.Error(t, err)
|
|
assert.True(t, user_model.IsErrPrimaryEmailCannotDelete(err))
|
|
}
|