mirror of
https://github.com/go-gitea/gitea.git
synced 2025-10-31 19:45:25 +01:00
54fe47fbca
This PR upgrade xorm to v1.3.10 which fixed a bug when both `longtext json` tags in the struct field. The `longtext` will be ignored and `json` will be considered as `text`. A migration has been introduced to modify the column directly to longtext. And another two columns should also be migrated from text to longtext. All these changes only affect mysql database because for other databases Gitea supported, text is the same as longtext. Fix #27244 Fix #34764 Fix #35042
71 lines
2.5 KiB
Go
71 lines
2.5 KiB
Go
// Copyright 2025 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package v1_25
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"code.gitea.io/gitea/models/migrations/base"
|
|
"code.gitea.io/gitea/modules/setting"
|
|
"code.gitea.io/gitea/modules/timeutil"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func Test_UseLongTextInSomeColumnsAndFixBugs(t *testing.T) {
|
|
if !setting.Database.Type.IsMySQL() {
|
|
t.Skip("Only MySQL needs to change from TEXT to LONGTEXT")
|
|
}
|
|
|
|
type ReviewState struct {
|
|
ID int64 `xorm:"pk autoincr"`
|
|
UserID int64 `xorm:"NOT NULL UNIQUE(pull_commit_user)"`
|
|
PullID int64 `xorm:"NOT NULL INDEX UNIQUE(pull_commit_user) DEFAULT 0"` // Which PR was the review on?
|
|
CommitSHA string `xorm:"NOT NULL VARCHAR(64) UNIQUE(pull_commit_user)"` // Which commit was the head commit for the review?
|
|
UpdatedFiles map[string]int `xorm:"NOT NULL TEXT JSON"` // Stores for each of the changed files of a PR whether they have been viewed, changed since last viewed, or not viewed
|
|
UpdatedUnix timeutil.TimeStamp `xorm:"updated"` // Is an accurate indicator of the order of commits as we do not expect it to be possible to make reviews on previous commits
|
|
}
|
|
|
|
type PackageProperty struct {
|
|
ID int64 `xorm:"pk autoincr"`
|
|
RefType int `xorm:"INDEX NOT NULL"`
|
|
RefID int64 `xorm:"INDEX NOT NULL"`
|
|
Name string `xorm:"INDEX NOT NULL"`
|
|
Value string `xorm:"TEXT NOT NULL"`
|
|
}
|
|
|
|
type Notice struct {
|
|
ID int64 `xorm:"pk autoincr"`
|
|
Type int
|
|
Description string `xorm:"LONGTEXT"`
|
|
CreatedUnix timeutil.TimeStamp `xorm:"INDEX created"`
|
|
}
|
|
|
|
// Prepare and load the testing database
|
|
x, deferable := base.PrepareTestEnv(t, 0, new(ReviewState), new(PackageProperty), new(Notice))
|
|
defer deferable()
|
|
|
|
assert.NoError(t, UseLongTextInSomeColumnsAndFixBugs(x))
|
|
|
|
tables, err := x.DBMetas()
|
|
assert.NoError(t, err)
|
|
|
|
for _, table := range tables {
|
|
switch table.Name {
|
|
case "review_state":
|
|
column := table.GetColumn("updated_files")
|
|
assert.NotNil(t, column)
|
|
assert.Equal(t, "LONGTEXT", column.SQLType.Name)
|
|
case "package_property":
|
|
column := table.GetColumn("value")
|
|
assert.NotNil(t, column)
|
|
assert.Equal(t, "LONGTEXT", column.SQLType.Name)
|
|
case "notice":
|
|
column := table.GetColumn("description")
|
|
assert.NotNil(t, column)
|
|
assert.Equal(t, "LONGTEXT", column.SQLType.Name)
|
|
}
|
|
}
|
|
}
|