mirror of
				https://github.com/go-gitea/gitea.git
				synced 2025-11-03 21:16:26 +01:00 
			
		
		
		
	_This is a different approach to #20267, I took the liberty of adapting some parts, see below_ ## Context In some cases, a weebhook endpoint requires some kind of authentication. The usual way is by sending a static `Authorization` header, with a given token. For instance: - Matrix expects a `Bearer <token>` (already implemented, by storing the header cleartext in the metadata - which is buggy on retry #19872) - TeamCity #18667 - Gitea instances #20267 - SourceHut https://man.sr.ht/graphql.md#authentication-strategies (this is my actual personal need :) ## Proposed solution Add a dedicated encrypt column to the webhook table (instead of storing it as meta as proposed in #20267), so that it gets available for all present and future hook types (especially the custom ones #19307). This would also solve the buggy matrix retry #19872. As a first step, I would recommend focusing on the backend logic and improve the frontend at a later stage. For now the UI is a simple `Authorization` field (which could be later customized with `Bearer` and `Basic` switches):  The header name is hard-coded, since I couldn't fine any usecase justifying otherwise. ## Questions - What do you think of this approach? @justusbunsi @Gusted @silverwind - ~~How are the migrations generated? Do I have to manually create a new file, or is there a command for that?~~ - ~~I started adding it to the API: should I complete it or should I drop it? (I don't know how much the API is actually used)~~ ## Done as well: - add a migration for the existing matrix webhooks and remove the `Authorization` logic there _Closes #19872_ Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: Gusted <williamzijl7@hotmail.com> Co-authored-by: delvh <dev.lh@web.de>
		
			
				
	
	
		
			309 lines
		
	
	
		
			7.7 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			309 lines
		
	
	
		
			7.7 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
// Copyright 2014 The Gogs Authors. All rights reserved.
 | 
						|
// Copyright 2020 The Gitea Authors.
 | 
						|
// Use of this source code is governed by a MIT-style
 | 
						|
// license that can be found in the LICENSE file.
 | 
						|
 | 
						|
package repo
 | 
						|
 | 
						|
import (
 | 
						|
	"net/http"
 | 
						|
 | 
						|
	"code.gitea.io/gitea/models/perm"
 | 
						|
	"code.gitea.io/gitea/models/webhook"
 | 
						|
	"code.gitea.io/gitea/modules/context"
 | 
						|
	"code.gitea.io/gitea/modules/convert"
 | 
						|
	"code.gitea.io/gitea/modules/git"
 | 
						|
	"code.gitea.io/gitea/modules/setting"
 | 
						|
	api "code.gitea.io/gitea/modules/structs"
 | 
						|
	"code.gitea.io/gitea/modules/web"
 | 
						|
	"code.gitea.io/gitea/routers/api/v1/utils"
 | 
						|
	webhook_service "code.gitea.io/gitea/services/webhook"
 | 
						|
)
 | 
						|
 | 
						|
// ListHooks list all hooks of a repository
 | 
						|
func ListHooks(ctx *context.APIContext) {
 | 
						|
	// swagger:operation GET /repos/{owner}/{repo}/hooks repository repoListHooks
 | 
						|
	// ---
 | 
						|
	// summary: List the hooks in a repository
 | 
						|
	// produces:
 | 
						|
	// - application/json
 | 
						|
	// parameters:
 | 
						|
	// - name: owner
 | 
						|
	//   in: path
 | 
						|
	//   description: owner of the repo
 | 
						|
	//   type: string
 | 
						|
	//   required: true
 | 
						|
	// - name: repo
 | 
						|
	//   in: path
 | 
						|
	//   description: name of the repo
 | 
						|
	//   type: string
 | 
						|
	//   required: true
 | 
						|
	// - name: page
 | 
						|
	//   in: query
 | 
						|
	//   description: page number of results to return (1-based)
 | 
						|
	//   type: integer
 | 
						|
	// - name: limit
 | 
						|
	//   in: query
 | 
						|
	//   description: page size of results
 | 
						|
	//   type: integer
 | 
						|
	// responses:
 | 
						|
	//   "200":
 | 
						|
	//     "$ref": "#/responses/HookList"
 | 
						|
 | 
						|
	opts := &webhook.ListWebhookOptions{
 | 
						|
		ListOptions: utils.GetListOptions(ctx),
 | 
						|
		RepoID:      ctx.Repo.Repository.ID,
 | 
						|
	}
 | 
						|
 | 
						|
	count, err := webhook.CountWebhooksByOpts(opts)
 | 
						|
	if err != nil {
 | 
						|
		ctx.InternalServerError(err)
 | 
						|
		return
 | 
						|
	}
 | 
						|
 | 
						|
	hooks, err := webhook.ListWebhooksByOpts(ctx, opts)
 | 
						|
	if err != nil {
 | 
						|
		ctx.InternalServerError(err)
 | 
						|
		return
 | 
						|
	}
 | 
						|
 | 
						|
	apiHooks := make([]*api.Hook, len(hooks))
 | 
						|
	for i := range hooks {
 | 
						|
		apiHooks[i], err = convert.ToHook(ctx.Repo.RepoLink, hooks[i])
 | 
						|
		if err != nil {
 | 
						|
			ctx.InternalServerError(err)
 | 
						|
			return
 | 
						|
		}
 | 
						|
	}
 | 
						|
 | 
						|
	ctx.SetTotalCountHeader(count)
 | 
						|
	ctx.JSON(http.StatusOK, &apiHooks)
 | 
						|
}
 | 
						|
 | 
						|
// GetHook get a repo's hook by id
 | 
						|
func GetHook(ctx *context.APIContext) {
 | 
						|
	// swagger:operation GET /repos/{owner}/{repo}/hooks/{id} repository repoGetHook
 | 
						|
	// ---
 | 
						|
	// summary: Get a hook
 | 
						|
	// produces:
 | 
						|
	// - application/json
 | 
						|
	// parameters:
 | 
						|
	// - name: owner
 | 
						|
	//   in: path
 | 
						|
	//   description: owner of the repo
 | 
						|
	//   type: string
 | 
						|
	//   required: true
 | 
						|
	// - name: repo
 | 
						|
	//   in: path
 | 
						|
	//   description: name of the repo
 | 
						|
	//   type: string
 | 
						|
	//   required: true
 | 
						|
	// - name: id
 | 
						|
	//   in: path
 | 
						|
	//   description: id of the hook to get
 | 
						|
	//   type: integer
 | 
						|
	//   format: int64
 | 
						|
	//   required: true
 | 
						|
	// responses:
 | 
						|
	//   "200":
 | 
						|
	//     "$ref": "#/responses/Hook"
 | 
						|
	//   "404":
 | 
						|
	//     "$ref": "#/responses/notFound"
 | 
						|
 | 
						|
	repo := ctx.Repo
 | 
						|
	hookID := ctx.ParamsInt64(":id")
 | 
						|
	hook, err := utils.GetRepoHook(ctx, repo.Repository.ID, hookID)
 | 
						|
	if err != nil {
 | 
						|
		return
 | 
						|
	}
 | 
						|
	apiHook, err := convert.ToHook(repo.RepoLink, hook)
 | 
						|
	if err != nil {
 | 
						|
		ctx.InternalServerError(err)
 | 
						|
		return
 | 
						|
	}
 | 
						|
	ctx.JSON(http.StatusOK, apiHook)
 | 
						|
}
 | 
						|
 | 
						|
// TestHook tests a hook
 | 
						|
func TestHook(ctx *context.APIContext) {
 | 
						|
	// swagger:operation POST /repos/{owner}/{repo}/hooks/{id}/tests repository repoTestHook
 | 
						|
	// ---
 | 
						|
	// summary: Test a push webhook
 | 
						|
	// produces:
 | 
						|
	// - application/json
 | 
						|
	// parameters:
 | 
						|
	// - name: owner
 | 
						|
	//   in: path
 | 
						|
	//   description: owner of the repo
 | 
						|
	//   type: string
 | 
						|
	//   required: true
 | 
						|
	// - name: repo
 | 
						|
	//   in: path
 | 
						|
	//   description: name of the repo
 | 
						|
	//   type: string
 | 
						|
	//   required: true
 | 
						|
	// - name: id
 | 
						|
	//   in: path
 | 
						|
	//   description: id of the hook to test
 | 
						|
	//   type: integer
 | 
						|
	//   format: int64
 | 
						|
	//   required: true
 | 
						|
	// - name: ref
 | 
						|
	//   in: query
 | 
						|
	//   description: "The name of the commit/branch/tag, indicates which commit will be loaded to the webhook payload."
 | 
						|
	//   type: string
 | 
						|
	//   required: false
 | 
						|
	// responses:
 | 
						|
	//   "204":
 | 
						|
	//     "$ref": "#/responses/empty"
 | 
						|
 | 
						|
	if ctx.Repo.Commit == nil {
 | 
						|
		// if repo does not have any commits, then don't send a webhook
 | 
						|
		ctx.Status(http.StatusNoContent)
 | 
						|
		return
 | 
						|
	}
 | 
						|
 | 
						|
	ref := git.BranchPrefix + ctx.Repo.Repository.DefaultBranch
 | 
						|
	if r := ctx.FormTrim("ref"); r != "" {
 | 
						|
		ref = r
 | 
						|
	}
 | 
						|
 | 
						|
	hookID := ctx.ParamsInt64(":id")
 | 
						|
	hook, err := utils.GetRepoHook(ctx, ctx.Repo.Repository.ID, hookID)
 | 
						|
	if err != nil {
 | 
						|
		return
 | 
						|
	}
 | 
						|
 | 
						|
	commit := convert.ToPayloadCommit(ctx.Repo.Repository, ctx.Repo.Commit)
 | 
						|
 | 
						|
	commitID := ctx.Repo.Commit.ID.String()
 | 
						|
	if err := webhook_service.PrepareWebhook(ctx, hook, webhook.HookEventPush, &api.PushPayload{
 | 
						|
		Ref:          ref,
 | 
						|
		Before:       commitID,
 | 
						|
		After:        commitID,
 | 
						|
		CompareURL:   setting.AppURL + ctx.Repo.Repository.ComposeCompareURL(commitID, commitID),
 | 
						|
		Commits:      []*api.PayloadCommit{commit},
 | 
						|
		TotalCommits: 1,
 | 
						|
		HeadCommit:   commit,
 | 
						|
		Repo:         convert.ToRepo(ctx.Repo.Repository, perm.AccessModeNone),
 | 
						|
		Pusher:       convert.ToUserWithAccessMode(ctx.Doer, perm.AccessModeNone),
 | 
						|
		Sender:       convert.ToUserWithAccessMode(ctx.Doer, perm.AccessModeNone),
 | 
						|
	}); err != nil {
 | 
						|
		ctx.Error(http.StatusInternalServerError, "PrepareWebhook: ", err)
 | 
						|
		return
 | 
						|
	}
 | 
						|
 | 
						|
	ctx.Status(http.StatusNoContent)
 | 
						|
}
 | 
						|
 | 
						|
// CreateHook create a hook for a repository
 | 
						|
func CreateHook(ctx *context.APIContext) {
 | 
						|
	// swagger:operation POST /repos/{owner}/{repo}/hooks repository repoCreateHook
 | 
						|
	// ---
 | 
						|
	// summary: Create a hook
 | 
						|
	// consumes:
 | 
						|
	// - application/json
 | 
						|
	// produces:
 | 
						|
	// - application/json
 | 
						|
	// parameters:
 | 
						|
	// - name: owner
 | 
						|
	//   in: path
 | 
						|
	//   description: owner of the repo
 | 
						|
	//   type: string
 | 
						|
	//   required: true
 | 
						|
	// - name: repo
 | 
						|
	//   in: path
 | 
						|
	//   description: name of the repo
 | 
						|
	//   type: string
 | 
						|
	//   required: true
 | 
						|
	// - name: body
 | 
						|
	//   in: body
 | 
						|
	//   schema:
 | 
						|
	//     "$ref": "#/definitions/CreateHookOption"
 | 
						|
	// responses:
 | 
						|
	//   "201":
 | 
						|
	//     "$ref": "#/responses/Hook"
 | 
						|
	form := web.GetForm(ctx).(*api.CreateHookOption)
 | 
						|
 | 
						|
	if !utils.CheckCreateHookOption(ctx, form) {
 | 
						|
		return
 | 
						|
	}
 | 
						|
	utils.AddRepoHook(ctx, form)
 | 
						|
}
 | 
						|
 | 
						|
// EditHook modify a hook of a repository
 | 
						|
func EditHook(ctx *context.APIContext) {
 | 
						|
	// swagger:operation PATCH /repos/{owner}/{repo}/hooks/{id} repository repoEditHook
 | 
						|
	// ---
 | 
						|
	// summary: Edit a hook in a repository
 | 
						|
	// produces:
 | 
						|
	// - application/json
 | 
						|
	// parameters:
 | 
						|
	// - name: owner
 | 
						|
	//   in: path
 | 
						|
	//   description: owner of the repo
 | 
						|
	//   type: string
 | 
						|
	//   required: true
 | 
						|
	// - name: repo
 | 
						|
	//   in: path
 | 
						|
	//   description: name of the repo
 | 
						|
	//   type: string
 | 
						|
	//   required: true
 | 
						|
	// - name: id
 | 
						|
	//   in: path
 | 
						|
	//   description: index of the hook
 | 
						|
	//   type: integer
 | 
						|
	//   format: int64
 | 
						|
	//   required: true
 | 
						|
	// - name: body
 | 
						|
	//   in: body
 | 
						|
	//   schema:
 | 
						|
	//     "$ref": "#/definitions/EditHookOption"
 | 
						|
	// responses:
 | 
						|
	//   "200":
 | 
						|
	//     "$ref": "#/responses/Hook"
 | 
						|
	form := web.GetForm(ctx).(*api.EditHookOption)
 | 
						|
	hookID := ctx.ParamsInt64(":id")
 | 
						|
	utils.EditRepoHook(ctx, form, hookID)
 | 
						|
}
 | 
						|
 | 
						|
// DeleteHook delete a hook of a repository
 | 
						|
func DeleteHook(ctx *context.APIContext) {
 | 
						|
	// swagger:operation DELETE /repos/{owner}/{repo}/hooks/{id} repository repoDeleteHook
 | 
						|
	// ---
 | 
						|
	// summary: Delete a hook in a repository
 | 
						|
	// produces:
 | 
						|
	// - application/json
 | 
						|
	// parameters:
 | 
						|
	// - name: owner
 | 
						|
	//   in: path
 | 
						|
	//   description: owner of the repo
 | 
						|
	//   type: string
 | 
						|
	//   required: true
 | 
						|
	// - name: repo
 | 
						|
	//   in: path
 | 
						|
	//   description: name of the repo
 | 
						|
	//   type: string
 | 
						|
	//   required: true
 | 
						|
	// - name: id
 | 
						|
	//   in: path
 | 
						|
	//   description: id of the hook to delete
 | 
						|
	//   type: integer
 | 
						|
	//   format: int64
 | 
						|
	//   required: true
 | 
						|
	// responses:
 | 
						|
	//   "204":
 | 
						|
	//     "$ref": "#/responses/empty"
 | 
						|
	//   "404":
 | 
						|
	//     "$ref": "#/responses/notFound"
 | 
						|
	if err := webhook.DeleteWebhookByRepoID(ctx.Repo.Repository.ID, ctx.ParamsInt64(":id")); err != nil {
 | 
						|
		if webhook.IsErrWebhookNotExist(err) {
 | 
						|
			ctx.NotFound()
 | 
						|
		} else {
 | 
						|
			ctx.Error(http.StatusInternalServerError, "DeleteWebhookByRepoID", err)
 | 
						|
		}
 | 
						|
		return
 | 
						|
	}
 | 
						|
	ctx.Status(http.StatusNoContent)
 | 
						|
}
 |