mirror of
				https://github.com/go-gitea/gitea.git
				synced 2025-11-04 05:25:15 +01:00 
			
		
		
		
	Backport #23194 ## TLDR * Fix the broken page / broken image problem when click "Install" * Fix the Password Hash Algorithm display problem for #22942 * Close #20089 * Close #23183 * Close #23184 ## Details ### The broken page / broken image problem when clicking on "Install" (Redirect failed after install - #23184) Before: when clicking on "install", all new requests will fail, because the server has been restarted. Users just see a broken page with broken images, sometimes the server is not ready but the user would have been redirect to "/user/login" page, then the users see a new broken page (connection refused or something wrong ...) After: only check InstallLock=true for necessary handlers, and sleep for a while before restarting the server, then the browser has enough time to load the "post-install" page. And there is a script to check whether "/user/login" is ready, the user will only be redirected to the login page when the server is ready. ### During new instance setup fill 'Gitea Base URL' with window.location.origin - #20089 If the "app_url" input contains `localhost` (the default value from config), use current window's location href as the `app_url` (aka ROOT_URL) ### Fix the Password Hash Algorithm display problem for "Provide the ability to set password hash algorithm parameters #22942" Before: the UI shows `pbkdf2$50000$50` <details>  </details> After: the UI shows `pbkdf2` <details>  </details> ### GET data: net::ERR_INVALID_URL #23183 Cause by empty `data:` in `<link rel="manifest" href="data:{{.ManifestData}}">` Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Jason Song <i@wolfogre.com> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: techknowlogick <techknowlogick@gitea.io>
		
			
				
	
	
		
			128 lines
		
	
	
		
			4.2 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			128 lines
		
	
	
		
			4.2 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
// Copyright 2020 The Gitea Authors. All rights reserved.
 | 
						|
// SPDX-License-Identifier: MIT
 | 
						|
 | 
						|
package install
 | 
						|
 | 
						|
import (
 | 
						|
	goctx "context"
 | 
						|
	"fmt"
 | 
						|
	"html"
 | 
						|
	"net/http"
 | 
						|
	"path"
 | 
						|
 | 
						|
	"code.gitea.io/gitea/modules/httpcache"
 | 
						|
	"code.gitea.io/gitea/modules/log"
 | 
						|
	"code.gitea.io/gitea/modules/public"
 | 
						|
	"code.gitea.io/gitea/modules/setting"
 | 
						|
	"code.gitea.io/gitea/modules/templates"
 | 
						|
	"code.gitea.io/gitea/modules/web"
 | 
						|
	"code.gitea.io/gitea/modules/web/middleware"
 | 
						|
	"code.gitea.io/gitea/routers/common"
 | 
						|
	"code.gitea.io/gitea/routers/web/healthcheck"
 | 
						|
	"code.gitea.io/gitea/services/forms"
 | 
						|
 | 
						|
	"gitea.com/go-chi/session"
 | 
						|
)
 | 
						|
 | 
						|
type dataStore map[string]interface{}
 | 
						|
 | 
						|
func (d *dataStore) GetData() map[string]interface{} {
 | 
						|
	return *d
 | 
						|
}
 | 
						|
 | 
						|
func installRecovery(ctx goctx.Context) func(next http.Handler) http.Handler {
 | 
						|
	_, rnd := templates.HTMLRenderer(ctx)
 | 
						|
	return func(next http.Handler) http.Handler {
 | 
						|
		return http.HandlerFunc(func(w http.ResponseWriter, req *http.Request) {
 | 
						|
			defer func() {
 | 
						|
				// Why we need this? The first recover will try to render a beautiful
 | 
						|
				// error page for user, but the process can still panic again, then
 | 
						|
				// we have to just recover twice and send a simple error page that
 | 
						|
				// should not panic anymore.
 | 
						|
				defer func() {
 | 
						|
					if err := recover(); err != nil {
 | 
						|
						combinedErr := fmt.Sprintf("PANIC: %v\n%s", err, log.Stack(2))
 | 
						|
						log.Error("%s", combinedErr)
 | 
						|
						if setting.IsProd {
 | 
						|
							http.Error(w, http.StatusText(http.StatusInternalServerError), http.StatusInternalServerError)
 | 
						|
						} else {
 | 
						|
							http.Error(w, combinedErr, http.StatusInternalServerError)
 | 
						|
						}
 | 
						|
					}
 | 
						|
				}()
 | 
						|
 | 
						|
				if err := recover(); err != nil {
 | 
						|
					combinedErr := fmt.Sprintf("PANIC: %v\n%s", err, log.Stack(2))
 | 
						|
					log.Error("%s", combinedErr)
 | 
						|
 | 
						|
					lc := middleware.Locale(w, req)
 | 
						|
					store := dataStore{
 | 
						|
						"Language":       lc.Language(),
 | 
						|
						"CurrentURL":     setting.AppSubURL + req.URL.RequestURI(),
 | 
						|
						"locale":         lc,
 | 
						|
						"SignedUserID":   int64(0),
 | 
						|
						"SignedUserName": "",
 | 
						|
					}
 | 
						|
 | 
						|
					httpcache.AddCacheControlToHeader(w.Header(), 0, "no-transform")
 | 
						|
					w.Header().Set(`X-Frame-Options`, setting.CORSConfig.XFrameOptions)
 | 
						|
 | 
						|
					if !setting.IsProd {
 | 
						|
						store["ErrorMsg"] = combinedErr
 | 
						|
					}
 | 
						|
					err = rnd.HTML(w, http.StatusInternalServerError, "status/500", templates.BaseVars().Merge(store))
 | 
						|
					if err != nil {
 | 
						|
						log.Error("%v", err)
 | 
						|
					}
 | 
						|
				}
 | 
						|
			}()
 | 
						|
 | 
						|
			next.ServeHTTP(w, req)
 | 
						|
		})
 | 
						|
	}
 | 
						|
}
 | 
						|
 | 
						|
// Routes registers the install routes
 | 
						|
func Routes(ctx goctx.Context) *web.Route {
 | 
						|
	r := web.NewRoute()
 | 
						|
	for _, middle := range common.Middlewares() {
 | 
						|
		r.Use(middle)
 | 
						|
	}
 | 
						|
 | 
						|
	r.Use(web.WrapWithPrefix(public.AssetsURLPathPrefix, public.AssetsHandlerFunc(&public.Options{
 | 
						|
		Directory: path.Join(setting.StaticRootPath, "public"),
 | 
						|
		Prefix:    public.AssetsURLPathPrefix,
 | 
						|
	}), "InstallAssetsHandler"))
 | 
						|
 | 
						|
	r.Use(session.Sessioner(session.Options{
 | 
						|
		Provider:       setting.SessionConfig.Provider,
 | 
						|
		ProviderConfig: setting.SessionConfig.ProviderConfig,
 | 
						|
		CookieName:     setting.SessionConfig.CookieName,
 | 
						|
		CookiePath:     setting.SessionConfig.CookiePath,
 | 
						|
		Gclifetime:     setting.SessionConfig.Gclifetime,
 | 
						|
		Maxlifetime:    setting.SessionConfig.Maxlifetime,
 | 
						|
		Secure:         setting.SessionConfig.Secure,
 | 
						|
		SameSite:       setting.SessionConfig.SameSite,
 | 
						|
		Domain:         setting.SessionConfig.Domain,
 | 
						|
	}))
 | 
						|
 | 
						|
	r.Use(installRecovery(ctx))
 | 
						|
	r.Use(Init(ctx))
 | 
						|
	r.Get("/", Install) // it must be on the root, because the "install.js" use the window.location to replace the "localhost" AppURL
 | 
						|
	r.Post("/", web.Bind(forms.InstallForm{}), SubmitInstall)
 | 
						|
	r.Get("/post-install", InstallDone)
 | 
						|
	r.Get("/api/healthz", healthcheck.Check)
 | 
						|
 | 
						|
	r.NotFound(web.Wrap(installNotFound))
 | 
						|
	return r
 | 
						|
}
 | 
						|
 | 
						|
func installNotFound(w http.ResponseWriter, req *http.Request) {
 | 
						|
	w.Header().Add("Content-Type", "text/html; charset=utf-8")
 | 
						|
	w.Header().Add("Refresh", fmt.Sprintf("1; url=%s", setting.AppSubURL+"/"))
 | 
						|
	// do not use 30x status, because the "post-install" page needs to use 404/200 to detect if Gitea has been installed.
 | 
						|
	// the fetch API could follow 30x requests to the page with 200 status.
 | 
						|
	w.WriteHeader(http.StatusNotFound)
 | 
						|
	_, _ = fmt.Fprintf(w, `Not Found. <a href="%s">Go to default page</a>.`, html.EscapeString(setting.AppSubURL+"/"))
 | 
						|
}
 |