tyler.durden
/
icinga2
mirror of https://github.com/Icinga/icinga2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
icinga2/test/remote-configpackageutility...

26 lines
811 B
C++
Raw Normal View History

ConfigPackageUtility::ValidateName: replace broken regex The old validation regex matched if the name consists only of invalid character, not that it does not contain them, i.e. something like "foo/bar" was considered valid. This commit replaces the regex with a check that all characters in the name are allowed characters.
2021-06-07 13:14:06 +02:00
/* Icinga 2 | (c) 2021 Icinga GmbH | GPLv2+ */
#include "remote/configpackageutility.hpp"
#include <vector>
#include <string>
#include <BoostTestTargetConfig.h>
using namespace icinga;
BOOST_AUTO_TEST_SUITE(remote_configpackageutility)
BOOST_AUTO_TEST_CASE(ValidateName)
{
std::vector<std::string> validNames {"foo", "foo-bar", "FooBar", "Foo123", "_Foo-", "123bar"};
for (const std::string& n : validNames) {
De-couple package and stage name validation
2021-08-02 13:09:04 +02:00
BOOST_CHECK_MESSAGE(ConfigPackageUtility::ValidatePackageName(n), "'" << n << "' should be valid");
ConfigPackageUtility::ValidateName: replace broken regex The old validation regex matched if the name consists only of invalid character, not that it does not contain them, i.e. something like "foo/bar" was considered valid. This commit replaces the regex with a check that all characters in the name are allowed characters.
2021-06-07 13:14:06 +02:00
}
std::vector<std::string> invalidNames {"", ".", "..", "foo.bar", "foo/../bar", "foo/bar", "foo:bar"};
for (const std::string& n : invalidNames) {
De-couple package and stage name validation
2021-08-02 13:09:04 +02:00
BOOST_CHECK_MESSAGE(!ConfigPackageUtility::ValidatePackageName(n), "'" << n << "' should not be valid");
ConfigPackageUtility::ValidateName: replace broken regex The old validation regex matched if the name consists only of invalid character, not that it does not contain them, i.e. something like "foo/bar" was considered valid. This commit replaces the regex with a check that all characters in the name are allowed characters.
2021-06-07 13:14:06 +02:00
}
}
BOOST_AUTO_TEST_SUITE_END()