From 9902f9b88fcc1cc9205d2943b3efb71ce7ef48ee Mon Sep 17 00:00:00 2001 From: "Alexander A. Klimov" Date: Tue, 13 Dec 2022 18:01:52 +0100 Subject: [PATCH 1/2] ITL: vmware: sync updated (i.e. broken) CLI arg --- itl/plugins-contrib.d/vmware.conf | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/itl/plugins-contrib.d/vmware.conf b/itl/plugins-contrib.d/vmware.conf index 63ee3fa06..3de5bec5d 100644 --- a/itl/plugins-contrib.d/vmware.conf +++ b/itl/plugins-contrib.d/vmware.conf @@ -237,7 +237,7 @@ object CheckCommand "vmware-esx-dc-runtime-tools" { "--alertonly" = { set_if = "$vmware_alertonly$" } - "--open-vm-tools" = { + "--open_vm_tools_ok" = { set_if = "$vmware_openvmtools$" } } @@ -1142,7 +1142,7 @@ object CheckCommand "vmware-esx-soap-vm-runtime-tools" { arguments += { "--select" = "runtime" "--subselect" = "tools" - "--open-vm-tools" = { + "--open_vm_tools_ok" = { set_if = "$vmware_openvmtools$" } } From 726db57c6c13348c0660c976f04f41ba6cf70ed2 Mon Sep 17 00:00:00 2001 From: "Alexander A. Klimov" Date: Tue, 13 Dec 2022 18:08:01 +0100 Subject: [PATCH 2/2] ITL: vmware: support --no_vm_tools_ok --- doc/10-icinga-template-library.md | 2 ++ itl/plugins-contrib.d/vmware.conf | 6 ++++++ 2 files changed, 8 insertions(+) diff --git a/doc/10-icinga-template-library.md b/doc/10-icinga-template-library.md index dc3ff5df7..b29ce3a39 100644 --- a/doc/10-icinga-template-library.md +++ b/doc/10-icinga-template-library.md @@ -3947,6 +3947,7 @@ vmware_include | **Optional.** Whitelist VMs. No value defined as defau vmware_isregexp | **Optional.** Treat blacklist and whitelist expressions as regexp. vmware_multiline | **Optional.** Multiline output in overview. This mean technically that a multiline output uses a HTML **\** for the GUI. No value defined as default. vmware_openvmtools | **Optional** Prevent CRITICAL state for installed and running Open VM Tools. +vmware_novmtools | **Optional** Prevent CRITICAL state for missing VMware tools. **vmware-esx-soap-host-check** @@ -5697,6 +5698,7 @@ vmware_username | **Optional.** The username to connect to Host or vCent vmware_password | **Optional.** The username's password. No value defined as default. vmware_authfile | **Optional.** Use auth file instead username/password to session connect. No effect if **vmware_username** and **vmware_password** are defined
**Authentication file content:**
username=vmuser
password=p@ssw0rd vmware_openvmtools | **Optional** Prevent CRITICAL state for installed and running Open VM Tools. +vmware_novmtools | **Optional** Prevent CRITICAL state for missing VMware tools. **vmware-esx-soap-vm-runtime-issues** diff --git a/itl/plugins-contrib.d/vmware.conf b/itl/plugins-contrib.d/vmware.conf index 3de5bec5d..7017c8386 100644 --- a/itl/plugins-contrib.d/vmware.conf +++ b/itl/plugins-contrib.d/vmware.conf @@ -240,6 +240,9 @@ object CheckCommand "vmware-esx-dc-runtime-tools" { "--open_vm_tools_ok" = { set_if = "$vmware_openvmtools$" } + "--no_vm_tools_ok" = { + set_if = "$vmware_novmtools$" + } } } @@ -1145,6 +1148,9 @@ object CheckCommand "vmware-esx-soap-vm-runtime-tools" { "--open_vm_tools_ok" = { set_if = "$vmware_openvmtools$" } + "--no_vm_tools_ok" = { + set_if = "$vmware_novmtools$" + } } }