tyler.durden/icinga2
1
0
Fork 0
mirror of https://github.com/Icinga/icinga2.git synced 2025-07-23 13:45:04 +02:00
Code Issues Packages Projects Releases Wiki Activity

Quality: Prefer BOOST_{,UN}LIKELY gcc optimizer macros over our own

Browse Source 
Our macro collides with Boost::DateTime and the gregorian classes
and I don't see any reason why we shouldn't use Boost::Config
being already there.
This commit is contained in:
Michael Friedrich 2019-07-09 13:20:53 +02:00
parent 400d58f95f
commit 0d25ae0e08
2 changed files with 2 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/base/i2-base.hpp
View File

@ -72,14 +72,6 @@
# pragma GCC diagnostic ignored "-Wdeprecated-declarations" # pragma GCC diagnostic ignored "-Wdeprecated-declarations"
#endif #endif
#if defined(__GNUC__)
# define likely(x) __builtin_expect(!!(x), 1)
# define unlikely(x) __builtin_expect(!!(x), 0)
#else
# define likely(x) (x)
# define unlikely(x) (x)
#endif
#define BOOST_BIND_NO_PLACEHOLDERS #define BOOST_BIND_NO_PLACEHOLDERS
#include <functional> #include <functional>

4
lib/config/vmops.hpp
View File

@ -235,10 +235,10 @@ public:
static inline Value GetField(const Value& context, const String& field, bool sandboxed = false, const DebugInfo& debugInfo = DebugInfo()) static inline Value GetField(const Value& context, const String& field, bool sandboxed = false, const DebugInfo& debugInfo = DebugInfo())
{ {
if (unlikely(context.IsEmpty() && !context.IsString())) if (BOOST_UNLIKELY(context.IsEmpty() && !context.IsString()))
return Empty; return Empty;
if (unlikely(!context.IsObject())) if (BOOST_UNLIKELY(!context.IsObject()))
return GetPrototypeField(context, field, true, debugInfo); return GetPrototypeField(context, field, true, debugInfo);
Object::Ptr object = context; Object::Ptr object = context;