tyler.durden
/
icinga2
mirror of https://github.com/Icinga/icinga2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Don't trigger a fixed downtime like a flexible one 

When creating a fixed downtime that starts immediately while the checkable is
in a non-OK state, previously the code path for flexible downtimes was used to
trigger this downtime. This is fixed by this commit which resolves two issued:

1. Missing downtime start notification: notifications work differently for
   fixed and flexible downtimes. This resulted in missing downtime start
   notifications under the conditions described above.
2. Incorrect downtime trigger time: this code path would incorrectly assume the
   timestamp of the last checkable as the trigger time which is incorrect for
   fixed downtimes.
This commit is contained in:
Julian Brost 2021-12-14 11:02:40 +01:00
parent cbbaf4eac8
commit 13ea635188
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/icinga/downtime.cpp
View File

@ -127,7 +127,7 @@ void Downtime::Start(bool runtimeCreated)
* this downtime now *after* it has been added (important * this downtime now *after* it has been added (important
* for DB IDO, etc.) * for DB IDO, etc.)
*/ */
if (!checkable->IsStateOK(checkable->GetStateRaw())) { if (!GetFixed() && !checkable->IsStateOK(checkable->GetStateRaw())) {
Log(LogNotice, "Downtime") Log(LogNotice, "Downtime")
<< "Checkable '" << checkable->GetName() << "' already in a NOT-OK state." << "Checkable '" << checkable->GetName() << "' already in a NOT-OK state."
<< " Triggering downtime now."; << " Triggering downtime now.";