tyler.durden/icinga2
1
0
Fork 0
mirror of https://github.com/Icinga/icinga2.git synced 2025-07-23 05:34:48 +02:00
Code Issues Packages Projects Releases Wiki Activity

Don't use sprintf for SHA1 to hex conversion

Browse Source
This commit is contained in:
Julian Brost 2021-03-10 14:41:06 +01:00
parent 49cfda833e
commit 2a2229a49b
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/base/tlsutility.cpp
View File

@ -762,9 +762,13 @@ String SHA1(const String& s, bool binary)
if (binary) if (binary)
return String(reinterpret_cast<const char*>(digest), reinterpret_cast<const char *>(digest + SHA_DIGEST_LENGTH)); return String(reinterpret_cast<const char*>(digest), reinterpret_cast<const char *>(digest + SHA_DIGEST_LENGTH));
static const char hexdigits[] = "0123456789abcdef";
char output[SHA_DIGEST_LENGTH*2+1]; char output[SHA_DIGEST_LENGTH*2+1];
for (int i = 0; i < 20; i++) for (int i = 0; i < SHA_DIGEST_LENGTH; i++) {
sprintf(output + 2 * i, "%02x", digest[i]); output[2*i] = hexdigits[digest[i] >> 4];
output[2*i + 1] = hexdigits[digest[i] & 0xf];
}
output[2*SHA_DIGEST_LENGTH] = 0;
return output; return output;
} }