tyler.durden
/
icinga2
mirror of https://github.com/Icinga/icinga2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix memory/thread leak in the HttpServerConnection class 

fixes #10655
This commit is contained in:
Gunnar Beutner 2016-02-03 09:54:31 +01:00
parent fabf37e79c
commit 2dc385e31b
2 changed files with 15 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
lib/base/tlsstream.cpp
View File

@ -189,7 +189,7 @@ void TlsStream::OnEvent(int revents)
VERIFY(!"Invalid TlsAction");
}
if (rc < 0) {
if (rc <= 0) {
int err = SSL_get_error(m_SSL.get(), rc);
switch (err) {
@ -208,7 +208,7 @@ void TlsStream::OnEvent(int revents)
Close();
break;
return;
default:
m_ErrorCode = ERR_peek_error();
m_ErrorOccurred = true;
@ -224,7 +224,7 @@ void TlsStream::OnEvent(int revents)
Close();
break;
return;
}
}
@ -242,11 +242,12 @@ void TlsStream::OnEvent(int revents)
while (m_RecvQ->IsDataAvailable() && IsHandlingEvents())
SignalDataAvailable();
if (m_Shutdown && !m_SendQ->IsDataAvailable())
Close();
}
if (m_Shutdown && !m_SendQ->IsDataAvailable()) {
lock.unlock();
Close();
}
}
void TlsStream::HandleError(void) const
@ -312,6 +313,7 @@ void TlsStream::Write(const void *buffer, size_t count)
void TlsStream::Shutdown(void)
{
m_Shutdown = true;
ChangeEvents(POLLOUT);
}
/**
@ -324,10 +326,13 @@ void TlsStream::Close(void)
void TlsStream::CloseInternal(bool inDestructor)
{
if (!m_Eof && !inDestructor) {
if (m_Eof)
return;
m_Eof = true;
if (!inDestructor)
SignalDataAvailable();
}
SocketEvents::Unregister();

1
lib/remote/httpserverconnection.cpp
View File

@ -78,7 +78,6 @@ void HttpServerConnection::Disconnect(void)
ApiListener::Ptr listener = ApiListener::GetInstance();
listener->RemoveHttpClient(this);
if (!m_Stream->IsEof())
m_Stream->Shutdown();
}