tyler.durden/icinga2
1
0
Fork 0
mirror of https://github.com/Icinga/icinga2.git synced 2025-04-08 17:05:25 +02:00
Code Issues Packages Projects Releases Wiki Activity

Host::GetHost(): return early to remove a nesting level

Browse Source 
No change in functionality. The first two branches actually set the final
return value for the method, so they can just return directly, removing the
need to have the rest of the function inside an else block.
This commit is contained in:
Julian Brost 2025-03-31 13:21:02 +02:00
parent 6443f8997f
commit 2ebee010f0
1 changed files with 19 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
lib/icinga/host.cpp
View File

@ -170,29 +170,30 @@ HostState Host::GetLastHardState() const
* sort by severity. It is therefore easier to keep them seperated here. */
int Host::GetSeverity() const
{
int severity = 0;
ObjectLock olock(this);
HostState state = GetState();
if (!HasBeenChecked()) {
severity = 16;
} else if (state == HostUp) {
severity = 0;
} else {
if (IsReachable()) {
severity = 64;
} else {
severity = 32;
}
return 16;
}
if (state == HostUp) {
return 0;
}
if (IsAcknowledged()) {
severity += 512;
} else if (IsInDowntime()) {
severity += 256;
} else {
severity += 2048;
}
int severity = 0;
if (IsReachable()) {
severity = 64;
} else {
severity = 32;
}
if (IsAcknowledged()) {
severity += 512;
} else if (IsInDowntime()) {
severity += 256;
} else {
severity += 2048;
}
olock.Unlock();