tyler.durden
/
icinga2
mirror of https://github.com/Icinga/icinga2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Don't override Type#GetLoadDependencies() if latter is sufficient 

If a specific type shall return no deps, the base method already does that.
This commit is contained in:
Alexander A. Klimov 2024-09-18 15:19:32 +02:00
parent e678f0977d
commit 36742c27b9
1 changed files with 11 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
tools/mkclass/classcompiler.cpp
View File

@ -376,19 +376,21 @@ void ClassCompiler::HandleClass(const Klass& klass, const ClassDebugInfo&)
<< "}" << std::endl << std::endl; << "}" << std::endl << std::endl;
/* GetLoadDependencies */ /* GetLoadDependencies */
m_Header << "\t" << "const std::unordered_set<Type*>& GetLoadDependencies() const override;" << std::endl; if (!klass.LoadDependencies.empty()) {
m_Header << "\tconst std::unordered_set<Type*>& GetLoadDependencies() const override;" << std::endl;
m_Impl << "const std::unordered_set<Type*>& TypeImpl<" << klass.Name << ">::GetLoadDependencies() const" << std::endl m_Impl << "const std::unordered_set<Type*>& TypeImpl<" << klass.Name << ">::GetLoadDependencies() const" << std::endl
<< "{" << std::endl << "{" << std::endl
<< "\t" << "static const std::unordered_set<Type*> deps ({" << std::endl; << "\tstatic const std::unordered_set deps ({" << std::endl;
for (const std::string& dep : klass.LoadDependencies) for (const std::string& dep : klass.LoadDependencies)
m_Impl << "\t\t" << "GetByName(\"" << dep << "\").get()," << std::endl; m_Impl << "\t\tGetByName(\"" << dep << "\").get()," << std::endl;
m_Impl << "\t" << "});" << std::endl; m_Impl << "\t});" << std::endl;
m_Impl << "\t" << "return deps;" << std::endl m_Impl << "\treturn deps;" << std::endl
<< "}" << std::endl << std::endl; << "}" << std::endl << std::endl;
}
/* GetActivationPriority */ /* GetActivationPriority */
m_Header << "\t" << "int GetActivationPriority() const override;" << std::endl; m_Header << "\t" << "int GetActivationPriority() const override;" << std::endl;