tyler.durden
/
icinga2
mirror of https://github.com/Icinga/icinga2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix lock contention in ThreadPool::Post.

This commit is contained in:
Gunnar Beutner 2013-09-18 11:22:52 +02:00
parent f176d8f28b
commit 3946c388c5
1 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
lib/base/threadpool.cpp
View File

@ -205,17 +205,19 @@ void ThreadPool::QueueThreadProc(int tid)
*/ */
bool ThreadPool::Post(const ThreadPool::WorkFunction& callback) bool ThreadPool::Post(const ThreadPool::WorkFunction& callback)
{ {
boost::mutex::scoped_lock lock(m_Mutex);
if (m_Stopped)
return false;
WorkItem wi; WorkItem wi;
wi.Callback = callback; wi.Callback = callback;
wi.Timestamp = Utility::GetTime(); wi.Timestamp = Utility::GetTime();
m_WorkItems.push_back(wi); {
m_WorkCV.notify_one(); boost::mutex::scoped_lock lock(m_Mutex);
if (m_Stopped)
return false;
m_WorkItems.push_back(wi);
m_WorkCV.notify_one();
}
return true; return true;
} }