tyler.durden/icinga2
1
0
Fork 0
mirror of https://github.com/Icinga/icinga2.git synced 2025-04-08 17:05:25 +02:00
Code Issues Packages Projects Releases Wiki Activity

Improve error reporting for the client certificate check

Browse Source 
Until now, client certificates that have failed verification were reported as not being signed by the CA. That is not true for all cases. This patch adds an explanation in the debug log why verification failed.

fixes #12201
This commit is contained in:
Stephan Tesch 2016-07-21 20:00:32 +00:00 committed by Gunnar Beutner
parent caf2812f0d
commit 431c110056
3 changed files with 17 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
lib/base/tlsstream.cpp
View File

@ -92,8 +92,16 @@ int TlsStream::ValidateCertificate(int preverify_ok, X509_STORE_CTX *ctx)
{
SSL *ssl = static_cast<SSL *>(X509_STORE_CTX_get_ex_data(ctx, SSL_get_ex_data_X509_STORE_CTX_idx()));
TlsStream *stream = static_cast<TlsStream *>(SSL_get_ex_data(ssl, m_SSLIndex));
if (!preverify_ok)
if (!preverify_ok) {
stream->m_VerifyOK = false;
std::ostringstream msgbuf;
int err = X509_STORE_CTX_get_error(ctx);
msgbuf << "code " << err << ": " << X509_verify_cert_error_string(err);
stream->m_VerifyError = msgbuf.str();
}
return 1;
}
@ -102,6 +110,11 @@ bool TlsStream::IsVerifyOK(void) const
return m_VerifyOK;
}
String TlsStream::GetVerifyError(void) const
{
return m_VerifyError;
}
/**
* Retrieves the X509 certficate for this client.
*

2
lib/base/tlsstream.hpp
View File

@ -69,6 +69,7 @@ public:
virtual bool IsDataAvailable(void) const override;
bool IsVerifyOK(void) const;
String GetVerifyError(void) const;
private:
boost::shared_ptr<SSL> m_SSL;
@ -77,6 +78,7 @@ private:
mutable boost::condition_variable m_CV;
bool m_HandshakeOK;
bool m_VerifyOK;
String m_VerifyError;
int m_ErrorCode;
bool m_ErrorOccurred;

2
lib/remote/apilistener.cpp
View File

@ -363,7 +363,7 @@ void ApiListener::NewClientHandlerInternal(const Socket::Ptr& client, const Stri
log << "New client connection for identity '" << identity << "'";
if (!verify_ok)
log << " (client certificate not signed by CA)";
log << " (certificate validation failed: " << tlsStream->GetVerifyError() << ")";
else if (!endpoint)
log << " (no Endpoint object found for identity)";
}