From eabba2de423539acd118e83b28a19544ae1a101d Mon Sep 17 00:00:00 2001 From: Michael Friedrich Date: Fri, 6 Sep 2019 09:31:16 +0200 Subject: [PATCH] Always reset Boost beast buffer in HttpServerConnection#ProcessMessages refs #7431 --- lib/remote/httpserverconnection.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/remote/httpserverconnection.cpp b/lib/remote/httpserverconnection.cpp index e2db0641e..88a0af5fb 100644 --- a/lib/remote/httpserverconnection.cpp +++ b/lib/remote/httpserverconnection.cpp @@ -475,6 +475,8 @@ void HttpServerConnection::ProcessMessages(boost::asio::yield_context yc) response.set(http::field::server, l_ServerHeader); + // Best practice is to always reset the buffer. + buf = {}; if (!EnsureValidHeaders(*m_Stream, buf, parser, response, yc)) { break; } @@ -520,6 +522,8 @@ void HttpServerConnection::ProcessMessages(boost::asio::yield_context yc) break; } + // Best practice is to always reset the buffer. + buf = {}; if (!EnsureValidBody(*m_Stream, buf, parser, authenticatedUser, response, yc)) { break; }