From 67664ad7b7a5526606e0d1059e0be9be0940fa11 Mon Sep 17 00:00:00 2001 From: Julian Brost Date: Thu, 6 Feb 2025 15:46:24 +0100 Subject: [PATCH] Checkable::GetAllChildrenInternal: remove redundant emplace call `checkable` is already added to the set by the insert call above, so calling emplace for the same checkable doesn't do anything useful and can be removed. --- lib/icinga/checkable-dependency.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/icinga/checkable-dependency.cpp b/lib/icinga/checkable-dependency.cpp index 40d66f59f..a302f3aec 100644 --- a/lib/icinga/checkable-dependency.cpp +++ b/lib/icinga/checkable-dependency.cpp @@ -223,7 +223,6 @@ void Checkable::GetAllChildrenInternal(std::set& seenChildren, i for (const Checkable::Ptr& checkable : GetChildren()) { if (auto [_, inserted] = seenChildren.insert(checkable); inserted) { - seenChildren.emplace(checkable); checkable->GetAllChildrenInternal(seenChildren, level + 1); } }