tyler.durden/icinga2
1
0
Fork 0
mirror of https://github.com/Icinga/icinga2.git synced 2025-07-24 22:24:44 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #6199 from Icinga/fix/action-http-code

Browse Source 
Return 500 when no api action is successful
This commit is contained in:
Jean Flach 2018-04-06 11:20:43 +02:00 committed by GitHub
commit 6d81c5c34f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
lib/remote/actionshandler.cpp
View File

@ -91,11 +91,23 @@ bool ActionsHandler::HandleRequest(const ApiUser::Ptr& user, HttpRequest& reques
} }
} }
int statusCode = 500;
String statusMessage = "No action executed successfully";
for (const Dictionary::Ptr& res : results) {
if (res->Contains("code") && res->Get("code") == 200) {
statusCode = 200;
statusMessage = "OK";
break;
}
}
response.SetStatus(statusCode, statusMessage);
Dictionary::Ptr result = new Dictionary({ Dictionary::Ptr result = new Dictionary({
{ "results", new Array(std::move(results)) } { "results", new Array(std::move(results)) }
}); });
response.SetStatus(200, "OK");
HttpUtility::SendJsonBody(response, params, result); HttpUtility::SendJsonBody(response, params, result);
return true; return true;