tyler.durden/icinga2
1
0
Fork 0
mirror of https://github.com/Icinga/icinga2.git synced 2025-04-08 17:05:25 +02:00
Code Issues Packages Projects Releases Wiki Activity

Shuffle items before config validation

Browse Source 
refs #6581
This commit is contained in:
Jean Flach 2018-08-31 13:11:50 +02:00 committed by Michael Friedrich
parent 7f7e81d905
commit 6ebb507af7
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/config/configitem.cpp
View File

@ -38,6 +38,8 @@
#include "base/function.hpp" #include "base/function.hpp"
#include <sstream> #include <sstream>
#include <fstream> #include <fstream>
#include <algorithm>
#include <random>
using namespace icinga; using namespace icinga;
@ -428,6 +430,10 @@ bool ConfigItem::CommitNewItems(const ActivationContext::Ptr& context, WorkQueue
if (items.empty()) if (items.empty())
return true; return true;
// Shuffle all items to evenly distribute them over the threads of the workqueue. This increases perfomance
// noticably in environments with lots of objects and available threads.
std::shuffle(std::begin(items), std::end(items), std::default_random_engine {});
for (const auto& ip : items) for (const auto& ip : items)
newItems.push_back(ip.first); newItems.push_back(ip.first);