tyler.durden/icinga2
1
0
Fork 0
mirror of https://github.com/Icinga/icinga2.git synced 2025-07-28 08:04:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

ElasticsearchWriter#Pause(): call Flush() only once

Browse Source 
The first Flush() is redundant and may access m_DataBuffer at the same time as some Flush() in m_WorkQueue (race condition) which isn't joined, yet.
This commit is contained in:
Alexander Aleksandrovič Klimov 2023-06-29 10:42:12 +02:00 committed by Alexander A. Klimov
parent 02ddb4badc
commit 73f8c4473e
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
lib/perfdata/elasticsearchwriter.cpp
View File

@ -117,7 +117,6 @@ void ElasticsearchWriter::Pause()
m_HandleStateChanges.disconnect(); m_HandleStateChanges.disconnect();
m_HandleNotifications.disconnect(); m_HandleNotifications.disconnect();
Flush();
m_WorkQueue.Join(); m_WorkQueue.Join();
Flush(); Flush();