tyler.durden/icinga2
1
0
Fork 0
mirror of https://github.com/Icinga/icinga2.git synced 2025-07-27 07:34:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

Checkable: Don't always trigger reachablity changed signal

Browse Source 
But only when the current check result being processed affects the child
Checkables in any way.
This commit is contained in:
Yonas Habteab 2025-02-06 08:58:03 +01:00
parent c64ae1af0f
commit 772420a438
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/icinga/checkable-check.cpp
View File

@ -154,6 +154,10 @@ Checkable::ProcessingResult Checkable::ProcessCheckResult(const CheckResult::Ptr
bool reachable = IsReachable(); bool reachable = IsReachable();
bool notification_reachable = IsReachable(DependencyNotification); bool notification_reachable = IsReachable(DependencyNotification);
// Cache whether the previous state of this Checkable affects its children before overwriting the last check result.
// This will be used to determine whether the on reachability changed event should be triggered.
bool affectsPreviousStateChildren(reachable && AffectsChildren());
ObjectLock olock(this); ObjectLock olock(this);
CheckResult::Ptr old_cr = GetLastCheckResult(); CheckResult::Ptr old_cr = GetLastCheckResult();
@ -533,7 +537,7 @@ Checkable::ProcessingResult Checkable::ProcessCheckResult(const CheckResult::Ptr
} }
/* update reachability for child objects */ /* update reachability for child objects */
if ((stateChange || hardChange) && !children.empty()) if ((stateChange || hardChange) && !children.empty() && (affectsPreviousStateChildren || AffectsChildren()))
OnReachabilityChanged(this, cr, children, origin); OnReachabilityChanged(this, cr, children, origin);
return Result::Ok; return Result::Ok;