tyler.durden
/
icinga2
mirror of https://github.com/Icinga/icinga2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Avoid allocations in ScriptUtils::Match

This commit is contained in:
Gunnar Beutner 2017-12-18 09:58:55 +01:00
parent 0d40009a3c
commit 80b72cfb1c
1 changed files with 71 additions and 63 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

134
lib/base/scriptutils.cpp
View File

@ -110,10 +110,8 @@ bool ScriptUtils::Regex(const std::vector<Value>& args)
if (args.size() < 2) if (args.size() < 2)
BOOST_THROW_EXCEPTION(std::invalid_argument("Regular expression and text must be specified.")); BOOST_THROW_EXCEPTION(std::invalid_argument("Regular expression and text must be specified."));
Array::Ptr texts = new Array();
String pattern = args[0]; String pattern = args[0];
Value argTexts = args[1]; const Value& argTexts = args[1];
MatchType mode; MatchType mode;
if (args.size() > 2) if (args.size() > 2)
@ -121,34 +119,40 @@ bool ScriptUtils::Regex(const std::vector<Value>& args)
else else
mode = MatchAll; mode = MatchAll;
if (argTexts.IsObjectType<Array>()) boost::regex expr(pattern.GetData());
Array::Ptr texts;
if (argTexts.IsObject())
texts = argTexts; texts = argTexts;
else {
texts = new Array();
texts->Add(argTexts);
}
if (texts->GetLength() == 0) if (texts) {
return false; ObjectLock olock(texts);
ObjectLock olock(texts); if (texts->GetLength() == 0)
for (const String& text : texts) { return false;
bool res = false;
try { for (const String& text : texts) {
boost::regex expr(pattern.GetData()); bool res = false;
boost::smatch what; try {
res = boost::regex_search(text.GetData(), what, expr); boost::smatch what;
} catch (boost::exception&) { res = boost::regex_search(text.GetData(), what, expr);
res = false; /* exception means something went terribly wrong */ } catch (boost::exception&) {
res = false; /* exception means something went terribly wrong */
}
if (mode == MatchAny && res)
return true;
else if (mode == MatchAll && !res)
return false;
} }
if (mode == MatchAny && res) return true;
return true; } else {
else if (mode == MatchAll && !res) String text = argTexts;
return false; boost::smatch what;
return boost::regex_search(text.GetData(), what, expr);
} }
return mode == MatchAll;
} }
bool ScriptUtils::Match(const std::vector<Value>& args) bool ScriptUtils::Match(const std::vector<Value>& args)
@ -156,10 +160,8 @@ bool ScriptUtils::Match(const std::vector<Value>& args)
if (args.size() < 2) if (args.size() < 2)
BOOST_THROW_EXCEPTION(std::invalid_argument("Pattern and text must be specified.")); BOOST_THROW_EXCEPTION(std::invalid_argument("Pattern and text must be specified."));
Array::Ptr texts = new Array();
String pattern = args[0]; String pattern = args[0];
Value argTexts = args[1]; const Value& argTexts = args[1];
MatchType mode; MatchType mode;
if (args.size() > 2) if (args.size() > 2)
@ -167,27 +169,31 @@ bool ScriptUtils::Match(const std::vector<Value>& args)
else else
mode = MatchAll; mode = MatchAll;
if (argTexts.IsObjectType<Array>()) Array::Ptr texts;
if (argTexts.IsObject())
texts = argTexts; texts = argTexts;
else {
texts = new Array();
texts->Add(argTexts);
}
if (texts->GetLength() == 0) if (texts) {
return false; ObjectLock olock(texts);
ObjectLock olock(texts); if (texts->GetLength() == 0)
for (const String& text : texts) {
bool res = Utility::Match(pattern, text);
if (mode == MatchAny && res)
return true;
else if (mode == MatchAll && !res)
return false; return false;
}
return mode == MatchAll; for (const String& text : texts) {
bool res = Utility::Match(pattern, text);
if (mode == MatchAny && res)
return true;
else if (mode == MatchAll && !res)
return false;
}
return true;
} else {
String text = argTexts;
return Utility::Match(pattern, argTexts);
}
} }
bool ScriptUtils::CidrMatch(const std::vector<Value>& args) bool ScriptUtils::CidrMatch(const std::vector<Value>& args)
@ -195,10 +201,8 @@ bool ScriptUtils::CidrMatch(const std::vector<Value>& args)
if (args.size() < 2) if (args.size() < 2)
BOOST_THROW_EXCEPTION(std::invalid_argument("CIDR and IP address must be specified.")); BOOST_THROW_EXCEPTION(std::invalid_argument("CIDR and IP address must be specified."));
Array::Ptr ips = new Array();
String pattern = args[0]; String pattern = args[0];
Value argIps = args[1]; const Value& argIps = args[1];
MatchType mode; MatchType mode;
if (args.size() > 2) if (args.size() > 2)
@ -206,27 +210,31 @@ bool ScriptUtils::CidrMatch(const std::vector<Value>& args)
else else
mode = MatchAll; mode = MatchAll;
if (argIps.IsObjectType<Array>()) Array::Ptr ips;
if (argIps.IsObject())
ips = argIps; ips = argIps;
else {
ips = new Array();
ips->Add(argIps);
}
if (ips->GetLength() == 0) if (ips) {
return false; ObjectLock olock(ips);
ObjectLock olock(ips); if (ips->GetLength() == 0)
for (const String& ip : ips) {
bool res = Utility::CidrMatch(pattern, ip);
if (mode == MatchAny && res)
return true;
else if (mode == MatchAll && !res)
return false; return false;
}
return mode == MatchAll; for (const String& ip : ips) {
bool res = Utility::CidrMatch(pattern, ip);
if (mode == MatchAny && res)
return true;
else if (mode == MatchAll && !res)
return false;
}
return true;
} else {
String ip = argIps;
return Utility::CidrMatch(pattern, ip);
}
} }
double ScriptUtils::Len(const Value& value) double ScriptUtils::Len(const Value& value)